From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71262C432BE for ; Fri, 23 Jul 2021 08:05:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F83960EE6 for ; Fri, 23 Jul 2021 08:05:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2F83960EE6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:37366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6qBk-0001sI-7N for qemu-devel@archiver.kernel.org; Fri, 23 Jul 2021 04:05:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6qAC-0000MD-Se for qemu-devel@nongnu.org; Fri, 23 Jul 2021 04:04:08 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:50112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6qAB-0004lG-Bg for qemu-devel@nongnu.org; Fri, 23 Jul 2021 04:04:08 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8C0B121CC9; Fri, 23 Jul 2021 08:04:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627027444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s4heI5Mvwb/CUy10lhvbvGcY49F5tI0wLXhQRaefPKA=; b=aKznCDqKk5qMFIu699DeFIqzsaP/2YhKxXfNl0m5BDihzOaUwr6dWAUf+KVUEDpbxClyY6 j9MvYMW5fKDq7iSUPYVH7KAnwpXisP+ZtK2K8+hwukWQFd+guKb8CSObCsP9kcTR/DMYd8 3j8gB98JeepKhey5aa42cUvGmQr5ABw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627027444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s4heI5Mvwb/CUy10lhvbvGcY49F5tI0wLXhQRaefPKA=; b=aAJ1wf6PWGrjeRaN3/MlW/AnQ2PJcJNWrOk+BZ0ssL8MRHR+Fn9R1DL1z+rcsF7JcALJab mIWy5UOJYRwHoXBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5609113DEC; Fri, 23 Jul 2021 08:04:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id F50iE/R3+mAFYQAAMHmgww (envelope-from ); Fri, 23 Jul 2021 08:04:04 +0000 Subject: Re: [PATCH v2 1/1] modules: Improve error message when module is not found To: Gerd Hoffmann , "Jose R. Ziviani" References: <20210722220952.17444-1-jziviani@suse.de> <20210722220952.17444-2-jziviani@suse.de> <20210723062520.hp6qux5enrwyw56u@sirius.home.kraxel.org> From: Claudio Fontana Message-ID: Date: Fri, 23 Jul 2021 10:04:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210723062520.hp6qux5enrwyw56u@sirius.home.kraxel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.28; envelope-from=cfontana@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.203, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/23/21 8:25 AM, Gerd Hoffmann wrote: > Hi, > >> --- a/accel/accel-softmmu.c >> +++ b/accel/accel-softmmu.c >> @@ -79,7 +79,10 @@ void accel_init_ops_interfaces(AccelClass *ac) >> * all accelerators need to define ops, providing at least a mandatory >> * non-NULL create_vcpu_thread operation. >> */ >> - g_assert(ops != NULL); >> + if (ops == NULL) { > > Error message here?> Also split accel bits into a separate patch? If ops is NULL there is something seriously wrong with the code assumptions. Asserts are in my view the proper way to handle these. I do not think there is any reason to change this. > >> g_hash_table_remove(loaded_modules, module_name); >> + fprintf(stderr, "%s module is missing, install the " >> + "package or config the library path " >> + "correctly.\n", module_name); > > This should be error_report(), or maybe warn_report() as this > isn't a fatal error in all cases. Otherwise looks good to me. > > take care, > Gerd >