From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D455C64EC7 for ; Sat, 25 Feb 2023 23:05:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 475C8858E1; Sun, 26 Feb 2023 00:05:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GkYi3Ty2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 001DD85918; Sun, 26 Feb 2023 00:05:36 +0100 (CET) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 28E0A858A8 for ; Sun, 26 Feb 2023 00:05:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jbx6244@gmail.com Received: by mail-ed1-x52c.google.com with SMTP id da10so11546582edb.3 for ; Sat, 25 Feb 2023 15:05:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=mu3DMcKFFWr61LFpGcFMhdRs1wYV4x6GgXctKlcUMwE=; b=GkYi3Ty2tR08HDXHRU1AboOpucsALiufeIoMvLxCFWy6toYYNzr+db2D7ml1QoCksh 3w/5RVAUCIBNviWiEt3AYUih9CVMq2bwRnOL6ZLdJ7j7LF2ph78aM6vleegFNSQhGwNC FbPXmFuxe5a9YPCqCYY/aPc//JH3hjmkP6fPa/VdUQkVg5g3up84qUUa0Ow1HOy3xdWn d0ENLewZ5YMGwg8BICI5XYuySpdQe1FjBSPVEDtXN9GdRXhweofhU8VklimTJWqa9Ayx t+o110ImWhi9K+KyGTodYVnrskGp2ksAOiB9xwn95SbfFJ6hCozL6cRvXaa45vTDaBAE LJhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mu3DMcKFFWr61LFpGcFMhdRs1wYV4x6GgXctKlcUMwE=; b=vQavLs5KJCZkGioVwB/vIr6vV4FFXmZ+ssVnsflNUFsvtrlHg1oOcq2Uyw7p3xu0UZ Vwfo/p96aRH8t3DcblelH37mNv9a+Wj/5xys2efaNV/ZzyBMu/x1sJFgMpoW/vFVMU4I EfmdHbyQNQwnm3SCDWEgP+lbLSQTwVautE+IOSYfpkdN+6lbKWlENL76CiIzwbM4h6vu Uwj5SQ5T0fZFt4UJr4m5L9jZBCo3rTlZv8eSX66JbrfshHcInUquxMyOIemr2wZ5/Kuw S86zeBA0pozKK4vjh/Lh77QziAVUeSlrnAuUsxK2A5ytu5Juy1/vWeqJKXD/gyfiKwwi xVVw== X-Gm-Message-State: AO0yUKXldEwjuu9Em9Ow+EOQkMtlNmJ015ZGmziYGPWJJMBvoeDBRggz CuD+aQawM9AdGlD9J5kIiovRylCSghg= X-Google-Smtp-Source: AK7set/vD+bUpDRzTFX7qgXhLsOIO2j7i7eke6Z09u4O+QbqzJU5hRnXceZj2CgJvu9ujTx6AmCcgg== X-Received: by 2002:a17:907:b16:b0:878:78f9:d1be with SMTP id h22-20020a1709070b1600b0087878f9d1bemr23846860ejl.23.1677366333538; Sat, 25 Feb 2023 15:05:33 -0800 (PST) Received: from [192.168.2.1] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id d21-20020a1709061f5500b008e6bd130b14sm1323067ejk.64.2023.02.25.15.05.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Feb 2023 15:05:32 -0800 (PST) Message-ID: Date: Sun, 26 Feb 2023 00:05:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RFC PATCH v1 2/4] drivers: use dev_read_addr_ptr when cast to pointer From: Johan Jonker To: dario.binacchi@amarulasolutions.com, michael@amarulasolutions.com, sjg@chromium.org, philipp.tomsich@vrull.eu, kever.yang@rock-chips.com Cc: u-boot@lists.denx.de, yifeng.zhao@rock-chips.com References: <49d0321c-72e4-429f-335e-8f23ff866d39@rock-chips.com> <0a708ae1-4b92-a572-1d74-343070c8a26b@gmail.com> <60dee2b7-13f4-f2ea-1783-58c06c278a99@gmail.com> Content-Language: en-US In-Reply-To: <60dee2b7-13f4-f2ea-1783-58c06c278a99@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2/25/23 20:19, Johan Jonker wrote: > The fdt_addr_t and phys_addr_t size have been decoupled. > A 32bit CPU can expect 64-bit data from the device tree parser, > so use dev_read_addr_ptr instead of the dev_read_addr > function in the various files in the drivers directory that cast > to a pointer. > > Signed-off-by: Johan Jonker > --- > > Note: > > This is needed for a Rockchip patch serie to pass the test and > must be merged before by Rockchip maintainers: > > [PATCH v4 00/11] Fixes for Rockchip NFC driver part 1 > https://lore.kernel.org/u-boot/f3dba231-4a55-0a94-dfab-5cab1419d132@gmail.com/ > > Replacement command used: > find . -type f -exec sed -i 's/*)dev_read_addr(/ > *)dev_read_addr_ptr(/g' {} + > --- > drivers/ata/dwc_ahsata.c | 2 +- > drivers/cache/cache-l2x0.c | 2 +- > drivers/cache/cache-v5l2.c | 2 +- > drivers/gpio/mscc_sgpio.c | 2 +- > drivers/gpio/tegra_gpio.c | 4 ++-- > drivers/gpio/xilinx_gpio.c | 2 +- > drivers/i2c/i2c-cdns.c | 2 +- > drivers/i2c/tegra_i2c.c | 4 ++-- > drivers/mmc/am654_sdhci.c | 2 +- > drivers/mmc/davinci_mmc.c | 2 +- > drivers/mmc/piton_mmc.c | 2 +- > drivers/mmc/tegra_mmc.c | 2 +- > drivers/mmc/zynq_sdhci.c | 6 +++--- > drivers/mtd/nand/raw/arasan_nfc.c | 2 +- > drivers/mtd/nand/raw/cortina_nand.c | 2 +- > drivers/mtd/nand/raw/mxic_nand.c | 2 +- > drivers/mtd/nand/raw/tegra_nand.c | 2 +- > drivers/mtd/nand/raw/zynq_nand.c | 2 +- > drivers/net/mvmdio.c | 2 +- > drivers/net/qe/dm_qe_uec_phy.c | 2 +- > drivers/pci/pci-aardvark.c | 4 ++-- > drivers/phy/allwinner/phy-sun50i-usb3.c | 6 +++--- > drivers/phy/qcom/phy-qcom-usb-hs-28nm.c | 4 ++-- > drivers/phy/qcom/phy-qcom-usb-ss.c | 4 ++-- > drivers/phy/rockchip/phy-rockchip-snps-pcie3.c | 4 ++-- > drivers/phy/rockchip/phy-rockchip-typec.c | 6 +++--- > drivers/pwm/tegra_pwm.c | 2 +- > drivers/serial/serial_zynq.c | 6 +++--- > drivers/spi/mpc8xxx_spi.c | 2 +- > drivers/spi/mscc_bb_spi.c | 2 +- > drivers/spi/sh_qspi.c | 2 +- > drivers/spi/spi-mxic.c | 2 +- > drivers/spi/xilinx_spi.c | 2 +- > drivers/ufs/ufs.c | 2 +- > drivers/usb/host/ehci-tegra.c | 2 +- > drivers/video/dw_mipi_dsi.c | 4 ++-- > drivers/video/rockchip/rk_vop.c | 2 +- > drivers/video/stm32/stm32_dsi.c | 4 ++-- > drivers/video/stm32/stm32_ltdc.c | 4 ++-- > drivers/video/tegra124/display.c | 2 +- > drivers/video/tegra124/sor.c | 6 +++--- > drivers/watchdog/cdns_wdt.c | 6 +++--- > drivers/watchdog/sp805_wdt.c | 6 +++--- > drivers/watchdog/xilinx_tb_wdt.c | 6 +++--- > 44 files changed, 69 insertions(+), 69 deletions(-) > [..] > diff --git a/drivers/video/dw_mipi_dsi.c b/drivers/video/dw_mipi_dsi.c > index 6d9c5a94..7c6892cf 100644 > --- a/drivers/video/dw_mipi_dsi.c > +++ b/drivers/video/dw_mipi_dsi.c > @@ -800,8 +800,8 @@ static int dw_mipi_dsi_init(struct udevice *dev, > dsi->dsi_host.ops = &dw_mipi_dsi_host_ops; > device->host = &dsi->dsi_host; > > - dsi->base = (void *)dev_read_addr(device->dev); > - if ((fdt_addr_t)dsi->base == FDT_ADDR_T_NONE) { > + dsi->base = dev_read_addr_ptr(device->dev); > + if ((!dsi->base) { if (!dsi->base) { Oops typo, sorry.. > dev_err(device->dev, "dsi dt register address error\n"); > return -EINVAL; > } [..] 0); > -- > 2.20.1 >