From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] net: preserve sock reference when scrubbing the skb. Date: Tue, 26 Jun 2018 16:53:55 -0700 Message-ID: References: <20180625155610.30802-1-fbl@redhat.com> <48e15faf-f935-0166-e1db-18f7286e7264@gmail.com> <20180626220300.GT19565@plex.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Linux Kernel Network Developers , Paolo Abeni , David Miller , Florian Westphal , NetFilter To: Cong Wang , Flavio Leitner Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:45956 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419AbeFZXx5 (ORCPT ); Tue, 26 Jun 2018 19:53:57 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/26/2018 03:47 PM, Cong Wang wrote: > > You need to justify why you want to break the TSQ's scope here, > which is obviously not compatible with netns design. You have to explain why you do not want us to fix this buggy behavior. Right now TSQ (and more generally back pressure) is broken by this skb_orphan() So we want to restore TSQ (and back pressure) TSQ scope never mentioned netns. We (TCP stack TSQ handler) want to be notified when this packet leaves the host, even if it had to traverse multiple netns (for whatever reasons). _If_ a packet is locally 'consumed' (like on loopback device, or veth pair), then the skb_orphan() will automatically be done. If you have a case where this skb_orphan() is needed, please add it at the needed place.