All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Pearson <rpearsonhpe@gmail.com>
To: Yi Zhang <yi.zhang@redhat.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Jason Gunthorpe <jgg@nvidia.com>,
	Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	Douglas Gilbert <dgilbert@interlog.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH] Revert "scsi: scsi_debug: Address races following module load"
Date: Sun, 10 Apr 2022 12:00:47 -0500	[thread overview]
Message-ID: <aaec898e-08f1-03da-a0c0-34729df4f68b@gmail.com> (raw)
In-Reply-To: <CAHj4cs8CRK==3+ssCSLWrC-1-jtp+=QAoaopN97GgFs5bWcbow@mail.gmail.com>

On 4/10/22 08:15, Yi Zhang wrote:
> Confirmed the blktests srp/ issue was fixed with this revert:
> 
> Tested-by: Yi Zhang <yi.zhang@redhat.com>
> 
> On Sat, Apr 9, 2022 at 12:37 PM Bart Van Assche <bvanassche@acm.org> wrote:
>>
>> Revert the patch mentioned in the subject since it blocks I/O after
>> module unload has started while this is a legitimate use case. For e.g.
>> blktests test case srp/001 that patch causes a command timeout to be
>> triggered for the following call stack:
>>

I also applied Bart's patch reverting the scsi_debug change. And find
that now blktest/check -q srp runs successfully and the trace does not
show the inconsistent lock state warning. So it looks to me that there
is not a current need to revert the remaining _bh locks in the rxe driver
to _irqsave locks.

But, as far as I know the root cause of those warnings, when valid, are due to
code that calls into the verbs APIs while holding _irqsave locks. If we want to
make that generally possible then perhaps we should just get rid of the _bh
locks in favor of _irqsave locks. I have a patch that does that if you think
it is needed.

Bob

  reply	other threads:[~2022-04-10 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-09  4:37 [PATCH] Revert "scsi: scsi_debug: Address races following module load" Bart Van Assche
2022-04-09 19:10 ` Douglas Gilbert
2022-04-12 17:52   ` Luis Chamberlain
2022-04-12 18:22     ` Bart Van Assche
2022-04-10 13:15 ` Yi Zhang
2022-04-10 17:00   ` Bob Pearson [this message]
2022-04-10 17:26     ` Bob Pearson
2022-04-12  2:36 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaec898e-08f1-03da-a0c0-34729df4f68b@gmail.com \
    --to=rpearsonhpe@gmail.com \
    --cc=bvanassche@acm.org \
    --cc=dgilbert@interlog.com \
    --cc=jejb@linux.ibm.com \
    --cc=jgg@nvidia.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=yi.zhang@redhat.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.