From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1942BCA90AF for ; Tue, 12 May 2020 15:52:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D707E206DD for ; Tue, 12 May 2020 15:52:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LfRd2R6s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D707E206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYXCK-0001Cy-3A for qemu-devel@archiver.kernel.org; Tue, 12 May 2020 11:52:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYXBc-0000kB-AL for qemu-devel@nongnu.org; Tue, 12 May 2020 11:51:16 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:37409 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jYXBb-0000f2-HF for qemu-devel@nongnu.org; Tue, 12 May 2020 11:51:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589298674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VHxyCy7qT6ko5GAjLjFTBZR4XbflvGbOs7Vbb2gUQ4I=; b=LfRd2R6sKzYfo0C+gbk3vFjhcHU2HWG5ExiehIK4Y1xKeUUlUxAQUchWaavZD2f4KBIL25 1xPNJPT0K8xt73NNCUx9tVht3OzYeelTMaGTKocheOCu+9Vf4nZPyrDt8gxIGkVWM+CUSq kq4gpv1ax41IKPHZe4mrD0ZLxlZbkHc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-xrYiWwVQPk2mZ5T6l5oTnQ-1; Tue, 12 May 2020 11:51:13 -0400 X-MC-Unique: xrYiWwVQPk2mZ5T6l5oTnQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1A553872FE0 for ; Tue, 12 May 2020 15:51:12 +0000 (UTC) Received: from [10.3.116.145] (ovpn-116-145.phx2.redhat.com [10.3.116.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB7B05D9DD; Tue, 12 May 2020 15:51:11 +0000 (UTC) Subject: Re: [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead To: Thomas Huth , qemu-devel@nongnu.org, Jason Wang References: <20200512123149.30207-1-thuth@redhat.com> <20200512123149.30207-3-thuth@redhat.com> <3a2bcb19-5ba3-0023-8733-d945ee40aeeb@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Tue, 12 May 2020 10:51:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/12 01:41:59 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/12/20 10:13 AM, Thomas Huth wrote: >>> +++ b/qapi/net.json >>> @@ -453,7 +453,7 @@ >>>   #        'l2tpv3' - since 2.1 >>>   ## >>>   { 'union': 'Netdev', >>> -  'base': { 'id': 'str', 'type': 'NetClientDriver' }, >>> +  'base': { '*id': 'str', 'type': 'NetClientDriver' }, >> >> I don't think we need to make 'id' optional. > > It's required for "-net" now. But does -net generate it's own id if one is not provided? Can it still be mandatory in the QAPI type, and just figure out how to guarantee that the CLI parsing of -net provides a name early enough in the cycle to use the QAPI type without making the member optional there? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org