From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v2 2/2] drm/amdgpu: Move old fence waiting before reservation lock is aquired. Date: Wed, 11 Oct 2017 09:25:23 +0200 Message-ID: References: <715810ad-26cc-506d-624d-8e5024968ea0@gmail.com> <1507668617-27299-1-git-send-email-andrey.grodzovsky@amd.com> <1507668617-27299-2-git-send-email-andrey.grodzovsky@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Liu, Monk" , "Grodzovsky, Andrey" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" WWVzLCB0aGUgbXV0ZXggaXMgbWFuZGF0b3J5LgoKQXMgSSBleHBsYWluZWQgYmVmb3JlIGl0IGRv ZXNuJ3QgbWF0dGVyIHdoYXQgdXNlcnNwYWNlIGlzIGRvaW5nLCB0aGUgCmtlcm5lbCBJT0NUTCBt dXN0IGFsd2F5cyBiZSB0aHJlYWQgc2FmZS4KCk90aGVyd2lzZSB1c2Vyc3BhY2UgY291bGQgZm9y Y2UgdGhlIGtlcm5lbCB0byBydW4gaW50byBhIEJVR19PTigpIG9yIHdvcnNlLgoKQWRkaXRpb25h bCB0byB0aGF0IHdlIGFscmVhZHkgdXNlIGFuIENTIGludGVyZmFjZSB1cHN0cmVhbSB3aGljaCBk b2Vzbid0IApoYXZlIGEgcHRocmVhZF9tdXRleCBhbnkgbW9yZS4KClJlZ2FyZHMsCkNocmlzdGlh bi4KCkFtIDExLjEwLjIwMTcgdW0gMDU6Mjggc2NocmllYiBMaXUsIE1vbms6Cj4gSGkgQW5kcmV5 ICYgQ2hyaXN0aWFuCj4KPiBEbyB3ZSByZWFsbHkgbmVlZCB0aGUgbXV0ZXh0IGxvY2sgaGVyZT8K PiBMaWJkcm1fYW1kZ3B1IGFscmVhZHkgaGFzIHRoZSBwdGhyZWFkX211dGV4dCB0byBwcm90ZWN0 IG11bHRpLXRocmVhZCByYWNpbmcgaXNzdWVzLCBrZXJuZWwgc2lkZSBzaG91bGQgYmUgc2FmZSB3 aXRoIHRoYXQKPgo+IEJSIE1vbmsKPgo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gRnJv bTogQW5kcmV5IEdyb2R6b3Zza3kgW21haWx0bzphbmRyZXkuZ3JvZHpvdnNreUBhbWQuY29tXQo+ IFNlbnQ6IFdlZG5lc2RheSwgT2N0b2JlciAxMSwgMjAxNyA0OjUwIEFNCj4gVG86IEtvZW5pZywg Q2hyaXN0aWFuIDxDaHJpc3RpYW4uS29lbmlnQGFtZC5jb20+OyBMaXUsIE1vbmsgPE1vbmsuTGl1 QGFtZC5jb20+OyBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBHcm9kem92c2t5 LCBBbmRyZXkgPEFuZHJleS5Hcm9kem92c2t5QGFtZC5jb20+Cj4gU3ViamVjdDogW1BBVENIIHYy IDIvMl0gZHJtL2FtZGdwdTogTW92ZSBvbGQgZmVuY2Ugd2FpdGluZyBiZWZvcmUgcmVzZXJ2YXRp b24gbG9jayBpcyBhcXVpcmVkLgo+Cj4gSGVscHMgYXZvaWRpbmcgZGVhZGxvY2sgZHVyaW5nIEdQ VSByZXNldC4KPiBBZGRlZCBtdXRleCB0byBhbWRncHVfY3R4IHRvIHByZXNlcnZlIG9yZGVyIG9m IGZlbmNlcyBvbiBhIHJpbmcuCj4KPiB2MjoKPiBQdXQgd2FpdGluZyBsb2dpYyBpbiBhIGZ1bmN0 aW9uIGluIGEgc2VwZXJhdGUgZnVuY3Rpb24gaW4gYW1kZ3B1X2N0eC5jCj4KPiBTaWduZWQtb2Zm LWJ5OiBBbmRyZXkgR3JvZHpvdnNreSA8YW5kcmV5Lmdyb2R6b3Zza3lAYW1kLmNvbT4KPiAtLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oICAgICB8ICA0ICsrKysKPiAg IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jICB8ICA4ICsrKysrKy0tICBk cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3R4LmMgfCAzMCArKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0KPiAgIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwg OCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHUuaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4gaW5kZXgg ZGE0OGY5Ny4uMjM1ZWNhNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHUuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4g QEAgLTc0MSw2ICs3NDEsNyBAQCBzdHJ1Y3QgYW1kZ3B1X2N0eCB7Cj4gICAJYm9vbCAJCQlwcmVh bWJsZV9wcmVzZW50ZWQ7Cj4gICAJZW51bSBhbWRfc2NoZWRfcHJpb3JpdHkgaW5pdF9wcmlvcml0 eTsKPiAgIAllbnVtIGFtZF9zY2hlZF9wcmlvcml0eSBvdmVycmlkZV9wcmlvcml0eTsKPiArCXN0 cnVjdCBtdXRleCAgICAgICAgICAgIGxvY2s7Cj4gICB9Owo+ICAgCj4gICBzdHJ1Y3QgYW1kZ3B1 X2N0eF9tZ3Igewo+IEBAIC03NjMsOSArNzY0LDEyIEBAIHZvaWQgYW1kZ3B1X2N0eF9wcmlvcml0 eV9vdmVycmlkZShzdHJ1Y3QgYW1kZ3B1X2N0eCAqY3R4LCAgaW50IGFtZGdwdV9jdHhfaW9jdGwo c3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgIAkJICAgICBzdHJ1Y3QgZHJt X2ZpbGUgKmZpbHApOwo+ICAgCj4gK2ludCBhbWRncHVfY3R4X3dhaXRfcHJldl9mZW5jZShzdHJ1 Y3QgYW1kZ3B1X2N0eCAqY3R4LCB1bnNpZ25lZAo+ICtyaW5nX2lkKTsKPiArCj4gICB2b2lkIGFt ZGdwdV9jdHhfbWdyX2luaXQoc3RydWN0IGFtZGdwdV9jdHhfbWdyICptZ3IpOyAgdm9pZCBhbWRn cHVfY3R4X21ncl9maW5pKHN0cnVjdCBhbWRncHVfY3R4X21nciAqbWdyKTsKPiAgIAo+ICsKPiAg IC8qCj4gICAgKiBmaWxlIHByaXZhdGUgc3RydWN0dXJlCj4gICAgKi8KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfY3MuYwo+IGluZGV4IDFhNTRlNTMuLmMzNjI5N2MgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3MuYwo+IEBAIC05MCw2ICs5MCw4IEBAIHN0 YXRpYyBpbnQgYW1kZ3B1X2NzX3BhcnNlcl9pbml0KHN0cnVjdCBhbWRncHVfY3NfcGFyc2VyICpw LCB2b2lkICpkYXRhKQo+ICAgCQlnb3RvIGZyZWVfY2h1bms7Cj4gICAJfQo+ICAgCj4gKwltdXRl eF9sb2NrKCZwLT5jdHgtPmxvY2spOwo+ICsKPiAgIAkvKiBnZXQgY2h1bmtzICovCj4gICAJY2h1 bmtfYXJyYXlfdXNlciA9IHU2NF90b191c2VyX3B0cihjcy0+aW4uY2h1bmtzKTsKPiAgIAlpZiAo Y29weV9mcm9tX3VzZXIoY2h1bmtfYXJyYXksIGNodW5rX2FycmF5X3VzZXIsIEBAIC03MzcsOCAr NzM5LDEwIEBAIHN0YXRpYyB2b2lkIGFtZGdwdV9jc19wYXJzZXJfZmluaShzdHJ1Y3QgYW1kZ3B1 X2NzX3BhcnNlciAqcGFyc2VyLCBpbnQgZXJyb3IsCj4gICAKPiAgIAlkbWFfZmVuY2VfcHV0KHBh cnNlci0+ZmVuY2UpOwo+ICAgCj4gLQlpZiAocGFyc2VyLT5jdHgpCj4gKwlpZiAocGFyc2VyLT5j dHgpIHsKPiArCQltdXRleF91bmxvY2soJnBhcnNlci0+Y3R4LT5sb2NrKTsKPiAgIAkJYW1kZ3B1 X2N0eF9wdXQocGFyc2VyLT5jdHgpOwo+ICsJfQo+ICAgCj4gICAJaWYgKHBhcnNlci0+Ym9fbGlz dCkKPiAgIAkJYW1kZ3B1X2JvX2xpc3RfcHV0KHBhcnNlci0+Ym9fbGlzdCk7Cj4gQEAgLTk5Miw3 ICs5OTYsNyBAQCBzdGF0aWMgaW50IGFtZGdwdV9jc19pYl9maWxsKHN0cnVjdCBhbWRncHVfZGV2 aWNlICphZGV2LAo+ICAgCSAgICBwYXJzZXItPmpvYi0+cmluZy0+ZnVuY3MtPnR5cGUgPT0gQU1E R1BVX1JJTkdfVFlQRV9WQ0UpKQo+ICAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgIAo+IC0JcmV0dXJu IDA7Cj4gKwlyZXR1cm4gYW1kZ3B1X2N0eF93YWl0X3ByZXZfZmVuY2UocGFyc2VyLT5jdHgsCj4g K3BhcnNlci0+am9iLT5yaW5nLT5pZHgpOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgaW50IGFtZGdw dV9jc19wcm9jZXNzX2ZlbmNlX2RlcChzdHJ1Y3QgYW1kZ3B1X2NzX3BhcnNlciAqcCwgZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jdHguYyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jdHguYwo+IGluZGV4IGE3OGIwM2Y2Li40MzA5ODIw IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jdHguYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jdHguYwo+IEBAIC02Nyw2 ICs2Nyw4IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2N0eF9pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNl ICphZGV2LAo+ICAgCWlmICghY3R4LT5mZW5jZXMpCj4gICAJCXJldHVybiAtRU5PTUVNOwo+ICAg Cj4gKwltdXRleF9pbml0KCZjdHgtPmxvY2spOwo+ICsKPiAgIAlmb3IgKGkgPSAwOyBpIDwgQU1E R1BVX01BWF9SSU5HUzsgKytpKSB7Cj4gICAJCWN0eC0+cmluZ3NbaV0uc2VxdWVuY2UgPSAxOwo+ ICAgCQljdHgtPnJpbmdzW2ldLmZlbmNlcyA9ICZjdHgtPmZlbmNlc1thbWRncHVfc2NoZWRfam9i cyAqIGldOyBAQCAtMTI2LDYgKzEyOCw4IEBAIHN0YXRpYyB2b2lkIGFtZGdwdV9jdHhfZmluaShz dHJ1Y3QgYW1kZ3B1X2N0eCAqY3R4KQo+ICAgCQkJCSAgICAgICZjdHgtPnJpbmdzW2ldLmVudGl0 eSk7Cj4gICAKPiAgIAlhbWRncHVfcXVldWVfbWdyX2ZpbmkoYWRldiwgJmN0eC0+cXVldWVfbWdy KTsKPiArCj4gKwltdXRleF9kZXN0cm95KCZjdHgtPmxvY2spOwo+ICAgfQo+ICAgCj4gICBzdGF0 aWMgaW50IGFtZGdwdV9jdHhfYWxsb2Moc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIEBAIC0y OTYsMTIgKzMwMCw4IEBAIGludCBhbWRncHVfY3R4X2FkZF9mZW5jZShzdHJ1Y3QgYW1kZ3B1X2N0 eCAqY3R4LCBzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJpbmcsCj4gICAKPiAgIAlpZHggPSBzZXEgJiAo YW1kZ3B1X3NjaGVkX2pvYnMgLSAxKTsKPiAgIAlvdGhlciA9IGNyaW5nLT5mZW5jZXNbaWR4XTsK PiAtCWlmIChvdGhlcikgewo+IC0JCXNpZ25lZCBsb25nIHI7Cj4gLQkJciA9IGRtYV9mZW5jZV93 YWl0X3RpbWVvdXQob3RoZXIsIHRydWUsIE1BWF9TQ0hFRFVMRV9USU1FT1VUKTsKPiAtCQlpZiAo ciA8IDApCj4gLQkJCXJldHVybiByOwo+IC0JfQo+ICsJaWYgKG90aGVyKQo+ICsJCUJVR19PTigh ZG1hX2ZlbmNlX2lzX3NpZ25hbGVkKG90aGVyKSk7Cj4gICAKPiAgIAlkbWFfZmVuY2VfZ2V0KGZl bmNlKTsKPiAgIAo+IEBAIC0zNzIsNiArMzcyLDI0IEBAIHZvaWQgYW1kZ3B1X2N0eF9wcmlvcml0 eV9vdmVycmlkZShzdHJ1Y3QgYW1kZ3B1X2N0eCAqY3R4LAo+ICAgCX0KPiAgIH0KPiAgIAo+ICtp bnQgYW1kZ3B1X2N0eF93YWl0X3ByZXZfZmVuY2Uoc3RydWN0IGFtZGdwdV9jdHggKmN0eCwgdW5z aWduZWQKPiArcmluZ19pZCkgewo+ICsJc3RydWN0IGFtZGdwdV9jdHhfcmluZyAqY3JpbmcgPSAm Y3R4LT5yaW5nc1tyaW5nX2lkXTsKPiArCXVuc2lnbmVkIGlkeCA9IGNyaW5nLT5zZXF1ZW5jZSAm IChhbWRncHVfc2NoZWRfam9icyAtIDEpOwo+ICsJc3RydWN0IGRtYV9mZW5jZSAqb3RoZXIgPSBj cmluZy0+ZmVuY2VzW2lkeF07Cj4gKwo+ICsJaWYgKG90aGVyKSB7Cj4gKwkJc2lnbmVkIGxvbmcg cjsKPiArCQlyID0gZG1hX2ZlbmNlX3dhaXRfdGltZW91dChvdGhlciwgZmFsc2UsIE1BWF9TQ0hF RFVMRV9USU1FT1VUKTsKPiArCQlpZiAociA8IDApIHsKPiArCQkJRFJNX0VSUk9SKCJFcnJvciAo JWxkKSB3YWl0aW5nIGZvciBmZW5jZSFcbiIsIHIpOwo+ICsJCQlyZXR1cm4gcjsKPiArCQl9Cj4g Kwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gICB2b2lkIGFtZGdwdV9jdHhfbWdyX2lu aXQoc3RydWN0IGFtZGdwdV9jdHhfbWdyICptZ3IpICB7Cj4gICAJbXV0ZXhfaW5pdCgmbWdyLT5s b2NrKTsKPiAtLQo+IDIuNy40Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1k LWdmeAo=