From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC483C4167B for ; Tue, 27 Dec 2022 21:07:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B94C10E0CD; Tue, 27 Dec 2022 21:07:17 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 139DD10E0CD for ; Tue, 27 Dec 2022 21:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1672175221; bh=OL5WJhJ3/ioUTccUP2H6ZJHZm++nEKN5MiFWcaZshkI=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=DP1X3adLdzt3xnBG3I0B9VUWlDhKza6IbdAs40Qoe/bPk3oB4A+eZOBtyvYpW0ppF VKlADVUoLV255aRFH2P6g7Os4xXiKumbLF5yWAhXH6h0IpeuxIs0hsiyIgapKEfIpk Mr/7enpe72LseWOrkj3IG7rGXXGLRNgmbtEqCPJkM9667QYESkhYbLC7f5ugS883do w5wlWUPT0LlOyCXAMnTBZpSRkOHCHDZ1DFEyfp5HZMeH2SRqU0V4HT06AA+sPwMImI dtu9zVhJ2Tdnj3Jz0dCy05W1a4kFLd8W59zYAEX7cFq0kIs1/d40QIyrRkpbRiKEEg Kn45IwDeNEXlA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([92.116.190.3]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MrQJ5-1oX6Re0szP-00oYBV; Tue, 27 Dec 2022 22:07:01 +0100 Message-ID: Date: Tue, 27 Dec 2022 22:06:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] fbdev: make offb driver tristate To: Nathan Chancellor References: <20221126000401.25302-1-rdunlap@infradead.org> <46e8cf0d-ab47-59b1-6c87-53d2d63a5bf6@suse.de> Content-Language: en-US From: Helge Deller In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:pmufG/yBB7w10j8I7juqQ1B39xUxP8hRiEiNAVefeU+Zrc6CndG P8D13De0yweY4iSpmMFzYgs6fOK5FY/JajFhHgVW2MhBJFSnDzKgrXKxbm67ZiGG77ZOXyu FLsoDQkkcIufDRIPC8QEKCG9C/E/xdgEsK+r6KUlD4LVKleVqgJN1rYSFrY3/kFHkS0k90G 3aibwRR9tFFMx1kg3m9XA== UI-OutboundReport: notjunk:1;M01:P0:4m/m/TKe8EY=;8px+0lBpXJqhmDlMMqcatGE6fyR kwdAiq3U2LOYRCxMiNVKvGCCqgYC7ouanOJGEqPMwm2bYQgcwkpZQa8H5cF9bZQj34BAIsZsA 1XaKbiPO6NpfRjtEEMZtMJxLLjyQml/if2W/d9BlP9bs9nHhn/x81lApHGsN8lRiie2Hw5s65 CkGmlTfGpZqQFfR3vl7BrvMn8H4VBnh9fqZQP/Qax0iIoCeVG57nvtJwaUGFKx1Te4GHsigtp qyYqRalAbUye9HFVHulSa43FI7QDfWFz2FHzyrboHoSvQ4m2xPUpU6QY+Ux9j2ZRBr78JqaDN cLZz6NQUsojzhZ7gPHpjMdyART5prM6RQozcOlq0WB/yyNqsD7UqbWQWFAsV3oVafcDG8X6gf xAYOzoEoYGRMmpt3htPz1nJYi+fKuvOOWmc2eG6edLfPAH3KtnnZQtpvfgWt7cVkLqbtWWoPC CB8xkIdRQglorW4K8x1cCNApA3rr6y26eFaZKXjO87lEhOg5QOnz5XTSn3XgZ2d9FmFaYsFMc 3NVsCgZ2gE0BFa1lem1NlLGvpU/bgrnCIZppeqOe+xhZ5+fw5t+KVVhVXmg1x1PDaY/o1cJJ5 p5YQfhICbF/Eh1NNjPo7XKtVU4NqOxXWhh+SyAiNabpDIxUEx3phW6Iw5RwSvqeOijsriYAT6 KBZLy4gdPEg9p0Yq9h6tzRUSB183VmBIaM4L1toY6RF1VO2tS5fCRb9GQUp25gmkTRG8CSVbx ejQSOttkcoVUXEb64ETtnJNUVv6KF5bHR96YTiNAqjSryZd5VJLZJ4Hfagb4S6XgT69FXReDu pmU6YXRpUtZQNzcqZ3A9mqEJPS8H35jtEqXcPR54RKvB+gPOlKqmyw4DEMc5O+Ew+og53U+LL MpDMGXwo0jV2Nu1DrSFMLj6Hw9g9KHRXCGYL6LdvIrIT1jl2QayH61cYho1wZiYKrCMhf+e4c gkwanbkBWZCZ56wz9awOPy+2nJk= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, llvm@lists.linux.dev, Arnd Bergmann , Masahiro Yamada , Randy Dunlap , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , =?UTF-8?Q?Michal_Such=c3=a1nek?= , linuxppc-dev@lists.ozlabs.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 12/27/22 19:48, Nathan Chancellor wrote: > On Sat, Dec 10, 2022 at 05:35:06PM +0100, Helge Deller wrote: >> On 11/26/22 14:40, Thomas Zimmermann wrote: >>> Am 26.11.22 um 01:04 schrieb Randy Dunlap: >>>> Make the offb (Open Firmware frame buffer) driver tristate, >>>> i.e., so that it can be built as a loadable module. >>>> >>>> However, it still depends on the setting of DRM_OFDRM >>>> so that both of these drivers cannot be builtin at the same time >>>> nor can one be builtin and the other one a loadable module. >>>> >>>> Build-tested successfully with all combination of DRM_OFDRM and FB_OF= . >>>> >>>> This fixes a build issue that Michal reported when FB_OF=3Dy and >>>> DRM_OFDRM=3Dm: >>>> >>>> powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): u= ndefined reference to `cfb_fillrect' >>>> powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): u= ndefined reference to `cfb_copyarea' >>>> powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): u= ndefined reference to `cfb_imageblit' >>>> >>>> Signed-off-by: Randy Dunlap >>>> Suggested-by: Arnd Bergmann >>>> Cc: Masahiro Yamada >>>> Cc: Thomas Zimmermann >>>> Cc: Michal Such=C3=A1nek >>>> Cc: linuxppc-dev@lists.ozlabs.org >>>> Cc: Daniel Vetter >>>> Cc: Helge Deller >>>> Cc: linux-fbdev@vger.kernel.org >>>> Cc: dri-devel@lists.freedesktop.org >>> >>> Acked-by: Thomas Zimmermann >> >> applied. > > Is this going to make it to Linus soon? We are now seeing this error in > our CI, which has the configuration describe in this commit. > > https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/= 3785609002/jobs/6437398666#step:5:149 > > https://storage.tuxsuite.com/public/clangbuiltlinux/continuous-integrati= on2/builds/2JUMSmjAoSJoKfl6PPjfU66JGit/build.log It didn't applied cleanly earlier. I've now added it to the fbdev for-next branch, and if no problems show up in the next few days I'll push it before next weekend. https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/log= /?h=3Dfor-next Helge > Cheers, > Nathan > >>>> --- >>>> =C2=A0 drivers/video/fbdev/Kconfig |=C2=A0=C2=A0=C2=A0 4 ++-- >>>> =C2=A0 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >>>> --- a/drivers/video/fbdev/Kconfig >>>> +++ b/drivers/video/fbdev/Kconfig >>>> @@ -456,8 +456,8 @@ config FB_ATARI >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 chipset found in Ataris. >>>> =C2=A0 config FB_OF >>>> -=C2=A0=C2=A0=C2=A0 bool "Open Firmware frame buffer device support" >>>> -=C2=A0=C2=A0=C2=A0 depends on (FB =3D y) && PPC && (!PPC_PSERIES || = PCI) >>>> +=C2=A0=C2=A0=C2=A0 tristate "Open Firmware frame buffer device suppo= rt" >>>> +=C2=A0=C2=A0=C2=A0 depends on FB && PPC && (!PPC_PSERIES || PCI) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on !DRM_OFDRM >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select APERTURE_HELPERS >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select FB_CFB_FILLRECT >>> >> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BBF86ADB for ; Tue, 27 Dec 2022 21:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1672175221; bh=OL5WJhJ3/ioUTccUP2H6ZJHZm++nEKN5MiFWcaZshkI=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=DP1X3adLdzt3xnBG3I0B9VUWlDhKza6IbdAs40Qoe/bPk3oB4A+eZOBtyvYpW0ppF VKlADVUoLV255aRFH2P6g7Os4xXiKumbLF5yWAhXH6h0IpeuxIs0hsiyIgapKEfIpk Mr/7enpe72LseWOrkj3IG7rGXXGLRNgmbtEqCPJkM9667QYESkhYbLC7f5ugS883do w5wlWUPT0LlOyCXAMnTBZpSRkOHCHDZ1DFEyfp5HZMeH2SRqU0V4HT06AA+sPwMImI dtu9zVhJ2Tdnj3Jz0dCy05W1a4kFLd8W59zYAEX7cFq0kIs1/d40QIyrRkpbRiKEEg Kn45IwDeNEXlA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([92.116.190.3]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MrQJ5-1oX6Re0szP-00oYBV; Tue, 27 Dec 2022 22:07:01 +0100 Message-ID: Date: Tue, 27 Dec 2022 22:06:59 +0100 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] fbdev: make offb driver tristate To: Nathan Chancellor Cc: Thomas Zimmermann , Randy Dunlap , linux-kernel@vger.kernel.org, Arnd Bergmann , Masahiro Yamada , =?UTF-8?Q?Michal_Such=c3=a1nek?= , linuxppc-dev@lists.ozlabs.org, Daniel Vetter , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, llvm@lists.linux.dev References: <20221126000401.25302-1-rdunlap@infradead.org> <46e8cf0d-ab47-59b1-6c87-53d2d63a5bf6@suse.de> Content-Language: en-US From: Helge Deller In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:pmufG/yBB7w10j8I7juqQ1B39xUxP8hRiEiNAVefeU+Zrc6CndG P8D13De0yweY4iSpmMFzYgs6fOK5FY/JajFhHgVW2MhBJFSnDzKgrXKxbm67ZiGG77ZOXyu FLsoDQkkcIufDRIPC8QEKCG9C/E/xdgEsK+r6KUlD4LVKleVqgJN1rYSFrY3/kFHkS0k90G 3aibwRR9tFFMx1kg3m9XA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:4m/m/TKe8EY=;8px+0lBpXJqhmDlMMqcatGE6fyR kwdAiq3U2LOYRCxMiNVKvGCCqgYC7ouanOJGEqPMwm2bYQgcwkpZQa8H5cF9bZQj34BAIsZsA 1XaKbiPO6NpfRjtEEMZtMJxLLjyQml/if2W/d9BlP9bs9nHhn/x81lApHGsN8lRiie2Hw5s65 CkGmlTfGpZqQFfR3vl7BrvMn8H4VBnh9fqZQP/Qax0iIoCeVG57nvtJwaUGFKx1Te4GHsigtp qyYqRalAbUye9HFVHulSa43FI7QDfWFz2FHzyrboHoSvQ4m2xPUpU6QY+Ux9j2ZRBr78JqaDN cLZz6NQUsojzhZ7gPHpjMdyART5prM6RQozcOlq0WB/yyNqsD7UqbWQWFAsV3oVafcDG8X6gf xAYOzoEoYGRMmpt3htPz1nJYi+fKuvOOWmc2eG6edLfPAH3KtnnZQtpvfgWt7cVkLqbtWWoPC CB8xkIdRQglorW4K8x1cCNApA3rr6y26eFaZKXjO87lEhOg5QOnz5XTSn3XgZ2d9FmFaYsFMc 3NVsCgZ2gE0BFa1lem1NlLGvpU/bgrnCIZppeqOe+xhZ5+fw5t+KVVhVXmg1x1PDaY/o1cJJ5 p5YQfhICbF/Eh1NNjPo7XKtVU4NqOxXWhh+SyAiNabpDIxUEx3phW6Iw5RwSvqeOijsriYAT6 KBZLy4gdPEg9p0Yq9h6tzRUSB183VmBIaM4L1toY6RF1VO2tS5fCRb9GQUp25gmkTRG8CSVbx ejQSOttkcoVUXEb64ETtnJNUVv6KF5bHR96YTiNAqjSryZd5VJLZJ4Hfagb4S6XgT69FXReDu pmU6YXRpUtZQNzcqZ3A9mqEJPS8H35jtEqXcPR54RKvB+gPOlKqmyw4DEMc5O+Ew+og53U+LL MpDMGXwo0jV2Nu1DrSFMLj6Hw9g9KHRXCGYL6LdvIrIT1jl2QayH61cYho1wZiYKrCMhf+e4c gkwanbkBWZCZ56wz9awOPy+2nJk= On 12/27/22 19:48, Nathan Chancellor wrote: > On Sat, Dec 10, 2022 at 05:35:06PM +0100, Helge Deller wrote: >> On 11/26/22 14:40, Thomas Zimmermann wrote: >>> Am 26.11.22 um 01:04 schrieb Randy Dunlap: >>>> Make the offb (Open Firmware frame buffer) driver tristate, >>>> i.e., so that it can be built as a loadable module. >>>> >>>> However, it still depends on the setting of DRM_OFDRM >>>> so that both of these drivers cannot be builtin at the same time >>>> nor can one be builtin and the other one a loadable module. >>>> >>>> Build-tested successfully with all combination of DRM_OFDRM and FB_OF= . >>>> >>>> This fixes a build issue that Michal reported when FB_OF=3Dy and >>>> DRM_OFDRM=3Dm: >>>> >>>> powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): u= ndefined reference to `cfb_fillrect' >>>> powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): u= ndefined reference to `cfb_copyarea' >>>> powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): u= ndefined reference to `cfb_imageblit' >>>> >>>> Signed-off-by: Randy Dunlap >>>> Suggested-by: Arnd Bergmann >>>> Cc: Masahiro Yamada >>>> Cc: Thomas Zimmermann >>>> Cc: Michal Such=C3=A1nek >>>> Cc: linuxppc-dev@lists.ozlabs.org >>>> Cc: Daniel Vetter >>>> Cc: Helge Deller >>>> Cc: linux-fbdev@vger.kernel.org >>>> Cc: dri-devel@lists.freedesktop.org >>> >>> Acked-by: Thomas Zimmermann >> >> applied. > > Is this going to make it to Linus soon? We are now seeing this error in > our CI, which has the configuration describe in this commit. > > https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/= 3785609002/jobs/6437398666#step:5:149 > > https://storage.tuxsuite.com/public/clangbuiltlinux/continuous-integrati= on2/builds/2JUMSmjAoSJoKfl6PPjfU66JGit/build.log It didn't applied cleanly earlier. I've now added it to the fbdev for-next branch, and if no problems show up in the next few days I'll push it before next weekend. https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/log= /?h=3Dfor-next Helge > Cheers, > Nathan > >>>> --- >>>> =C2=A0 drivers/video/fbdev/Kconfig |=C2=A0=C2=A0=C2=A0 4 ++-- >>>> =C2=A0 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >>>> --- a/drivers/video/fbdev/Kconfig >>>> +++ b/drivers/video/fbdev/Kconfig >>>> @@ -456,8 +456,8 @@ config FB_ATARI >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 chipset found in Ataris. >>>> =C2=A0 config FB_OF >>>> -=C2=A0=C2=A0=C2=A0 bool "Open Firmware frame buffer device support" >>>> -=C2=A0=C2=A0=C2=A0 depends on (FB =3D y) && PPC && (!PPC_PSERIES || = PCI) >>>> +=C2=A0=C2=A0=C2=A0 tristate "Open Firmware frame buffer device suppo= rt" >>>> +=C2=A0=C2=A0=C2=A0 depends on FB && PPC && (!PPC_PSERIES || PCI) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on !DRM_OFDRM >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select APERTURE_HELPERS >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select FB_CFB_FILLRECT >>> >> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97098C10F1B for ; Tue, 27 Dec 2022 21:08:49 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NhS1r0sNRz3c6R for ; Wed, 28 Dec 2022 08:08:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=gmx.de header.i=@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=DP1X3adL; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmx.de (client-ip=212.227.17.20; helo=mout.gmx.net; envelope-from=deller@gmx.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=DP1X3adL; dkim-atps=neutral Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NhS0k20Jqz2ywn for ; Wed, 28 Dec 2022 08:07:47 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1672175221; bh=OL5WJhJ3/ioUTccUP2H6ZJHZm++nEKN5MiFWcaZshkI=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=DP1X3adLdzt3xnBG3I0B9VUWlDhKza6IbdAs40Qoe/bPk3oB4A+eZOBtyvYpW0ppF VKlADVUoLV255aRFH2P6g7Os4xXiKumbLF5yWAhXH6h0IpeuxIs0hsiyIgapKEfIpk Mr/7enpe72LseWOrkj3IG7rGXXGLRNgmbtEqCPJkM9667QYESkhYbLC7f5ugS883do w5wlWUPT0LlOyCXAMnTBZpSRkOHCHDZ1DFEyfp5HZMeH2SRqU0V4HT06AA+sPwMImI dtu9zVhJ2Tdnj3Jz0dCy05W1a4kFLd8W59zYAEX7cFq0kIs1/d40QIyrRkpbRiKEEg Kn45IwDeNEXlA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([92.116.190.3]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MrQJ5-1oX6Re0szP-00oYBV; Tue, 27 Dec 2022 22:07:01 +0100 Message-ID: Date: Tue, 27 Dec 2022 22:06:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] fbdev: make offb driver tristate To: Nathan Chancellor References: <20221126000401.25302-1-rdunlap@infradead.org> <46e8cf0d-ab47-59b1-6c87-53d2d63a5bf6@suse.de> Content-Language: en-US From: Helge Deller In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:pmufG/yBB7w10j8I7juqQ1B39xUxP8hRiEiNAVefeU+Zrc6CndG P8D13De0yweY4iSpmMFzYgs6fOK5FY/JajFhHgVW2MhBJFSnDzKgrXKxbm67ZiGG77ZOXyu FLsoDQkkcIufDRIPC8QEKCG9C/E/xdgEsK+r6KUlD4LVKleVqgJN1rYSFrY3/kFHkS0k90G 3aibwRR9tFFMx1kg3m9XA== UI-OutboundReport: notjunk:1;M01:P0:4m/m/TKe8EY=;8px+0lBpXJqhmDlMMqcatGE6fyR kwdAiq3U2LOYRCxMiNVKvGCCqgYC7ouanOJGEqPMwm2bYQgcwkpZQa8H5cF9bZQj34BAIsZsA 1XaKbiPO6NpfRjtEEMZtMJxLLjyQml/if2W/d9BlP9bs9nHhn/x81lApHGsN8lRiie2Hw5s65 CkGmlTfGpZqQFfR3vl7BrvMn8H4VBnh9fqZQP/Qax0iIoCeVG57nvtJwaUGFKx1Te4GHsigtp qyYqRalAbUye9HFVHulSa43FI7QDfWFz2FHzyrboHoSvQ4m2xPUpU6QY+Ux9j2ZRBr78JqaDN cLZz6NQUsojzhZ7gPHpjMdyART5prM6RQozcOlq0WB/yyNqsD7UqbWQWFAsV3oVafcDG8X6gf xAYOzoEoYGRMmpt3htPz1nJYi+fKuvOOWmc2eG6edLfPAH3KtnnZQtpvfgWt7cVkLqbtWWoPC CB8xkIdRQglorW4K8x1cCNApA3rr6y26eFaZKXjO87lEhOg5QOnz5XTSn3XgZ2d9FmFaYsFMc 3NVsCgZ2gE0BFa1lem1NlLGvpU/bgrnCIZppeqOe+xhZ5+fw5t+KVVhVXmg1x1PDaY/o1cJJ5 p5YQfhICbF/Eh1NNjPo7XKtVU4NqOxXWhh+SyAiNabpDIxUEx3phW6Iw5RwSvqeOijsriYAT6 KBZLy4gdPEg9p0Yq9h6tzRUSB183VmBIaM4L1toY6RF1VO2tS5fCRb9GQUp25gmkTRG8CSVbx ejQSOttkcoVUXEb64ETtnJNUVv6KF5bHR96YTiNAqjSryZd5VJLZJ4Hfagb4S6XgT69FXReDu pmU6YXRpUtZQNzcqZ3A9mqEJPS8H35jtEqXcPR54RKvB+gPOlKqmyw4DEMc5O+Ew+og53U+LL MpDMGXwo0jV2Nu1DrSFMLj6Hw9g9KHRXCGYL6LdvIrIT1jl2QayH61cYho1wZiYKrCMhf+e4c gkwanbkBWZCZ56wz9awOPy+2nJk= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, llvm@lists.linux.dev, Daniel Vetter , Arnd Bergmann , Masahiro Yamada , Randy Dunlap , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , =?UTF-8?Q?Michal_Such=c3=a1nek?= , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 12/27/22 19:48, Nathan Chancellor wrote: > On Sat, Dec 10, 2022 at 05:35:06PM +0100, Helge Deller wrote: >> On 11/26/22 14:40, Thomas Zimmermann wrote: >>> Am 26.11.22 um 01:04 schrieb Randy Dunlap: >>>> Make the offb (Open Firmware frame buffer) driver tristate, >>>> i.e., so that it can be built as a loadable module. >>>> >>>> However, it still depends on the setting of DRM_OFDRM >>>> so that both of these drivers cannot be builtin at the same time >>>> nor can one be builtin and the other one a loadable module. >>>> >>>> Build-tested successfully with all combination of DRM_OFDRM and FB_OF= . >>>> >>>> This fixes a build issue that Michal reported when FB_OF=3Dy and >>>> DRM_OFDRM=3Dm: >>>> >>>> powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): u= ndefined reference to `cfb_fillrect' >>>> powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): u= ndefined reference to `cfb_copyarea' >>>> powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): u= ndefined reference to `cfb_imageblit' >>>> >>>> Signed-off-by: Randy Dunlap >>>> Suggested-by: Arnd Bergmann >>>> Cc: Masahiro Yamada >>>> Cc: Thomas Zimmermann >>>> Cc: Michal Such=C3=A1nek >>>> Cc: linuxppc-dev@lists.ozlabs.org >>>> Cc: Daniel Vetter >>>> Cc: Helge Deller >>>> Cc: linux-fbdev@vger.kernel.org >>>> Cc: dri-devel@lists.freedesktop.org >>> >>> Acked-by: Thomas Zimmermann >> >> applied. > > Is this going to make it to Linus soon? We are now seeing this error in > our CI, which has the configuration describe in this commit. > > https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/= 3785609002/jobs/6437398666#step:5:149 > > https://storage.tuxsuite.com/public/clangbuiltlinux/continuous-integrati= on2/builds/2JUMSmjAoSJoKfl6PPjfU66JGit/build.log It didn't applied cleanly earlier. I've now added it to the fbdev for-next branch, and if no problems show up in the next few days I'll push it before next weekend. https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/log= /?h=3Dfor-next Helge > Cheers, > Nathan > >>>> --- >>>> =C2=A0 drivers/video/fbdev/Kconfig |=C2=A0=C2=A0=C2=A0 4 ++-- >>>> =C2=A0 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >>>> --- a/drivers/video/fbdev/Kconfig >>>> +++ b/drivers/video/fbdev/Kconfig >>>> @@ -456,8 +456,8 @@ config FB_ATARI >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 chipset found in Ataris. >>>> =C2=A0 config FB_OF >>>> -=C2=A0=C2=A0=C2=A0 bool "Open Firmware frame buffer device support" >>>> -=C2=A0=C2=A0=C2=A0 depends on (FB =3D y) && PPC && (!PPC_PSERIES || = PCI) >>>> +=C2=A0=C2=A0=C2=A0 tristate "Open Firmware frame buffer device suppo= rt" >>>> +=C2=A0=C2=A0=C2=A0 depends on FB && PPC && (!PPC_PSERIES || PCI) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on !DRM_OFDRM >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select APERTURE_HELPERS >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select FB_CFB_FILLRECT >>> >> >>