From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD82C25B4E
	for <dpdk-dev@archiver.kernel.org>; Fri, 20 Jan 2023 11:22:17 +0000 (UTC)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 457C240150;
	Fri, 20 Jan 2023 12:22:16 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 5BF14400D5
 for <dev@dpdk.org>; Fri, 20 Jan 2023 12:22:14 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 84A6750;
 Fri, 20 Jan 2023 14:22:13 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 84A6750
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1674213733;
 bh=K2j7BzFFe05A6emwtrX479VUesklVK6n+FEca02F7Mk=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=fp9Ur+4N/o5hAa8Zk3Z5BenrxjAJv0JlB3uRF4BZFWk2N1x0dePKudK378Adm3V4m
 /IU5fll2oEt0JfbNhFc77733CQ8qfKJcKLO/ZlsrSYRAdxRH7bWcqongEapSEgCkFU
 hC0Hc48+Oo8bcLAVisdvunM+p57MaRwnFpD0tFMg=
Message-ID: <aafa1656-128b-5183-afaf-caa9f41f7835@oktetlabs.ru>
Date: Fri, 20 Jan 2023 14:22:13 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v6 1/2] ethdev: add query_update sync and async function
 calls
Content-Language: en-US
To: Gregory Etelson <getelson@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,
 Ori Kam <orika@nvidia.com>,
 "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@amd.com>
References: <20221221073547.988-1-getelson@nvidia.com>
 <20230119164713.7164-1-getelson@nvidia.com>
 <c4a57fce-f966-6720-843e-b3846dfdaa31@oktetlabs.ru>
 <IA1PR12MB6332D6BBDEE86CE2ECB474ECA5C59@IA1PR12MB6332.namprd12.prod.outlook.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <IA1PR12MB6332D6BBDEE86CE2ECB474ECA5C59@IA1PR12MB6332.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 1/20/23 13:46, Gregory Etelson wrote:
>>> and it's async version `rte_flow_async_action_handle_query_update`
>>> to atomically query and update flow action.
>>
>> Sorry, may be I'm missing something, but after reading previous
>> discussion I have a feeling that update could be queried data
>> dependent. However, I don't understand how it could be possible
>> with API below. Just my misunderstanding?
>>
> 
> The goal of `rte_flow_action_handle_query_update()` is to execute query and update actions atomically.
> The function guaranties that action state will not change by any event before both update and query complete.
> If the function was called with the ` RTE_FLOW_QU_QUERY_FIRST ` `mode` argument, then update execution can depend
> on query result. That's up to query format, PMD implementation and hardware capabilities.
> I hope that answered your question.

Sorry, I'm still confused. Could you explain a bit more,
please. How update could depend on query result?
Caller already specified update structure...