From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3 27/27] net/ena: set link speed as none Date: Fri, 8 Jun 2018 20:37:23 +0100 Message-ID: References: <20180607094322.14312-1-mk@semihalf.com> <20180607094322.14312-27-mk@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik To: Michal Krawczyk , Marcin Wojtas , Guy Tzalik , Evgeny Schemeilin Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 8C5E75587 for ; Fri, 8 Jun 2018 21:37:28 +0200 (CEST) In-Reply-To: <20180607094322.14312-27-mk@semihalf.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/7/2018 10:43 AM, Michal Krawczyk wrote: > From: Rafal Kozik > > Link speed should is not limited to 10Gb/s and it shouldn't be hardcoded. > > They link speed is set to none instead and the applications shouldn't > rely on this value when using ENA PMD. Why not able to set link speed? And what is the link_autoneg, ETH_LINK_FIXED? What is the point of setting link speed FIXED and later speed value NONE? > > Fixes: 1173fca ("ena: add polling-mode driver") For next time can you please use git alias to have consistent Fixes format > > Signed-off-by: Rafal Kozik > Acked-by: Michal Krawczyk > --- > drivers/net/ena/ena_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 5c3b6494f..9ae73e331 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -848,7 +848,7 @@ static int ena_link_update(struct rte_eth_dev *dev, > adapter = (struct ena_adapter *)(dev->data->dev_private); > > link->link_status = adapter->link_status ? ETH_LINK_UP : ETH_LINK_DOWN; > - link->link_speed = ETH_SPEED_NUM_10G; > + link->link_speed = ETH_SPEED_NUM_NONE; > link->link_duplex = ETH_LINK_FULL_DUPLEX; > > return 0; >