Re: [Qemu-devel] [PULL 2/8] target/m68k: implement flognp1

From: Laurent Vivier <laurent@vivier.eu>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 2/8] target/m68k: implement flognp1
Date: Fri, 27 Apr 2018 16:17:01 +0200	[thread overview]
Message-ID: <ab1bcd13-0ccd-ee62-657a-cc823491e6fd@vivier.eu> (raw)
In-Reply-To: <CAFEAcA_9biKcR9pon0eTVkDXwobBepUgs12rCfdGcRyE3HfUXQ@mail.gmail.com>

Le 27/04/2018 à 15:43, Peter Maydell a écrit :
> On 9 March 2018 at 14:26, Laurent Vivier <laurent@vivier.eu> wrote:
>> Using a local m68k floatx80_lognp1()
>> [copied from previous:
>> Written by Andreas Grabher for Previous, NeXT Computer Emulator.]
>>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> Message-Id: <20180305203910.10391-3-laurent@vivier.eu>
> 
>> +floatx80 floatx80_lognp1(floatx80 a, float_status *status)
>> +{
> 
> ...
> 
>> +    if (aSign && aExp >= one_exp) {
>> +        if (aExp == one_exp && aSig == one_sig) {
>> +            float_raise(float_flag_divbyzero, status);
>> +            packFloatx80(aSign, floatx80_infinity.high, floatx80_infinity.low);
> 
> Hi; Coverity (CID1390587) points out that packFloatx80 doesn't
> do anything except return a value which is here being thrown
> away, making the call useless. Should this be maybe
> "return packFloatx80(...)" ?

Yes, you're right, I didn't correctly port the code from "Previous" here.

Thanks,
Laurent