[PATCH 19/19] ARM: imx8m: verdin-imx8mm: Enable USB Host support

From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: u-boot@lists.denx.de
Subject: [PATCH 19/19] ARM: imx8m: verdin-imx8mm: Enable USB Host support
Date: Thu, 8 Apr 2021 07:08:25 +0000	[thread overview]
Message-ID: <ab3e4a27b7d1e581f6d199cd405d66eaa4c7c44d.camel@toradex.com> (raw)
In-Reply-To: <20210402124812.186761-19-marex@denx.de>

Hi Marek

Upon compiling I noticed the following but I do realize that it is not this patch set which introduced this
issue.

drivers/usb/host/ehci-mx6.c: In function ?ehci_usb_probe?:
drivers/usb/host/ehci-mx6.c:686:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-
cast]
  686 |  hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
      |                              ^
drivers/usb/host/ehci-mx6.c:686:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-
cast]
  686 |  hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
      |         ^
drivers/usb/host/ehci-mx6.c:687:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-
cast]
  687 |  hcor = (struct ehci_hcor *)((uint32_t)hccr +
      |                              ^
drivers/usb/host/ehci-mx6.c:687:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-
cast]
  687 |  hcor = (struct ehci_hcor *)((uint32_t)hccr +
      |         ^
At top level:
drivers/usb/host/ehci-mx6.c:251:13: warning: ?usb_oc_config? defined but not used [-Wunused-function]
  251 | static void usb_oc_config(struct usbnc_regs *usbnc, int index)
      |             ^~~~~~~~~~~~~

Then upon booting I noticed the following two issues. Did you also see that?

write error to device: 930f90 register: x!write error to device: 930f90 register: x!write error to device:
930f90 register: x!write error to device: 930f90 register: x!Normal Boot

imx_wdt watchdog at 30280000: pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19

Anyway, the USB host stuff this patch is about works perfectly. Thanks!

Cheers

Marcel

On Fri, 2021-04-02 at 14:48 +0200, Marek Vasut wrote:
> Enable USB host support on MX8MM Verdin.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Whole patch set (BTW: you don't like cover letters?).

Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> # Verdin iMX8M Mini V1.0B and V1.1A

> Cc: Max Krummenacher <max.krummenacher@toradex.com>
> Cc: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> ---
> ?configs/verdin-imx8mm_defconfig | 8 +++++++-
> ?include/configs/verdin-imx8mm.h | 6 ++++++
> ?2 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/configs/verdin-imx8mm_defconfig b/configs/verdin-imx8mm_defconfig
> index ea0b5978f1f..c8c3420b6a5 100644
> --- a/configs/verdin-imx8mm_defconfig
> +++ b/configs/verdin-imx8mm_defconfig
> @@ -37,7 +37,6 @@ CONFIG_SPL_BOARD_INIT=y
> ?CONFIG_SPL_SEPARATE_BSS=y
> ?CONFIG_SPL_I2C_SUPPORT=y
> ?CONFIG_SPL_POWER_SUPPORT=y
> -CONFIG_SPL_USB_HOST_SUPPORT=y
> ?CONFIG_SPL_WATCHDOG_SUPPORT=y
> ?CONFIG_SYS_PROMPT="Verdin iMX8MM # "
> ?# CONFIG_BOOTM_NETBSD is not set
> @@ -50,6 +49,7 @@ CONFIG_CMD_FUSE=y
> ?CONFIG_CMD_GPIO=y
> ?CONFIG_CMD_I2C=y
> ?CONFIG_CMD_MMC=y
> +CONFIG_CMD_USB=y
> ?CONFIG_CMD_CACHE=y
> ?CONFIG_CMD_UUID=y
> ?CONFIG_CMD_REGULATOR=y
> @@ -89,6 +89,8 @@ CONFIG_MII=y
> ?CONFIG_PINCTRL=y
> ?CONFIG_SPL_PINCTRL=y
> ?CONFIG_PINCTRL_IMX8M=y
> +CONFIG_POWER_DOMAIN=y
> +CONFIG_IMX8M_POWER_DOMAIN=y
> ?CONFIG_DM_PMIC=y
> ?CONFIG_SPL_DM_PMIC_PCA9450=y
> ?CONFIG_DM_PMIC_PFUZE100=y
> @@ -101,5 +103,9 @@ CONFIG_SPL_SYSRESET=y
> ?CONFIG_SYSRESET_PSCI=y
> ?CONFIG_SYSRESET_WATCHDOG=y
> ?CONFIG_DM_THERMAL=y
> +CONFIG_USB=y
> +CONFIG_DM_USB=y
> +# CONFIG_SPL_DM_USB is not set
> +CONFIG_USB_EHCI_HCD=y
> ?CONFIG_IMX_WATCHDOG=y
> ?CONFIG_OF_LIBFDT_OVERLAY=y
> diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
> index 4751bf5a5af..e3ba08dc69c 100644
> --- a/include/configs/verdin-imx8mm.h
> +++ b/include/configs/verdin-imx8mm.h
> @@ -117,5 +117,11 @@
> ?#define FEC_QUIRK_ENET_MAC
> ?#define IMX_FEC_BASE???????????????????0x30BE0000
> ?
> +/* USB Configs */
> +#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
> +#define CONFIG_MXC_USB_PORTSC??(PORT_PTS_UTMI | PORT_PTS_PTW)
> +#define CONFIG_MXC_USB_FLAGS???0
> +#define CONFIG_USB_MAX_CONTROLLER_COUNT 2
> +
> ?#endif /*_VERDIN_IMX8MM_H */