From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82077C433EF for ; Tue, 21 Jun 2022 14:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QySdBoBek+R/HEAuPbkNaDfHfLY7/pcyCH7+j4qDcAQ=; b=RvvK5yEnMT9xxh3cI2o21AN5Mu wykDEewATCDCkMN6vHb/7jdRcsYG3iRvrjyQz8bhthsH/6rXDlUEz6Jz2Q1x6udV1hqgVVLCy5Ykb Gzdl+klZ+dvkk/aV7MQRlyYGhTVELkMZM+igX+hsL2f1bLTlKLAaQTEFpfAWHggzoVo2TtZjEo0eX zFQxQTm2gZNxZf/gPCxqutvBdsDXUOLdbO8Nzl1BYBfZYRE4AHpBRJBEig77DsOvcCJ0u2txGsGgk crDSctPHJLm/Ziy3E6OLnQigQbzYM3nZCxNcAMjnvZFxXQO1ZnF7zXYsku9EmIGYD5liBJ1pD6Og8 FqnJdL3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3fCz-005yg4-3m; Tue, 21 Jun 2022 14:50:25 +0000 Received: from mail-ed1-f51.google.com ([209.85.208.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3fCw-005yem-6Z for linux-nvme@lists.infradead.org; Tue, 21 Jun 2022 14:50:23 +0000 Received: by mail-ed1-f51.google.com with SMTP id e40so7165597eda.2 for ; Tue, 21 Jun 2022 07:50:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=QySdBoBek+R/HEAuPbkNaDfHfLY7/pcyCH7+j4qDcAQ=; b=QZf5+ZtE57J09ySdwaiyz57coEhmwknr0XlKb+6gy30sBLCxP3IPdSWoK337GnKh5j U16Qda7vEWv1NX6i652yCJvPLd2X7ESB2pAcVwmpWNMOdqE9QmNQP4/6XnwybIhzxju2 kp/uMn4fjPWLXMnRhFsNKKnGe+kiTHQXro0dX9n6X6t6d0QbOdAjpZi4iIUaaiT12TJi QzYsGfa9TRRHZTMRNmIVcaufcAeppzkkqwg/faCTNZtJar8UzI1+t8Ap4TzZRq1YK6KK vaP5NYCJdaFHAZtwpyrzVrrMMpzErCobuU6BKkDfbPhsh0m3wA14nZgi2aX/Qu2DnavE fOOA== X-Gm-Message-State: AJIora9lbH0cNWpLSU7vqg8QFBwqejkY224ze2EjfePGklPjBz6M9jn1 eCBAK2/tUwNWZDy25eb3Pi4= X-Google-Smtp-Source: AGRyM1sGeNIKkTVir/pisZyA+JFpPRwFRIdNQpeOnOcSwv+iy4Gy09cr2yfREqPaPk67Ic07EQ6kmw== X-Received: by 2002:a05:6402:2752:b0:433:3a08:27b1 with SMTP id z18-20020a056402275200b004333a0827b1mr35766415edd.235.1655823019567; Tue, 21 Jun 2022 07:50:19 -0700 (PDT) Received: from [10.100.102.14] (46-117-125-14.bb.netvision.net.il. [46.117.125.14]) by smtp.gmail.com with ESMTPSA id d5-20020a170906344500b006fed062c68esm7606492ejb.182.2022.06.21.07.50.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jun 2022 07:50:19 -0700 (PDT) Message-ID: Date: Tue, 21 Jun 2022 17:50:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 06/11] nvme: Implement In-Band authentication Content-Language: en-US To: Hannes Reinecke , Christoph Hellwig Cc: Keith Busch , linux-nvme@lists.infradead.org References: <20220621090255.69549-1-hare@suse.de> <20220621090255.69549-7-hare@suse.de> <22236c51-90cd-1707-05b8-3772ef4c548d@suse.de> From: Sagi Grimberg In-Reply-To: <22236c51-90cd-1707-05b8-3772ef4c548d@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220621_075022_280831_BED91487 X-CRM114-Status: GOOD ( 10.56 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 6/21/22 17:26, Hannes Reinecke wrote: > On 6/21/22 16:24, Sagi Grimberg wrote: >> This one doesn't compile against nvme-5.20. >> >>> +    ret = __nvme_submit_sync_cmd(q, &cmd, NULL, data, data_len, 0, >>> +                     qid == 0 ? NVME_QID_ANY : qid, >>> +                     0, flags); >> >> here ^^^^^^^ > > Sheesh. I've compiled it against nvme-5.19, where it works perfectly. > Alright, once more unto the breach ... Looks like if I pass a malformed ctrl key to nvme connect I am able to crash the system: -- [ 84.793307] Workqueue: nvme-wq __nvme_auth_work [nvme_core] [ 84.794790] RIP: 0010:nvme_auth_transform_key+0x19/0x1f0 [nvme_common] [ 84.796468] Code: bc f4 ff ff ff eb bf e8 f5 2f e1 ee 0f 1f 44 00 00 0f 1f 44 00 00 41 57 41 56 41 55 49 89 f5 41 54 55 53 48 89 fb 48 83 ec 08 <0f> b6 7f 10 e8 ce f9 ff ff 48 89 c7 0f b6 43 10 84 c0 0f 84 4c 01 [ 84.800112] RSP: 0018:ffffae5f8047bc78 EFLAGS: 00010296 [ 84.801048] RAX: ffff973b854ca0c0 RBX: 0000000000000000 RCX: 0000000000000000 [ 84.802289] RDX: ffff973b8355b000 RSI: ffff973b84f568a0 RDI: 0000000000000000 [ 84.803447] RBP: ffff973b842dd6b9 R08: 0000000000000003 R09: ffff973bbec308a8 [ 84.804638] R10: 0000000000000147 R11: 0000000000000000 R12: ffff973b842dd600 [ 84.805767] R13: ffff973b84f568a0 R14: 0000000000000000 R15: ffff973b9e94250d [ 84.806929] FS: 0000000000000000(0000) GS:ffff973bbec00000(0000) knlGS:0000000000000000 [ 84.808220] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 84.809178] CR2: 0000000000000010 CR3: 00000000061ac003 CR4: 0000000000370ef0 [ 84.810337] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 84.811432] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 84.812527] Call Trace: [ 84.812974] [ 84.813372] nvme_auth_dhchap_setup_ctrl_response+0x4b/0x3b0 [nvme_core] [ 84.814355] ? preempt_count_add+0x68/0xa0 [ 84.815080] ? _raw_spin_unlock_irq+0x16/0x28 [ 84.815840] ? __wait_for_common+0x19f/0x1d0 [ 84.816587] ? firmware_map_remove+0x87/0x87 [ 84.817333] ? blk_mq_hctx_has_pending+0x38/0x70 [ 84.818123] ? blk_mq_run_hw_queue+0x7d/0xe0 [ 84.818784] ? __blk_mq_free_request+0x9b/0xa0 [ 84.819482] ? blk_queue_exit+0xe/0x40 [ 84.820124] ? __nvme_submit_sync_cmd+0xe8/0x160 [nvme_core] [ 84.821096] ? nvme_auth_submit+0x8f/0xd0 [nvme_core] [ 84.821970] __nvme_auth_work+0x1fb/0x480 [nvme_core] [ 84.822869] process_one_work+0x1e5/0x3b0 [ 84.823608] worker_thread+0x1c4/0x3a0 [ 84.824343] ? rescuer_thread+0x390/0x390 [ 84.825044] kthread+0xe8/0x110 --