From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D81E0C43334 for ; Wed, 8 Jun 2022 10:17:57 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.343773.569275 (Exim 4.92) (envelope-from ) id 1nysks-00078l-Hs; Wed, 08 Jun 2022 10:17:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 343773.569275; Wed, 08 Jun 2022 10:17:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nysks-00078e-El; Wed, 08 Jun 2022 10:17:38 +0000 Received: by outflank-mailman (input) for mailman id 343773; Wed, 08 Jun 2022 10:17:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nyskr-00078Y-5Z for xen-devel@lists.xenproject.org; Wed, 08 Jun 2022 10:17:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nyskp-0002I3-Vz; Wed, 08 Jun 2022 10:17:35 +0000 Received: from [54.239.6.189] (helo=[192.168.10.106]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nyskp-0001J5-J4; Wed, 08 Jun 2022 10:17:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=IoMv2n41yEwpZh6S8L3Tl/wbkXKn28BjTOqLofJm3/s=; b=rDZc7qeZZLknBhTCLY7apulSTi h+8AZ+9sOuKeWcV063q8Mt8vdo9kXivt0tqmf+9JxWbf40MU7gN0W0mfY2GkXh+43HxQg7qKH/fHO q/4KQQ8AVJUrV7WlRAwcBO/m82VRYmVdgPhf4V65pQ3Eyif120yjiIopUmgSHNFEMlmk=; Message-ID: Date: Wed, 8 Jun 2022 11:17:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime To: Bertrand Marquis , Michal Orzel Cc: xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk References: <20220523091324.137350-1-michal.orzel@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 30/05/2022 10:09, Bertrand Marquis wrote: >> On 23 May 2022, at 10:13, Michal Orzel wrote: >> >> Introduce a command line parameter "maxcpus" on Arm to allow adjusting >> the number of CPUs to activate. Currently the limit is defined by the >> config option CONFIG_NR_CPUS. Such parameter already exists on x86. >> >> Define a parameter "maxcpus" and a corresponding static variable >> max_cpus in Arm smpboot.c. Modify function smp_get_max_cpus to take >> max_cpus as a limit and to return proper unsigned int instead of int. >> >> Take the opportunity to remove redundant variable cpus from start_xen >> function and to directly assign the return value from smp_get_max_cpus >> to nr_cpu_ids (global variable in Xen used to store the number of CPUs >> actually activated). >> >> Signed-off-by: Michal Orzel > > With the warning added in the documentation (which is ok to do on commit): > > Reviewed-by: Bertrand Marquis I have committed it with the update in the documentation. Cheers, -- Julien Grall