All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: bharata@linux.vnet.ibm.com
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH] spapr-cpu-core: Release ICPState object during CPU unrealization
Date: Wed, 12 Apr 2017 11:03:44 +0200	[thread overview]
Message-ID: <ab619b56-35ba-80f8-7647-06666673b7bb@kaod.org> (raw)
In-Reply-To: <20170412085300.GB1429@in.ibm.com>

On 04/12/2017 10:53 AM, Bharata B Rao wrote:
> On Wed, Apr 12, 2017 at 10:47:39AM +0200, Cédric Le Goater wrote:
>> On 04/12/2017 10:15 AM, Bharata B Rao wrote:
>>> Recent commits that re-organized ICPState object missed to destroy
>>> the object when CPU is unrealized. Fix this so that CPU unplug
>>> doesn't abort QEMU.
>>
>> Indeed.
>>
>>> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
>>
>> I am wondering if we should not be doing the unparent under 
>> spapr_cpu_destroy() or even xics_cpu_destroy(). Apart from
>> that, 
> 
> Thought so, but since object is created in realize routinte itself
> (and not in any of its callers), did the object destruction in
> unrealize to be symmetrical :)

yes. I think it is a good pratice to unparent/free the object 
in the same file it was allocated.

Thanks,

C.

  reply	other threads:[~2017-04-12  9:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12  8:15 [Qemu-devel] [PATCH] spapr-cpu-core: Release ICPState object during CPU unrealization Bharata B Rao
2017-04-12  8:21 ` Bharata B Rao
2017-04-12  8:47 ` Cédric Le Goater
2017-04-12  8:53   ` Bharata B Rao
2017-04-12  9:03     ` Cédric Le Goater [this message]
2017-04-13  2:54 ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab619b56-35ba-80f8-7647-06666673b7bb@kaod.org \
    --to=clg@kaod.org \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.