From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2917ECAAD3 for ; Thu, 15 Sep 2022 09:29:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbiIOJ30 (ORCPT ); Thu, 15 Sep 2022 05:29:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbiIOJ3V (ORCPT ); Thu, 15 Sep 2022 05:29:21 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 436A680F70; Thu, 15 Sep 2022 02:29:20 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 28F9Sx4k123160; Thu, 15 Sep 2022 04:28:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1663234139; bh=I2K32vA2lgUmiXzBYb3fBHYBUakCcdVOGjJp84HLIok=; h=Date:CC:Subject:To:References:From:In-Reply-To; b=dd3iJHo8sI5xKsMtmCSyf21XC0+DBvQIT4J0MMsy+3ntAmtHHbtG8J6ALgs3V7y4B K/q1ptHc2mmAkFLSsFwfm61U7eVupHnaq78vci0xtmqh0PpRoHFJ69MCJswooHI4j9 A6iIyZ1YtGzaVRaQI/o24d/EY2TBDGzKRT/Kapkk= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 28F9SxZo016129 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 15 Sep 2022 04:28:59 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Thu, 15 Sep 2022 04:28:58 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Thu, 15 Sep 2022 04:28:58 -0500 Received: from [10.24.69.241] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 28F9SrSC079482; Thu, 15 Sep 2022 04:28:53 -0500 Message-ID: Date: Thu, 15 Sep 2022 14:58:52 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH 5/8] net: ethernet: ti: am65-cpsw: Add support for fixed-link configuration Content-Language: en-US To: "Russell King (Oracle)" References: <20220914095053.189851-1-s-vadapalli@ti.com> <20220914095053.189851-6-s-vadapalli@ti.com> From: Siddharth Vadapalli In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Russell, On 14/09/22 21:39, Russell King (Oracle) wrote: > On Wed, Sep 14, 2022 at 03:20:50PM +0530, Siddharth Vadapalli wrote: >> Check for fixed-link in am65_cpsw_nuss_mac_config() using struct >> am65_cpsw_slave_data's phy_node property to obtain fwnode. Since >> am65_cpsw_nuss_mac_link_up() is not invoked in fixed-link mode, perform >> the relevant operations in am65_cpsw_nuss_mac_config() itself. > > Further to my other comments, you also fail to explain that, when in > fixed-link SGMII mode, you _emulate_ being a PHY - which I deduce > since you are sending the duplex setting and speed settings via the > SGMII control word. Also, as SGMII was invented for a PHY to be able > to communicate the media negotiation resolution to the MAC, SGMII > defines that the PHY fills in the speed and duplex information in > the control word to pass it to the MAC, and the MAC acknowledges this > information. There is no need (and SGMII doesn't permit) the MAC to > advertise what it's doing. > > Maybe this needs to be explained in the commit message? I had tested SGMII fixed-link mode using a bootstrapped ethernet layer-1 PHY. Based on your clarification in the previous mails that there is an issue with the fixed-link mode which I need to debug, I assume that what you are referring to here also happens to be a consequence of that. Please let me know if I have misunderstood what you meant to convey. Regards, Siddharth. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7C70ECAAD3 for ; Thu, 15 Sep 2022 09:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: CC:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5QP5TfS9VICnp41eTeNtvO6qCU5LAT0aXnDk0IWGwCU=; b=Xb94qsnQRDlVOa qVflQAZtIhsed/YVavBDc8MXIQPgQSfS1NSbAZUvMnUgGvDGkis/3x0cTbYrFII0++6I4SjxXwwwf EBoiFnZ3f5MH+wp9tVRh58A8ncWOT/jkea9pP5M8Y/L70yncEZPCCkOKBim9OvoQubUOQWnR57bG5 2h7DYTAgsKkhY7izn5kKuRddA1AP7PKVijOH4dvcaLbP73fdFCc2u60FvH7M931plQ2eMcNTgm7I6 8OaFz3AvsIZrJ8xVeKXbuqVJeBYLpY5HCayX3hYq/tFWdbHyXuv1J6FnDakWT4HylJVli7BNG5r3Q rAy0f2XS2BzunBLsWNcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYlBO-005Iif-4L; Thu, 15 Sep 2022 09:29:18 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYlBJ-005IfX-6v for linux-arm-kernel@lists.infradead.org; Thu, 15 Sep 2022 09:29:15 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 28F9Sx4k123160; Thu, 15 Sep 2022 04:28:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1663234139; bh=I2K32vA2lgUmiXzBYb3fBHYBUakCcdVOGjJp84HLIok=; h=Date:CC:Subject:To:References:From:In-Reply-To; b=dd3iJHo8sI5xKsMtmCSyf21XC0+DBvQIT4J0MMsy+3ntAmtHHbtG8J6ALgs3V7y4B K/q1ptHc2mmAkFLSsFwfm61U7eVupHnaq78vci0xtmqh0PpRoHFJ69MCJswooHI4j9 A6iIyZ1YtGzaVRaQI/o24d/EY2TBDGzKRT/Kapkk= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 28F9SxZo016129 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 15 Sep 2022 04:28:59 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Thu, 15 Sep 2022 04:28:58 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Thu, 15 Sep 2022 04:28:58 -0500 Received: from [10.24.69.241] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 28F9SrSC079482; Thu, 15 Sep 2022 04:28:53 -0500 Message-ID: Date: Thu, 15 Sep 2022 14:58:52 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH 5/8] net: ethernet: ti: am65-cpsw: Add support for fixed-link configuration Content-Language: en-US To: "Russell King (Oracle)" References: <20220914095053.189851-1-s-vadapalli@ti.com> <20220914095053.189851-6-s-vadapalli@ti.com> From: Siddharth Vadapalli In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220915_022913_375355_DA6413EA X-CRM114-Status: GOOD ( 16.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Russell, On 14/09/22 21:39, Russell King (Oracle) wrote: > On Wed, Sep 14, 2022 at 03:20:50PM +0530, Siddharth Vadapalli wrote: >> Check for fixed-link in am65_cpsw_nuss_mac_config() using struct >> am65_cpsw_slave_data's phy_node property to obtain fwnode. Since >> am65_cpsw_nuss_mac_link_up() is not invoked in fixed-link mode, perform >> the relevant operations in am65_cpsw_nuss_mac_config() itself. > > Further to my other comments, you also fail to explain that, when in > fixed-link SGMII mode, you _emulate_ being a PHY - which I deduce > since you are sending the duplex setting and speed settings via the > SGMII control word. Also, as SGMII was invented for a PHY to be able > to communicate the media negotiation resolution to the MAC, SGMII > defines that the PHY fills in the speed and duplex information in > the control word to pass it to the MAC, and the MAC acknowledges this > information. There is no need (and SGMII doesn't permit) the MAC to > advertise what it's doing. > > Maybe this needs to be explained in the commit message? I had tested SGMII fixed-link mode using a bootstrapped ethernet layer-1 PHY. Based on your clarification in the previous mails that there is an issue with the fixed-link mode which I need to debug, I assume that what you are referring to here also happens to be a consequence of that. Please let me know if I have misunderstood what you meant to convey. Regards, Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel