From: Michal Orzel <michal.orzel@arm.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice()
Date: Mon, 23 May 2022 09:00:56 +0200 [thread overview]
Message-ID: <ab74884e-9a16-a9cb-de57-9f2907e21f71@arm.com> (raw)
In-Reply-To: <20220522165900.83104-1-julien@xen.org>
Hi Julien,
On 22.05.2022 18:59, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> xsm_deasign_dtdevice() will indicate whether the caller is allowed
s/deasign/deassign/
> to issue the operation. So the return value has to be checked.
>
> Spotted by clang static analyzer.
>
> Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device")
> Signed-off-by: Julien Grall <jgrall@amazon.com>
Apart from that:
Reviewed-by: Michal Orzel <michal.orzel@arm.com>
next prev parent reply other threads:[~2022-05-23 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 16:59 [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice() Julien Grall
2022-05-23 7:00 ` Michal Orzel [this message]
2022-05-23 20:01 ` Julien Grall
2022-05-24 7:54 ` Bertrand Marquis
2022-05-25 8:53 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab74884e-9a16-a9cb-de57-9f2907e21f71@arm.com \
--to=michal.orzel@arm.com \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.