All of lore.kernel.org
 help / color / mirror / Atom feed
From: "chenxiang (M)" <chenxiang66@hisilicon.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: <sh_def@163.com>, <mm-commits@vger.kernel.org>,
	<linuxarm@openeuler.org>, <linuxarm@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm,kmemleak-test: add the dependency on CONFIG_SAMPLES
Date: Thu, 27 May 2021 14:42:36 +0800	[thread overview]
Message-ID: <ab78b4fc-af91-e67e-2dbd-04d054ae80fc@hisilicon.com> (raw)
In-Reply-To: <20210526093047.GC19992@arm.com>

Hi Catalin,


在 2021/5/26 17:30, Catalin Marinas 写道:
> On Wed, May 26, 2021 at 10:10:08AM +0800, chenxiang wrote:
>> From: Xiang Chen <chenxiang66@hisilicon.com>
>>
>> As kmemleak-test.c is moved to samples dir, it is not compiled if just
>> setting CONFIG_DEBUG_KMEMLEAK_TEST as module and enabling
>> CONFIG_DEBUG_KMEMLEAK. Because it depends on CONFIG_SAMPLES after it is
>> moved to samples dir.
>> So the dependency on CONFIG_SAMPLES is added.
>>
>> Fixes: 1abbef4f5172 ("mm,kmemleak-test.c: move kmemleak-test.c to samples dir")
>> Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
>> ---
>>   lib/Kconfig.debug | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index 2779c29..9950542 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -716,7 +716,7 @@ config DEBUG_KMEMLEAK_MEM_POOL_SIZE
>>   
>>   config DEBUG_KMEMLEAK_TEST
>>   	tristate "Simple test for the kernel memory leak detector"
>> -	depends on DEBUG_KMEMLEAK && m
>> +	depends on DEBUG_KMEMLEAK && SAMPLES && m
>>   	help
>>   	  This option enables a module that explicitly leaks memory.
> Would it make more sense to move the DEBUG_KMEMLEAK_TEST option to
> samples as well and maybe rename it to SAMPLES_KMEMLEAK?

Right, it seems be better to move the option to samples dir and rename it.
I will change it in next verison.

>



      reply	other threads:[~2021-05-27  6:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  2:10 [PATCH] mm,kmemleak-test: add the dependency on CONFIG_SAMPLES chenxiang
2021-05-26  9:30 ` Catalin Marinas
2021-05-27  6:42   ` chenxiang (M) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab78b4fc-af91-e67e-2dbd-04d054ae80fc@hisilicon.com \
    --to=chenxiang66@hisilicon.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=linuxarm@openeuler.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=sh_def@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.