From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tal Gilboa <talgi@mellanox.com>
Subject: Re: [PATCH net-next 0/4] Introduce adaptive TX interrupt moderation
 to net DIM
Date: Sun, 1 Apr 2018 09:49:21 +0300
Message-ID: <ab7dafdf-e21d-183a-d032-fca89678574b@mellanox.com>
References: <1522391853-37298-1-git-send-email-talgi@mellanox.com>
 <20180331.220255.1848301322283268857.davem@davemloft.net>
 <20180331.231929.1875689505974197531.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-7; format=flowed
Content-Transfer-Encoding: 8bit
Cc: netdev@vger.kernel.org, tariqt@mellanox.com,
        andrew.gospodarek@broadcom.com, saeedm@mellanox.com
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-he1eur01on0078.outbound.protection.outlook.com ([104.47.0.78]:26964
        "EHLO EUR01-HE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750710AbeDAGtd (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 1 Apr 2018 02:49:33 -0400
In-Reply-To: <20180331.231929.1875689505974197531.davem@davemloft.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 4/1/2018 6:19 AM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Sat, 31 Mar 2018 22:02:55 -0400 (EDT)
> 
>> From: Tal Gilboa <talgi@mellanox.com>
>> Date: Fri, 30 Mar 2018 09:37:29 +0300
>>
>>> Net DIM is a library designed for dynamic interrupt moderation. It was
>>> implemented and optimized with receive side interrupts in mind, since these
>>> are usually the CPU expensive ones. This patch-set introduces adaptive transmit
>>> interrupt moderation to net DIM, complete with a usage in the mlx5e driver.
>>> Using adaptive TX behavior would reduce interrupt rate for multiple scenarios.
>>> Furthermore, it is essential for increasing bandwidth on cases where payload
>>> aggregation is required.
>>
>> Series applied.
> 
> This breaks the build:
> 
> drivers/net/ethernet/broadcom/bcmsysport.c: In function ¡bcm_sysport_set_coalesce¢:
> drivers/net/ethernet/broadcom/bcmsysport.c:657:11: error: implicit declaration of function ¡net_dim_get_def_profile¢; did you mean ¡net_dim_exit_parking¢? [-Werror=implicit-function-declaration]
>     moder = net_dim_get_def_profile(priv->dim.dim.mode);
>             ^~~~~~~~~~~~~~~~~~~~~~~
> 
Rebase issues, sorry.
Sent a fixup patch.