From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E40C6E287 for ; Fri, 8 Mar 2019 06:59:54 +0000 (UTC) References: <20190305131611.2367-1-andi.shyti@intel.com> <20190305131611.2367-5-andi.shyti@intel.com> <20190307135426.GD1418@intel.intel> <6fba9cb1-9155-1715-22ea-a44aa12cef6f@linux.intel.com> <20190307154642.GE1418@intel.intel> <13e2091d-9ff4-3f01-95f1-3523aad1e3b2@linux.intel.com> <20190307171706.GA8818@intel.intel> From: Tvrtko Ursulin Message-ID: Date: Fri, 8 Mar 2019 06:59:51 +0000 MIME-Version: 1.0 In-Reply-To: <20190307171706.GA8818@intel.intel> Content-Language: en-US Subject: Re: [igt-dev] [RFC PATCH v10 4/6] lib: ioctl_wrappers: reach engines by index as well List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti Cc: IGT dev , Andi Shyti List-ID: Ck9uIDA3LzAzLzIwMTkgMTc6MTcsIEFuZGkgU2h5dGkgd3JvdGU6Cj4+IEkgdW5kZXJzdGFuZCB0 aGUgbG9vcCBpdHNlbGYgd29ya3MsIGJ1dCBJIHdhbnRlZCB0byBmaW5kIG91dCBob3cgZG8gSSB3 cml0ZQo+PiBhIHRlc3Qgd2hpY2ggdXNlcyBpdCBhbmQgYWN0dWFsbHkgc3VibWl0cyB3b3JrLgo+ Pgo+PiBmb3JfZWFjaF9lbmdpbmUyKGZkLCBjdHgpIHsKPj4gCS4uLgo+PiAJZWIuZmxhZ3MgPSA/ Pz87Cj4+IAllYi5yc3ZkMSA9IGN0eDsKPj4KPj4gCWdlbV9leGVjYnVmKGZkLCAmZWIpOwo+PiB9 Cj4+Cj4+IFdoYXQgZG8gSSByZXBsYWNlID8/PyB3aXRoIHNvIHRoZSB0ZXN0IHdvcmtzIG9uIG9s ZCBhbmQgbmV3IGtlcm5lbHM/Cj4gCj4gSSBndWVzcyBpdCB3b3VsZCBiZToKPiAKPiAgICBpbmRl eF9tYXAgPSAwOwo+ICAgIGZvcl9lYWNoX2VuZ2luZTIoZmQsIGN0eCkgewo+ICAgICAgICAuLi4K PiAgICAgICAgZWIuZmxhZ3MgPSArK2luZGV4X21hcDsKPiAgICAgICAgZWIucnN2ZDEgPSBjdHg7 Cj4gCj4gICAgICAgIGdlbV9leGVjYnVmKGZkLCAmZWIpOwo+ICAgIH0KPiAKPiBmb3JfZWFjaF9l bmdpbmUyIGlzIGp1c3QgcmVzcG9uc2libGUgZm9yIGl0ZXJhdGluZyB0aHJvdWdoCj4gZW5naW5l cy4gKCopCj4gCj4gd2hpbGUgZm9yIHRoZSBjdXJyZW50IGFwaSBpdCB3b3VsZCBiZToKPiAKPiAg ICBmb3JfZWFjaF9lbmdpbmUyKGZkLCAwKSB7Cj4gICAgICAgIGViLmZsYWdzID0gZ2VtX2NsYXNz X2luc3RhbmNlX3RvX2ViX2ZsYWdzKGZkLCBlMl9fLT5jbGFzcywgZTJfXy0+aW5zdGFuY2UpKTsK PiAgICAgICAgZWIucnN2ZDEgPSAwOwo+ICAgIH0KClNvIGFzIEkgd2FzIHBvaW50aW5nIG91dCBp dCBpcyBub3QgcG9zc2libGUgdG8gd3JpdGUgYSB0ZXN0IHdoaWNoIHdvcmtzIAp3aXRoIHNhbWUg Y29kZSBvbiBib3RoIG9sZCBhbmQgbmV3IGtlcm5lbHM/IFdoaWNoIG1ha2VzIG1lIGFzayAtIHdo YXQgaXMgCnRoZSBwb2ludCBvZiBtYWtpbmcgdGhlIGl0ZXJhdG9yIGJhY2t3YXJkIGNvbXBhdGli bGU/CgpJTUhPIHdlIGVpdGhlciBkcm9wIHRoZSBiYWNrd2FyZCBjb21wYXRpYmxlIGdvYWwgb3Ig bWFrZSBzb21lIGFkZGl0aW9ucyAKdG8gZW5hYmxlIHdyaXRpbmcgdHJ1bHkgYWdub3N0aWMgdGVz dHMuIE1heWJlIGFsb25nIHRoZSBsaW5lcyBvZjoKCmZvcl9lYWNoX2VuZ2luZTIoZmQsIGN0eCwg aSkgewoJLi4uCglnZW1fc2V0X2V4ZWNidWZfZW5naW5lKCZlYiwgZmQsIGN0eCwgZTIsIGkpOwoJ Li4uCgogICAgCWdlbV9leGVjYnVmKGZkLCAmZWIpOwp9Cgp2b2lkIGdlbV9zZXRfZXhlY2J1Zl9l bmdpbmUoLi4uKQp7CglpZiAoZ2VtX2hhc19kaXNjb3ZlcmVkX2VuZ2luZXMoKSAvKiBzaW1wbGUg cG9pbnRlciBjaGVjaywgbm8gaW9jdGwgKi8pIHsKCQllYi0+cnN2ZDEgPSBjdHg7CgkJZWItPmZs YWdzIHw9IGk7Cgl9IGVsc2UgewoJCWViLT5mbGFncyB8PSBnZW1fY2xhc3NfaW5zdGFuY2VfdG9f ZWJfZmxhZ3MoLi4uKTsKCX0KfQoKQSBiaXQgbG9uZ2lzaCBwYXJhbWV0ZXIgbGlzdCBmb3IgdGhl IGhlbHBlciBidXQgSSBkb24ndCBoYXZlIGJldHRlciAKaWRlYXMgYXQgdGhlIG1vbWVudC4KClJl Z2FyZHMsCgpUdnJ0a28KCj4gVGhlcmUgZGVmaW5pdGVseSBhcmUgYmV0dGVyIHdheSBmb3IgZG9p bmcgdGhlCj4gZm9yX2VhY2hfZW5naW5lKC4uLikgYnV0IEkgdGhpbmsgdGhpcyBpcyB0aGUgbW9z dCBjb25zaXN0ZW50IHRvCj4gdGhlIHdheSB0aGluZ3MgYXJlIGRvbmUgbm93Lgo+IAo+IEluIG15 IG9waW5pb24sIG5leHQgc3RlcCB3b3VsZCBiZSwgaW5kZWVkLCB0byBnZXQgcmlkIG9mIGFsbAo+ IGxlZ2FjeSBhbmQgaGF2ZSBhIHNpbmdsZSBmb3JfZWFjaF9lbmdpbmUoLi4uKSB0aGF0IHdvcmtz IHdpdGgKPiBldmVyeXRoaW5nLgo+IAo+IEJ1dCBmb3IgdGhpcywgYXQgbXkgY3VycmVudCB1bmRl cnN0YW5kaW5nLCB3ZSBuZWVkIHNvbWUKPiByZS1hcmNoaXRlY3R1cmluZyBvZiBpZ3QgKGFuZCBw b3NzaWJseSB1c2luZyBkeW5hbWljIGxpc3RzIG9mCj4gZW5naW5lcyBhcyBDaHJpcyBwb2ludGVk IG91dCkuCj4gCj4gT25jZSB0aGlzIHBhdGNoIGdldHMgaW4sIEkgY2FuIHN0YXJ0IGxvb2tpbmcg YXQgdGhlIG5leHQgc3RlcHMsCj4gYnV0IGluIG9uZSBnbywgd2Ugd291bGQgZ2V0IGV2ZXJ5dGhp bmcgaW4gb25seSBhdCAiW1BBVENIIHYxMTc0XSIgOikKPiAKPiBBbmRpCj4gCj4gKCopIFNvbWUg ZXh0cmEgY29kZSB3b3VsZCBiZSByZXF1aXJlZCB0byBpbmNyZW1lbnQgaW5kZXhfbWFwCj4gaW50 byB0aGUgZm9yX2VhY2hfZW5naW5lMigpLCBDaHJpcyB3YXMgc3VnZ2VzdGluZywgaW5kZWVkLCBh bgo+IGl0ZXIgc3RydWN0dXJlIChvciB3ZSBjYW4gdXNlIHNvbWUgb3RoZXIgJ0MnIHRyaWNrcyB0 aGF0IHdvdWxkCj4gbWFrZSB0aGUgY29kZSBxdWl0ZSB1bnJlYWRhYmxlKS4KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QK aWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2