From: Daniel Henrique Barboza <danielhb@linux.ibm.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
libvir-list@redhat.com, mdroth@linux.vnet.ibm.com,
qemu-devel@nongnu.org, Anthony Perard <anthony.perard@citrix.com>,
Igor Mammedov <imammedo@redhat.com>,
dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target
Date: Mon, 21 May 2018 16:46:36 -0300 [thread overview]
Message-ID: <ab91cf9f-95c3-59dc-36cb-641a3db1171b@linux.ibm.com> (raw)
In-Reply-To: <20180521181435.GN25013@localhost.localdomain>
On 05/21/2018 03:14 PM, Eduardo Habkost wrote:
>> Issue#2: the flag isn't a property of the target. Due to -no-acpi, it's
>> not even a property of the machine type. If it was, query-machines
>> would be the natural owner of the flag.
>>
>> Perhaps query-machines is still the proper owner. The value of
>> wakeup-suspend-support would have to depend on -no-acpi for the machine
>> types that honor it. Not ideal; I'd prefer MachineInfo to be static.
>> Tolerable? I guess that's also a libvirt question.
> It depends when libvirt is going to query it. Is it OK to only
> query it after the VM is already up and running? If it is, then
> we can simply expose it as a read-only property of the machine
> object.
>
> Or, if we don't want to rely on qom-get as a stable API, we can
> add a new query command (query-machine? query-power-management?)
>
In the first version this logic was included in a new query command called
"query-wakeup-from-suspend-support":
https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00889.html
In that review it was suggested that this logic could be a flag in
either query-target
or query-machines API. Before sending the v2 I sent the following comment:
"After investigating, I think that it's simpler to hook the wakeup
support info into
TargetInfo than MachineInfo, given that the detection I'm using for this
new property
is based on the current runtime state. Hooking into MachineInfo would
require to
change the MachineClass to add a new property, then setting it up for
the machines
that have the wakeup support (only x86 so far). Definitely doable, but
if we don't
have any favorites between MachineInfo and TargetInfo I'd rather pick
the simpler
route.
So, if no one objects, I'll rework this series by putting the logic
inside query-target
instead of a new API."
Since no objection was made back then, this logic was put into
query-target starting
in v2. Still, I don't have any favorites though: query-target looks ok,
query-machine
looks ok and a new API looks ok too. It's all about what makes (more)
sense in the
management level, I think.
danielhb
next prev parent reply other threads:[~2018-05-21 19:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 19:23 [Qemu-devel] [PATCH v7 0/3] wakeup-from-suspend and system_wakeup changes Daniel Henrique Barboza
2018-05-17 19:23 ` [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target Daniel Henrique Barboza
2018-05-18 8:48 ` Markus Armbruster
2018-05-21 18:14 ` Eduardo Habkost
2018-05-21 19:46 ` Daniel Henrique Barboza [this message]
2018-05-21 20:26 ` Eduardo Habkost
2018-05-23 9:17 ` Markus Armbruster
2018-05-23 12:27 ` Eduardo Habkost
2018-05-23 14:11 ` Daniel Henrique Barboza
2018-05-23 15:53 ` Markus Armbruster
2018-05-24 18:57 ` Eduardo Habkost
2018-05-25 6:30 ` Markus Armbruster
2018-05-25 20:30 ` Eduardo Habkost
2018-05-28 7:23 ` Markus Armbruster
2018-05-29 14:55 ` Eduardo Habkost
2018-06-19 20:29 ` Daniel Henrique Barboza
2018-06-20 7:09 ` Markus Armbruster
2018-05-17 19:23 ` [Qemu-devel] [PATCH v7 2/3] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions Daniel Henrique Barboza
2018-05-17 19:23 ` [Qemu-devel] [PATCH v7 3/3] qmp.c: system_wakeup: runstate and wake-up support check Daniel Henrique Barboza
2018-05-18 8:48 ` Markus Armbruster
2018-05-18 12:52 ` Daniel Henrique Barboza
2018-05-18 15:00 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab91cf9f-95c3-59dc-36cb-641a3db1171b@linux.ibm.com \
--to=danielhb@linux.ibm.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.