From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9DAC4332F for ; Wed, 23 Nov 2022 21:05:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235150AbiKWVFr (ORCPT ); Wed, 23 Nov 2022 16:05:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235765AbiKWVFq (ORCPT ); Wed, 23 Nov 2022 16:05:46 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F41FA99EBB for ; Wed, 23 Nov 2022 13:05:44 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id x21so22709205ljg.10 for ; Wed, 23 Nov 2022 13:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dzqt331g8T68TbUv6sgzKml0DHljiiwCg07CtnYVk1Q=; b=rdQUXwcIP0uEWh7Ulyhf+ky26BtMT19RFWwVxD33CSMIhC7n8iasJ+6WnsStWbiXxR /NLZCPKKcYPaYV0VIQqmFRXFsEqXhHsMvfquefe89IdzwtezCPskcFJMLWu81RllkmtH xe1TMNwABc2QWkw7JDNigKcjKX8uE8dPc69sqZNkNqFZCE3wtn6TMSknX3leib+edtnz dStnp+uThASYAQTfly6odXol9Co5iXJTMoxwKt2w2Zec66aHBHHNlvfwTGbg/wnqGgcL E/9TI/cKucsMIZLCArdgG5BeKCHsyh3iLwx/kJOgFX4zxrItqr1hbf/KFX18i8lqYQEP SHPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dzqt331g8T68TbUv6sgzKml0DHljiiwCg07CtnYVk1Q=; b=jds89yU7iTd0sAbGtVSi2uHY56OuATpijuEH0guAP0J92qyO/Dc7ODvGJ5wq8Ge/WA g25qmYTzYQWaX9+0wSwysy4R9R6zqDEW3vXOpUFwW0siaC4YVPED/EhckKi+qaFkjKvu 7KrbAFCu0rJRrC5AAzQKB48KNWFnB+0ki+ej28Qt3MaDvpshwsiH9VLW4Dlx/SrRbnq2 30NuMAQbGCXzIdsalSR9kZ9+5MTWWyLC0K2Slvf32CcPElh2YV6D532BOo+8W3t+mXfz /rYdiZKjkr/4qpgI76fwgc5D7Lv33nRGc5X+d2Jg88EQZNPXkIjVJvRKTVO9+h6WBD73 oOnQ== X-Gm-Message-State: ANoB5plLLRxID6KTp6+6o2cTPI74pn86sxVdqm4L0KLURDOpUQYa+8F+ AVrSd63AUVdrQmzm3qLMhSv8uA== X-Google-Smtp-Source: AA0mqf4vdFElVVd26hcrflnM3jwAKdLRue0OvT56EcJoe77rqn9gFdAxg0vHma8xxGawZfkoLjfBgg== X-Received: by 2002:a05:651c:b0f:b0:277:ba3:ca71 with SMTP id b15-20020a05651c0b0f00b002770ba3ca71mr9097106ljr.146.1669237543343; Wed, 23 Nov 2022 13:05:43 -0800 (PST) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id 6-20020ac25f06000000b004a91d1b3070sm241096lfq.308.2022.11.23.13.05.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Nov 2022 13:05:42 -0800 (PST) Message-ID: Date: Wed, 23 Nov 2022 23:05:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] drm/msm/disp/dpu1: add support for display on SM6115 Content-Language: en-GB From: Dmitry Baryshkov To: Adam Skladowski Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Kalyan Thota , Jessica Zhang , AngeloGioacchino Del Regno , Loic Poulain , Adam Skladowski , Stephen Boyd , Jason Wang , Vinod Polimera , Vinod Koul , Douglas Anderson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221120133744.24808-1-a39.skl@gmail.com> <20221120133744.24808-3-a39.skl@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23/11/2022 01:54, Dmitry Baryshkov wrote: > On 20/11/2022 15:37, Adam Skladowski wrote: >> Add required display hw catalog changes for SM6115. >> >> Signed-off-by: Adam Skladowski >> --- >>   .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c    | 87 +++++++++++++++++++ >>   .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h    |  1 + >>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |  1 + >>   drivers/gpu/drm/msm/msm_mdss.c                |  5 ++ >>   4 files changed, 94 insertions(+) >> > > [skipped] > >> diff --git a/drivers/gpu/drm/msm/msm_mdss.c >> b/drivers/gpu/drm/msm/msm_mdss.c >> index 6a4549ef34d4..86b28add1fff 100644 >> --- a/drivers/gpu/drm/msm/msm_mdss.c >> +++ b/drivers/gpu/drm/msm/msm_mdss.c >> @@ -280,6 +280,10 @@ static int msm_mdss_enable(struct msm_mdss >> *msm_mdss) >>           /* UBWC_2_0 */ >>           msm_mdss_setup_ubwc_dec_20(msm_mdss, 0x1e); >>           break; >> +    case DPU_HW_VER_630: >> +        /* UBWC_2_0 */ >> +        msm_mdss_setup_ubwc_dec_20(msm_mdss, 0x11f); >> +        break; > > According to the vendor dtsi the sm6115 is UBWC 1.0, not 2.0 > > Could you please doublecheck? > > Looks good to me otherwise. After doublechecking: Reviewed-by: Dmitry Baryshkov > >>       case DPU_HW_VER_720: >>           msm_mdss_setup_ubwc_dec_40(msm_mdss, UBWC_3_0, 6, 1, 1, 1); >>           break; >> @@ -509,6 +513,7 @@ static const struct of_device_id mdss_dt_match[] = { >>       { .compatible = "qcom,sc7180-mdss" }, >>       { .compatible = "qcom,sc7280-mdss" }, >>       { .compatible = "qcom,sc8180x-mdss" }, >> +    { .compatible = "qcom,sm6115-mdss" }, >>       { .compatible = "qcom,sm8150-mdss" }, >>       { .compatible = "qcom,sm8250-mdss" }, >>       {} > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1FAFC4332F for ; Wed, 23 Nov 2022 21:05:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B3FD10E62F; Wed, 23 Nov 2022 21:05:51 +0000 (UTC) Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB86A10E630 for ; Wed, 23 Nov 2022 21:05:44 +0000 (UTC) Received: by mail-lj1-x232.google.com with SMTP id a15so22741033ljb.7 for ; Wed, 23 Nov 2022 13:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dzqt331g8T68TbUv6sgzKml0DHljiiwCg07CtnYVk1Q=; b=rdQUXwcIP0uEWh7Ulyhf+ky26BtMT19RFWwVxD33CSMIhC7n8iasJ+6WnsStWbiXxR /NLZCPKKcYPaYV0VIQqmFRXFsEqXhHsMvfquefe89IdzwtezCPskcFJMLWu81RllkmtH xe1TMNwABc2QWkw7JDNigKcjKX8uE8dPc69sqZNkNqFZCE3wtn6TMSknX3leib+edtnz dStnp+uThASYAQTfly6odXol9Co5iXJTMoxwKt2w2Zec66aHBHHNlvfwTGbg/wnqGgcL E/9TI/cKucsMIZLCArdgG5BeKCHsyh3iLwx/kJOgFX4zxrItqr1hbf/KFX18i8lqYQEP SHPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dzqt331g8T68TbUv6sgzKml0DHljiiwCg07CtnYVk1Q=; b=b/lVuCaDoM5hszteeIYl5aJ68tKSsHjAPTMr5Un1p0RQ36MgCGCh5fx0FW9SVzt6Sv SmSi4xwUrSoO+cMMafu4yH9PGj/fdQfDLVDqMZVPtM7HLvxuSdqFPbZdpIOtGQGoO2Hz RIWSwcr9do9E+/iWxdiUeu115t8J4Xy+IALXOEBLBylpvSBLqdi7maRX+zH0bO+gGWJd Ky7sy+1txB39On2MO8dI1TC9oWG92yJp8ZGgqMGkuZLShGQgDbFoTqyQ7Ujq80+9FqMJ tflChG4GabTf6Iq/4uX1GZ7z0zaCNURjmCPn7r60q/Jnisd/jPkzWc3g8rlVLOjdKpGV yA9g== X-Gm-Message-State: ANoB5pnVvhTHOlVcIQ7KFtS8pakvrnZ77FJY2fyzt+gJEDv9AELq6JDe iDjD0Fl8U9EuyTMNabep3eUmgg== X-Google-Smtp-Source: AA0mqf4vdFElVVd26hcrflnM3jwAKdLRue0OvT56EcJoe77rqn9gFdAxg0vHma8xxGawZfkoLjfBgg== X-Received: by 2002:a05:651c:b0f:b0:277:ba3:ca71 with SMTP id b15-20020a05651c0b0f00b002770ba3ca71mr9097106ljr.146.1669237543343; Wed, 23 Nov 2022 13:05:43 -0800 (PST) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id 6-20020ac25f06000000b004a91d1b3070sm241096lfq.308.2022.11.23.13.05.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Nov 2022 13:05:42 -0800 (PST) Message-ID: Date: Wed, 23 Nov 2022 23:05:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] drm/msm/disp/dpu1: add support for display on SM6115 Content-Language: en-GB From: Dmitry Baryshkov To: Adam Skladowski References: <20221120133744.24808-1-a39.skl@gmail.com> <20221120133744.24808-3-a39.skl@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , AngeloGioacchino Del Regno , phone-devel@vger.kernel.org, Adam Skladowski , Vinod Polimera , Jessica Zhang , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Stephen Boyd , Rob Herring , Jason Wang , Sean Paul , Kalyan Thota , Loic Poulain , Douglas Anderson , Vinod Koul , freedreno@lists.freedesktop.org, ~postmarketos/upstreaming@lists.sr.ht Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 23/11/2022 01:54, Dmitry Baryshkov wrote: > On 20/11/2022 15:37, Adam Skladowski wrote: >> Add required display hw catalog changes for SM6115. >> >> Signed-off-by: Adam Skladowski >> --- >>   .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c    | 87 +++++++++++++++++++ >>   .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h    |  1 + >>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |  1 + >>   drivers/gpu/drm/msm/msm_mdss.c                |  5 ++ >>   4 files changed, 94 insertions(+) >> > > [skipped] > >> diff --git a/drivers/gpu/drm/msm/msm_mdss.c >> b/drivers/gpu/drm/msm/msm_mdss.c >> index 6a4549ef34d4..86b28add1fff 100644 >> --- a/drivers/gpu/drm/msm/msm_mdss.c >> +++ b/drivers/gpu/drm/msm/msm_mdss.c >> @@ -280,6 +280,10 @@ static int msm_mdss_enable(struct msm_mdss >> *msm_mdss) >>           /* UBWC_2_0 */ >>           msm_mdss_setup_ubwc_dec_20(msm_mdss, 0x1e); >>           break; >> +    case DPU_HW_VER_630: >> +        /* UBWC_2_0 */ >> +        msm_mdss_setup_ubwc_dec_20(msm_mdss, 0x11f); >> +        break; > > According to the vendor dtsi the sm6115 is UBWC 1.0, not 2.0 > > Could you please doublecheck? > > Looks good to me otherwise. After doublechecking: Reviewed-by: Dmitry Baryshkov > >>       case DPU_HW_VER_720: >>           msm_mdss_setup_ubwc_dec_40(msm_mdss, UBWC_3_0, 6, 1, 1, 1); >>           break; >> @@ -509,6 +513,7 @@ static const struct of_device_id mdss_dt_match[] = { >>       { .compatible = "qcom,sc7180-mdss" }, >>       { .compatible = "qcom,sc7280-mdss" }, >>       { .compatible = "qcom,sc8180x-mdss" }, >> +    { .compatible = "qcom,sm6115-mdss" }, >>       { .compatible = "qcom,sm8150-mdss" }, >>       { .compatible = "qcom,sm8250-mdss" }, >>       {} > -- With best wishes Dmitry