From: Nirmoy <nirmodas@amd.com>
To: Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu/ttm: fix ifdefs for non-x86
Date: Mon, 15 Mar 2021 20:49:28 +0100 [thread overview]
Message-ID: <ab9ce605-b09f-1030-c506-0778329ec77d@amd.com> (raw)
In-Reply-To: <20210315193841.1539753-1-alexander.deucher@amd.com>
Reviewed-by: Nirmoy Das <nirmoy.das@amd.com>
On 3/15/21 8:38 PM, Alex Deucher wrote:
> The else clause needs to be CONFIG_64BIT not CONFIG_X86.
>
> Fixes: e98f250bddb5 ("drm/amdgpu: fix compile error on architecture s390")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 158c987696ff..6d5cf0525325 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -1731,12 +1731,14 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)
>
> /* Change the size here instead of the init above so only lpfn is affected */
> amdgpu_ttm_set_buffer_funcs_status(adev, false);
> +#ifdef CONFIG_64BIT
> #ifdef CONFIG_X86
> if (adev->gmc.xgmi.connected_to_cpu)
> adev->mman.aper_base_kaddr = ioremap_cache(adev->gmc.aper_base,
> adev->gmc.visible_vram_size);
>
> else
> +#endif
> adev->mman.aper_base_kaddr = ioremap_wc(adev->gmc.aper_base,
> adev->gmc.visible_vram_size);
> #endif
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-03-15 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 19:38 [PATCH] drm/amdgpu/ttm: fix ifdefs for non-x86 Alex Deucher
2021-03-15 19:49 ` Nirmoy [this message]
2021-03-15 20:56 ` Zeng, Oak
2021-03-16 7:34 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab9ce605-b09f-1030-c506-0778329ec77d@amd.com \
--to=nirmodas@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.