Re: [PATCH 3/7] ethdev: separate driver APIs

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 12/1/2017 12:59 AM, Hemant Agrawal wrote:
> On 12/1/2017 7:59 AM, Ferruh Yigit wrote:
> 
> <snip>...
>> diff --git a/lib/librte_ether/rte_ethdev_driver.h b/lib/librte_ether/rte_ethdev_driver.h
>> new file mode 100644
>> index 000000000..3e77d1439
>> --- /dev/null
>> +++ b/lib/librte_ether/rte_ethdev_driver.h
>> @@ -0,0 +1,163 @@
>> +/*-
>> + *   BSD LICENSE
>> + *
>> + *   Copyright(c) 2017 Intel Corporation. All rights reserved.
>> + *   All rights reserved.
> 
> You can remove one of the all rights reserved.
> This is also an issue in your next patch for rte_ethdev_core.h
> 
> Also, as Shreyansh mentioned, Why not start with SPDX tags instead of 
> full license text?

Good idea, I will update in next version.

> 
> <snip>...
>> +/**
>> + * @internal Executes all the user application registered callbacks for
>> + * the specific device. It is for DPDK internal user only. User
>> + * application should not call it directly.
>> + *
>> + * @param dev
>> + *  Pointer to struct rte_eth_dev.
>> + * @param event
>> + *  Eth device interrupt event type.
>> + * @param cb_arg
>> + *  callback parameter.
>> + * @param ret_param
>> + *  To pass data back to user application.
>> + *  This allows the user application to decide if a particular function
>> + *  is permitted or not.
>> + *
>> + * @return
>> + *  int
>> + */
>> +int _rte_eth_dev_callback_process(struct rte_eth_dev *dev,
>> +		enum rte_eth_event_type event, void *cb_arg, void *ret_param);
>> +
>> +/**
>> + * Create memzone for HW rings.
> 
> Like all other functions, you can also add "@internal" for this as well.

OK.

> 
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>