From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 917B6C636C8 for ; Fri, 16 Jul 2021 01:17:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A1D3613DF for ; Fri, 16 Jul 2021 01:17:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbhGPBUA (ORCPT ); Thu, 15 Jul 2021 21:20:00 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:7020 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbhGPBT7 (ORCPT ); Thu, 15 Jul 2021 21:19:59 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GQtVM0LC2zXdsl; Fri, 16 Jul 2021 09:11:23 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 16 Jul 2021 09:17:03 +0800 Received: from [10.174.179.0] (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 16 Jul 2021 09:17:02 +0800 Subject: Re: [PATCH] pinctrl: single: Fix error return code in pcs_parse_bits_in_pinctrl_entry() To: "weiyongjun (A)" , Tony Lindgren , Haojian Zhuang , Linus Walleij , Manjunathappa Prakash , linux-arm-kernel , linux-omap , linux-gpio , linux-kernel References: <20210715064206.3193-1-thunder.leizhen@huawei.com> <55d02087-e2c7-9a0c-e20e-ff6f106703a3@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Fri, 16 Jul 2021 09:17:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <55d02087-e2c7-9a0c-e20e-ff6f106703a3@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 2021/7/15 19:49, weiyongjun (A) wrote: >> Fix to return -ENOTSUPP instead of 0 when PCS_HAS_PINCONF is true, which >> is the same as that returned in pcs_parse_pinconf(). >> >> In addition, I found the value of pcs->flags is not overwritten in >> pcs_parse_bits_in_pinctrl_entry() and its subfunctions, so moving this >> check to the beginning of the function eliminates unnecessary rollback >> operations. >> >> Fixes: 4e7e8017a80e ("pinctrl: pinctrl-single: enhance to configure multiple pins of different modules") >> Reported-by: Hulk Robot >> Signed-off-by: Zhen Lei >> --- >>   drivers/pinctrl/pinctrl-single.c | 21 ++++++++------------- >>   1 file changed, 8 insertions(+), 13 deletions(-) >> >> >>       npins_in_row = pcs->width / pcs->bits_per_pin; >>         vals = devm_kzalloc(pcs->dev, >> @@ -1212,29 +1217,19 @@ static int pcs_parse_bits_in_pinctrl_entry(struct pcs_device *pcs, >>           goto free_pins; >>       } >>   -    gsel = pinctrl_generic_add_group(pcs->pctl, np->name, pins, found, pcs); >> -    if (gsel < 0) { >> -        res = gsel; >> +    res = pinctrl_generic_add_group(pcs->pctl, np->name, pins, found, pcs); >> +    if (res < 0) >>           goto free_function; >> -    } > > > This change cause 'gsel' not set. The local variable 'gsel' is no longer needed. I have deleted it. > > Do not mix this cleanup with bugfix. Yes, it might be clearer. > > > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F54C636C8 for ; Fri, 16 Jul 2021 01:18:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B23F613DC for ; Fri, 16 Jul 2021 01:18:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B23F613DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=YzZ2FszPTLnjZEBYJ6xBNqi9/33fj+fVpN5gOjpjdqE=; b=AyBFoUu+qIHoZX/I/weQKvXFKm FtVFXdRnPsc9aWiWbvFVt5rDNCcU9I1VpKfxYKk6txNt5yMyC3la0TIJ+ixm5BjbJojOl2ThHEYk4 BLgM5S87sP8inwNeRSZIU63c05XehP384Y2HO3TYjmKDXl102s4CUE7k+2esgusrHytkkNSkF7DPh QkxJvqZKmcfu8yqDIFMYD3YHQ6jq0TWeoZ/hEgYnx7V/RdzI9MYAafMeQRvHzS6iiLk2jZ/OmjMAt iCBQHRyxnk3XNq5DbuWF4JdxhgCYqduSCG2A4SWn3afU3/rIq8Qw1REbwMUECRsVzPEW/r4GA/cxC bjjA9c9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4CTW-002oRX-O7; Fri, 16 Jul 2021 01:17:10 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4CTS-002oR1-SF for linux-arm-kernel@lists.infradead.org; Fri, 16 Jul 2021 01:17:08 +0000 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GQtVM0LC2zXdsl; Fri, 16 Jul 2021 09:11:23 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 16 Jul 2021 09:17:03 +0800 Received: from [10.174.179.0] (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 16 Jul 2021 09:17:02 +0800 Subject: Re: [PATCH] pinctrl: single: Fix error return code in pcs_parse_bits_in_pinctrl_entry() To: "weiyongjun (A)" , Tony Lindgren , Haojian Zhuang , Linus Walleij , Manjunathappa Prakash , linux-arm-kernel , linux-omap , linux-gpio , linux-kernel References: <20210715064206.3193-1-thunder.leizhen@huawei.com> <55d02087-e2c7-9a0c-e20e-ff6f106703a3@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Fri, 16 Jul 2021 09:17:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <55d02087-e2c7-9a0c-e20e-ff6f106703a3@huawei.com> Content-Language: en-US X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210715_181707_223596_7022A79D X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIxLzcvMTUgMTk6NDksIHdlaXlvbmdqdW4gKEEpIHdyb3RlOgo+PiBGaXggdG8gcmV0 dXJuIC1FTk9UU1VQUCBpbnN0ZWFkIG9mIDAgd2hlbiBQQ1NfSEFTX1BJTkNPTkYgaXMgdHJ1ZSwg d2hpY2gKPj4gaXMgdGhlIHNhbWUgYXMgdGhhdCByZXR1cm5lZCBpbiBwY3NfcGFyc2VfcGluY29u ZigpLgo+Pgo+PiBJbiBhZGRpdGlvbiwgSSBmb3VuZCB0aGUgdmFsdWUgb2YgcGNzLT5mbGFncyBp cyBub3Qgb3ZlcndyaXR0ZW4gaW4KPj4gcGNzX3BhcnNlX2JpdHNfaW5fcGluY3RybF9lbnRyeSgp IGFuZCBpdHMgc3ViZnVuY3Rpb25zLCBzbyBtb3ZpbmcgdGhpcwo+PiBjaGVjayB0byB0aGUgYmVn aW5uaW5nIG9mIHRoZSBmdW5jdGlvbiBlbGltaW5hdGVzIHVubmVjZXNzYXJ5IHJvbGxiYWNrCj4+ IG9wZXJhdGlvbnMuCj4+Cj4+IEZpeGVzOiA0ZTdlODAxN2E4MGUgKCJwaW5jdHJsOiBwaW5jdHJs LXNpbmdsZTogZW5oYW5jZSB0byBjb25maWd1cmUgbXVsdGlwbGUgcGlucyBvZiBkaWZmZXJlbnQg bW9kdWxlcyIpCj4+IFJlcG9ydGVkLWJ5OiBIdWxrIFJvYm90IDxodWxrY2lAaHVhd2VpLmNvbT4K Pj4gU2lnbmVkLW9mZi1ieTogWmhlbiBMZWkgPHRodW5kZXIubGVpemhlbkBodWF3ZWkuY29tPgo+ PiAtLS0KPj4gwqAgZHJpdmVycy9waW5jdHJsL3BpbmN0cmwtc2luZ2xlLmMgfCAyMSArKysrKysr Ky0tLS0tLS0tLS0tLS0KPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMTMg ZGVsZXRpb25zKC0pCj4+Cj4+Cj4+IMKgwqDCoMKgwqAgbnBpbnNfaW5fcm93ID0gcGNzLT53aWR0 aCAvIHBjcy0+Yml0c19wZXJfcGluOwo+PiDCoCDCoMKgwqDCoMKgIHZhbHMgPSBkZXZtX2t6YWxs b2MocGNzLT5kZXYsCj4+IEBAIC0xMjEyLDI5ICsxMjE3LDE5IEBAIHN0YXRpYyBpbnQgcGNzX3Bh cnNlX2JpdHNfaW5fcGluY3RybF9lbnRyeShzdHJ1Y3QgcGNzX2RldmljZSAqcGNzLAo+PiDCoMKg wqDCoMKgwqDCoMKgwqAgZ290byBmcmVlX3BpbnM7Cj4+IMKgwqDCoMKgwqAgfQo+PiDCoCAtwqDC oMKgIGdzZWwgPSBwaW5jdHJsX2dlbmVyaWNfYWRkX2dyb3VwKHBjcy0+cGN0bCwgbnAtPm5hbWUs IHBpbnMsIGZvdW5kLCBwY3MpOwo+PiAtwqDCoMKgIGlmIChnc2VsIDwgMCkgewo+PiAtwqDCoMKg wqDCoMKgwqAgcmVzID0gZ3NlbDsKPj4gK8KgwqDCoCByZXMgPSBwaW5jdHJsX2dlbmVyaWNfYWRk X2dyb3VwKHBjcy0+cGN0bCwgbnAtPm5hbWUsIHBpbnMsIGZvdW5kLCBwY3MpOwo+PiArwqDCoMKg IGlmIChyZXMgPCAwKQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBmcmVlX2Z1bmN0aW9uOwo+ PiAtwqDCoMKgIH0KPiAKPiAKPiBUaGlzIGNoYW5nZSBjYXVzZSAnZ3NlbCcgbm90IHNldC4KClRo ZSBsb2NhbCB2YXJpYWJsZSAnZ3NlbCcgaXMgbm8gbG9uZ2VyIG5lZWRlZC4gSSBoYXZlIGRlbGV0 ZWQgaXQuCgo+IAo+IERvIG5vdCBtaXggdGhpcyBjbGVhbnVwIHdpdGggYnVnZml4LgoKWWVzLCBp dCBtaWdodCBiZSBjbGVhcmVyLgoKPiAKPiAKPiAKPiAuCj4gCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==