From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B88C433FF for ; Wed, 7 Aug 2019 21:30:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D22862186A for ; Wed, 7 Aug 2019 21:30:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="c1vU6F8r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389310AbfHGVav (ORCPT ); Wed, 7 Aug 2019 17:30:51 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:53578 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730138AbfHGVau (ORCPT ); Wed, 7 Aug 2019 17:30:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PbeeDf/GkbDllO5vIZWwH/vN3+gHBbe2/YYojgAimx0=; b=c1vU6F8rZNn+E3ApTlYjsvg1P Ug4PoVhpJ6YWH6IEnG7+O7qR1NIUhBCqAySSXTzxbt5hvW9DtMLOoyCUzUrY4WwIwVsh9H/Ueojp4 6xGNrTEAoO2LcDdtWlRLRwgSWR2Eptx/O3w2c5wf9JC4HyCgeSJ/VVRUXP7hZlMpsZSdSD51+2bXg bvhUYBtIFDXPkAAWOT0ZUDCp2VSLsrKMertexpLx9gT8tIUBVeiFAzn9/tLZDCXwuClStkXHPajGO ck5MvJ8MnbVvObac5sJ6W6f1YbrobQWfaergG4OR+FEeBbcsRR7aKBXZwoXDZ291YZ2rweUV1labv U32+ixQuQ==; Received: from [208.71.200.96] (helo=[172.16.195.104]) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hvTWD-0004Yw-VZ; Wed, 07 Aug 2019 21:30:50 +0000 Subject: Re: linux-next: Tree for Aug 7 (mm/khugepaged.c) To: Andrew Morton , Song Liu Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Linux MM References: <20190807183606.372ca1a4@canb.auug.org.au> <20190807131029.f7f191aaeeb88cc435c6306f@linux-foundation.org> <20190807142755.8211d58d5ecec8082587b073@linux-foundation.org> From: Randy Dunlap Message-ID: Date: Wed, 7 Aug 2019 14:30:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190807142755.8211d58d5ecec8082587b073@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/7/19 2:27 PM, Andrew Morton wrote: > On Wed, 7 Aug 2019 21:00:04 +0000 Song Liu wrote: > >>>> >>>> Shall I resend the patch, or shall I send fix on top of current patch? >>> >>> Either is OK. If the difference is small I will turn it into an >>> incremental patch so that I (and others) can see what changed. >> >> Please find the patch to fix this at the end of this email. It applies >> right on top of "khugepaged: enable collapse pmd for pte-mapped THP". >> It may conflict a little with the "Enable THP for text section of >> non-shmem files" set, which renames function khugepaged_scan_shmem(). >> >> Also, I found v3 of the set in linux-next. The latest is v4: >> >> https://lkml.org/lkml/2019/8/2/1587 >> https://lkml.org/lkml/2019/8/2/1588 >> https://lkml.org/lkml/2019/8/2/1589 > > It's all a bit confusing. I'll drop > > mm-move-memcmp_pages-and-pages_identical.patch > uprobe-use-original-page-when-all-uprobes-are-removed.patch > uprobe-use-original-page-when-all-uprobes-are-removed-v2.patch > mm-thp-introduce-foll_split_pmd.patch > mm-thp-introduce-foll_split_pmd-v11.patch > uprobe-use-foll_split_pmd-instead-of-foll_split.patch > khugepaged-enable-collapse-pmd-for-pte-mapped-thp.patch > uprobe-collapse-thp-pmd-after-removing-all-uprobes.patch > > Please resolve Oleg's review comments and resend everything. > OK, that will take care of the build error that I am still seeing when SHMEM is not enabled: ../mm/khugepaged.c:1849:2: note: in expansion of macro ‘BUILD_BUG’ BUILD_BUG(); ^~~~~~~~~ -- ~Randy