From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCHv4 3/5] Makefiles: Add experimental tag check
 and warnings to trigger on use
Date: Thu, 11 Jan 2018 20:06:43 +0000
Message-ID: <abb993bc-aa9f-7b4e-809f-8ab36b218735@intel.com>
References: <20171201185628.16261-1-nhorman@tuxdriver.com>
 <20171213151728.16747-1-nhorman@tuxdriver.com>
 <20171213151728.16747-4-nhorman@tuxdriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: thomas@monjalon.net, john.mcnamara@intel.com, bruce.richardson@intel.com
To: Neil Horman <nhorman@tuxdriver.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 8829BA493
 for <dev@dpdk.org>; Thu, 11 Jan 2018 21:06:46 +0100 (CET)
In-Reply-To: <20171213151728.16747-4-nhorman@tuxdriver.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/13/2017 3:17 PM, Neil Horman wrote:
> Add checks during build to ensure that all symbols in the EXPERIMENTAL
> version map section have __experimental tags on their definitions, and
> enable the warnings needed to announce their use.  Also add an
> ALLOW_EXPERIMENTAL_APIS define to allow individual libraries and files
> to declare the acceptability of experimental api usage
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Thomas Monjalon <thomas@monjalon.net>
> CC: "Mcnamara, John" <john.mcnamara@intel.com>
> CC: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  app/test-eventdev/Makefile                 | 1 +
>  app/test-pmd/Makefile                      | 1 +
>  drivers/event/sw/Makefile                  | 1 +
>  drivers/net/failsafe/Makefile              | 1 +
>  drivers/net/ixgbe/Makefile                 | 1 +
>  examples/eventdev_pipeline_sw_pmd/Makefile | 1 +
>  examples/flow_classify/Makefile            | 1 +
>  examples/ipsec-secgw/Makefile              | 1 +
>  examples/service_cores/Makefile            | 1 +
>  lib/librte_eal/bsdapp/eal/Makefile         | 1 +
>  lib/librte_eal/linuxapp/Makefile           | 2 ++
>  lib/librte_eal/linuxapp/eal/Makefile       | 2 ++
>  lib/librte_eventdev/Makefile               | 1 +
>  lib/librte_security/Makefile               | 1 +
>  mk/internal/rte.compile-pre.mk             | 4 ++++
>  mk/toolchain/clang/rte.vars.mk             | 2 +-
>  mk/toolchain/gcc/rte.vars.mk               | 2 +-
>  mk/toolchain/icc/rte.vars.mk               | 2 +-
>  18 files changed, 23 insertions(+), 3 deletions(-)
> 
> diff --git a/app/test-eventdev/Makefile b/app/test-eventdev/Makefile
> index dcb2ac476..78bae7633 100644
> --- a/app/test-eventdev/Makefile
> +++ b/app/test-eventdev/Makefile
> @@ -32,6 +32,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
>  
>  APP = dpdk-test-eventdev
>  
> +CFLAGS += -DALLOW_EXPERIMENTAL_APIS

Do we need this internally in DPDK? For application developers this is great,
they will get warning unless explicitly stated that they are OK with it.

Do we have any option than allowing them in DPDK library? And when experimental
API modified the users in the DPDK library internally guaranteed to be updated.
Why not globally allow this for all DPDK internally?

>  CFLAGS += -O3
>  CFLAGS += $(WERROR_FLAGS)
>  

<...>