From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9119C4332F for ; Tue, 29 Nov 2022 09:15:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 900E310E05E; Tue, 29 Nov 2022 09:15:28 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67D7410E05E for ; Tue, 29 Nov 2022 09:15:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669713326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=OvXTU6p0Ct0GG3VEsw6AOZSjwusuY/Ng6cuNku1asLSrx9F6Mc66uLvd7qxMRAZbOAL+J5 Q8DdnyjmltiPLfDTqjLE3SaozLtbjrW5pWS5w+X7WF2iZ/48KkE540YFRqNv9Zfo0kmyyh pze47cOZYmn8QXjChvz5wyc79I3BaI4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-458-rJl4IrXdNfqSv0Z33Oooig-1; Tue, 29 Nov 2022 04:15:24 -0500 X-MC-Unique: rJl4IrXdNfqSv0Z33Oooig-1 Received: by mail-wr1-f72.google.com with SMTP id e7-20020adf9bc7000000b00242121eebe2so1498648wrc.3 for ; Tue, 29 Nov 2022 01:15:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=lOuGXumsz+te9nbsmOmttXKkvL/+e16rre7jIRV4R6sbHRpQkmV/ILaPxnEggpbWlK O4CNntKf0yK3X94WM+UsUr4yY6GatUCUBsgBpqciNi2vI+faBm+hFCx6CEvMiqppRcCZ fxoCbJx6Kv+jFwHlAQL0Z46/EL/JmEQZvFDrMY7IpAjbKvsoSaYtnBoEKl6UlNnEt5R7 vqhshLDNd7KaBiGPhMNArulzaiwGWEpMwCZDCPIFECVi9Xpgop1dMIVpX5QAEv93iupN hrihmn4o2rB0O08bBZIFZxaQpuVGzWIJEiyuXbnMyLVHUPLYpxJGeIEagBbNLpaVHknG bv2Q== X-Gm-Message-State: ANoB5pm6H+lByBE+YHfF6nDoaITkD6S23fNkwUexYEh8dlKVw6/LW6gp /UwSUgadsSagFKU6z7o9ZJB82rMboMkBNkPrKt7nu3uD4Eq4B3kpljKi+YlLVkpyrk+i7UJHkUF afZ0UJ5AXFF85FLtASa2sLSpjtd2X X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243418wme.140.1669713323597; Tue, 29 Nov 2022 01:15:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf5aMoFyhfTZRz6WGw0GcgDkcONZAiRyZAh+e0PFHXmVnEtFtgvwKaxuOXbIxhdoVgI1OB8H+Q== X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243382wme.140.1669713323266; Tue, 29 Nov 2022 01:15:23 -0800 (PST) Received: from ?IPV6:2003:cb:c705:ca00:3fb8:c253:3bf7:b60e? (p200300cbc705ca003fb8c2533bf7b60e.dip0.t-ipconnect.de. [2003:cb:c705:ca00:3fb8:c253:3bf7:b60e]) by smtp.gmail.com with ESMTPSA id n26-20020a05600c3b9a00b003c6b70a4d69sm1498998wms.42.2022.11.29.01.15.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 01:15:22 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 10:15:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: Hans Verkuil , Andrew Morton References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> <20221128145927.df895bf1966cfa125cae9668@linux-foundation.org> <22b1107b-0acc-5772-a883-8f3c4682eb1b@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nadav Amit , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Shuah Khan , Marek Szyprowski , Andrea Arcangeli , linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, x86@kernel.org, Hugh Dickins , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , linux-media@vger.kernel.org, Arnd Bergmann , John Hubbard , linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, Alex Williamson , Peter Xu , Muchun Song , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Oded Gabbay , linux-mips@vger.kernel.org, Tomasz Figa , linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linus Torvalds , Mike Kravetz Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 29.11.22 10:08, Hans Verkuil wrote: > On 29/11/2022 09:48, David Hildenbrand wrote: >> On 28.11.22 23:59, Andrew Morton wrote: >>> On Mon, 28 Nov 2022 09:18:47 +0100 David Hildenbrand wrote: >>> >>>>> Less chances of things going wrong that way. >>>>> >>>>> Just mention in the v2 cover letter that the first patch was added to >>>>> make it easy to backport that fix without being hampered by merge >>>>> conflicts if it was added after your frame_vector.c patch. >>>> >>>> Yes, that's the way I would naturally do, it, however, Andrew prefers >>>> delta updates for minor changes. >>>> >>>> @Andrew, whatever you prefer! >>> >>> I'm inclined to let things sit as they are.  Cross-tree conflicts >>> happen, and Linus handles them.  I'll flag this (very simple) conflict >>> in the pull request, if MM merges second.  If v4l merges second then >>> hopefully they will do the same.  But this one is so simple that Linus >>> hardly needs our help. > > It's not about cross-tree conflicts, it's about the fact that my patch is > a fix that needs to be backported to older kernels. It should apply cleanly > to those older kernels if my patch goes in first, but if it is the other way > around I would have to make a new patch for the stable kernels. IIUC, the conflict will be resolved at merge time and the merge resolution will be part of the merge commit. It doesn't matter in which order the patches go upstream, the merge commit resolves the problematic overlap. So your patch will be upstream as intended, where it can be cleanly backported. Hope I am not twisting reality ;) -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1698AC46467 for ; Tue, 29 Nov 2022 09:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229865AbiK2JQV (ORCPT ); Tue, 29 Nov 2022 04:16:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiK2JQU (ORCPT ); Tue, 29 Nov 2022 04:16:20 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFA4C4FFB4 for ; Tue, 29 Nov 2022 01:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669713326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=OvXTU6p0Ct0GG3VEsw6AOZSjwusuY/Ng6cuNku1asLSrx9F6Mc66uLvd7qxMRAZbOAL+J5 Q8DdnyjmltiPLfDTqjLE3SaozLtbjrW5pWS5w+X7WF2iZ/48KkE540YFRqNv9Zfo0kmyyh pze47cOZYmn8QXjChvz5wyc79I3BaI4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-458-u6luOVZMOPWkRvanHe-qEw-1; Tue, 29 Nov 2022 04:15:24 -0500 X-MC-Unique: u6luOVZMOPWkRvanHe-qEw-1 Received: by mail-wr1-f72.google.com with SMTP id l8-20020adfc788000000b00241ef50e89eso2650576wrg.0 for ; Tue, 29 Nov 2022 01:15:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=QvJrohpu480OiddtX+C1CXjGQPcqHnK0+soDAMuhwou98cRHxDdYStpJMGEyFywGyC qMhZ0KsM4e29jLBi8jnTj4xZlT9qk3MJQ2OvqbrvrjK/IYq11tZ4zeqXKWtf4WydDILZ oL8JmcnlxQv9g5OW0wdowM95d5LaexZjG8d0LKGRhviySOaoZj4V9x+/PhPuN+hi/b+f z270nMMp5DYlNV1VKn9v2O6u0gT1a91pGwjd0BYre6uRKewu4yfdK0fuYNdySmmrwKYr FgRGNiwzLguI5DsUFezFLwW2e4Mpm9Q6htxkI17Gu+MAqa1hWSV7O9En71RKOvSQWOqw QLvw== X-Gm-Message-State: ANoB5pl8eUYvC8QuP+b4/e8OVt+kwTM+dgtapX4FNX39uZHCVfLU9uQq rAEGeSAHJveZDSjf17tHKIqHYdxfUEyMV1A0E1jhphIh01/3swDGM92IVaq1Mv8ibQY7jQfH6RX kOcsSaQu08Vssq6t24p4LhQ== X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243410wme.140.1669713323598; Tue, 29 Nov 2022 01:15:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf5aMoFyhfTZRz6WGw0GcgDkcONZAiRyZAh+e0PFHXmVnEtFtgvwKaxuOXbIxhdoVgI1OB8H+Q== X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243382wme.140.1669713323266; Tue, 29 Nov 2022 01:15:23 -0800 (PST) Received: from ?IPV6:2003:cb:c705:ca00:3fb8:c253:3bf7:b60e? (p200300cbc705ca003fb8c2533bf7b60e.dip0.t-ipconnect.de. [2003:cb:c705:ca00:3fb8:c253:3bf7:b60e]) by smtp.gmail.com with ESMTPSA id n26-20020a05600c3b9a00b003c6b70a4d69sm1498998wms.42.2022.11.29.01.15.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 01:15:22 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 10:15:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage Content-Language: en-US To: Hans Verkuil , Andrew Morton Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Tomasz Figa , Mauro Carvalho Chehab References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> <20221128145927.df895bf1966cfa125cae9668@linux-foundation.org> <22b1107b-0acc-5772-a883-8f3c4682eb1b@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 29.11.22 10:08, Hans Verkuil wrote: > On 29/11/2022 09:48, David Hildenbrand wrote: >> On 28.11.22 23:59, Andrew Morton wrote: >>> On Mon, 28 Nov 2022 09:18:47 +0100 David Hildenbrand wrote: >>> >>>>> Less chances of things going wrong that way. >>>>> >>>>> Just mention in the v2 cover letter that the first patch was added to >>>>> make it easy to backport that fix without being hampered by merge >>>>> conflicts if it was added after your frame_vector.c patch. >>>> >>>> Yes, that's the way I would naturally do, it, however, Andrew prefers >>>> delta updates for minor changes. >>>> >>>> @Andrew, whatever you prefer! >>> >>> I'm inclined to let things sit as they are.  Cross-tree conflicts >>> happen, and Linus handles them.  I'll flag this (very simple) conflict >>> in the pull request, if MM merges second.  If v4l merges second then >>> hopefully they will do the same.  But this one is so simple that Linus >>> hardly needs our help. > > It's not about cross-tree conflicts, it's about the fact that my patch is > a fix that needs to be backported to older kernels. It should apply cleanly > to those older kernels if my patch goes in first, but if it is the other way > around I would have to make a new patch for the stable kernels. IIUC, the conflict will be resolved at merge time and the merge resolution will be part of the merge commit. It doesn't matter in which order the patches go upstream, the merge commit resolves the problematic overlap. So your patch will be upstream as intended, where it can be cleanly backported. Hope I am not twisting reality ;) -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA83EC4332F for ; Tue, 29 Nov 2022 09:16:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qFzgmqHMAuo7E3nnhuWVmvH0RfKg7oWwIvigs4xXWyc=; b=US67kjo2k04dxm FgndCp76OfKyT8tNMNVQe04NUKzj4qcsQ46RXBche3KxDrXqzq6VAKHpRYDXAXbQKOtVXTMPXT/r2 IFgpuvjX8oHj3Rv0sr/oRT6kqnquKd39WkHUXKdPecQuBq+8i75B2WzMXb/vNIjXWZAzSLXpq8JHh qMkI4mW7uYeAzwsp4nCzfeff/nbaQRl86jYFUk2JRy0WGuvjquvqIQ+1Nx8K/cD/IjA9gMfWPAEz6 BJNRlcYPPadSvds8ATstgeiiXv6BNLZddxC5V6oQ6oAKNqBm1EAFonpXSQgmSvwnj6/Umq4uP5Zw/ f7H9w+ArCBnROuVz3HhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozwiE-007k53-DB; Tue, 29 Nov 2022 09:15:34 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozwi9-007jzc-Br for linux-arm-kernel@lists.infradead.org; Tue, 29 Nov 2022 09:15:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669713326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=OvXTU6p0Ct0GG3VEsw6AOZSjwusuY/Ng6cuNku1asLSrx9F6Mc66uLvd7qxMRAZbOAL+J5 Q8DdnyjmltiPLfDTqjLE3SaozLtbjrW5pWS5w+X7WF2iZ/48KkE540YFRqNv9Zfo0kmyyh pze47cOZYmn8QXjChvz5wyc79I3BaI4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-262-AEOIIXQSNn2Nyf-_zz9QGg-1; Tue, 29 Nov 2022 04:15:24 -0500 X-MC-Unique: AEOIIXQSNn2Nyf-_zz9QGg-1 Received: by mail-wm1-f70.google.com with SMTP id m17-20020a05600c3b1100b003cf9cc47da5so7494969wms.9 for ; Tue, 29 Nov 2022 01:15:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=RCmIL5hrBW06qocKB+XVBtbFQOtlycpoTqWtzRm9SlfG4+rH34gj5yIvaxXjc7ppDS LxDN8UkFomyeT8RV6J5NAZLo7UvurreYuVGjOYIcAgWmZxwrFdgyf7m+QGRgNDOegUKR l6XRSsJ3BpQd/zLLKaBH0PNDjynQA+7zt/tyGS6bc0f6ZMg/g6vdwuVvwl3DAkK509wg gD2h1HzTv3OZzIJc98oC5rzKbw+CvhLmc8jrjIkjyLKXnYONc7fqbloNb4gdIDW+dTV5 lfNHOQKnXQIAs7tsDSCLDP63KRWMhXnKDNBusa+a/ZJsEe8+himRD4OdJDIv0Pxq833G s6vQ== X-Gm-Message-State: ANoB5pkZ4ugWfToi4RtctGMADlShk5uilYZq7AuvAUK6AcGesijcgnrJ BWBjPmpsNsfLeih3inrY6DIffEcrADBqt567ROSeQFmSZIwJHlyr+KSsa29Kl4NNiUsFCBSbmuI vL5nKsTMW8VkTjotMTD/6VhqT4e7ScCEg6p4= X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243416wme.140.1669713323597; Tue, 29 Nov 2022 01:15:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf5aMoFyhfTZRz6WGw0GcgDkcONZAiRyZAh+e0PFHXmVnEtFtgvwKaxuOXbIxhdoVgI1OB8H+Q== X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243382wme.140.1669713323266; Tue, 29 Nov 2022 01:15:23 -0800 (PST) Received: from ?IPV6:2003:cb:c705:ca00:3fb8:c253:3bf7:b60e? (p200300cbc705ca003fb8c2533bf7b60e.dip0.t-ipconnect.de. [2003:cb:c705:ca00:3fb8:c253:3bf7:b60e]) by smtp.gmail.com with ESMTPSA id n26-20020a05600c3b9a00b003c6b70a4d69sm1498998wms.42.2022.11.29.01.15.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 01:15:22 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 10:15:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: Hans Verkuil , Andrew Morton Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Tomasz Figa , Mauro Carvalho Chehab References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> <20221128145927.df895bf1966cfa125cae9668@linux-foundation.org> <22b1107b-0acc-5772-a883-8f3c4682eb1b@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221129_011529_733904_3D824E5F X-CRM114-Status: GOOD ( 19.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjkuMTEuMjIgMTA6MDgsIEhhbnMgVmVya3VpbCB3cm90ZToKPiBPbiAyOS8xMS8yMDIyIDA5 OjQ4LCBEYXZpZCBIaWxkZW5icmFuZCB3cm90ZToKPj4gT24gMjguMTEuMjIgMjM6NTksIEFuZHJl dyBNb3J0b24gd3JvdGU6Cj4+PiBPbiBNb24sIDI4IE5vdiAyMDIyIDA5OjE4OjQ3ICswMTAwIERh dmlkIEhpbGRlbmJyYW5kIDxkYXZpZEByZWRoYXQuY29tPiB3cm90ZToKPj4+Cj4+Pj4+IExlc3Mg Y2hhbmNlcyBvZiB0aGluZ3MgZ29pbmcgd3JvbmcgdGhhdCB3YXkuCj4+Pj4+Cj4+Pj4+IEp1c3Qg bWVudGlvbiBpbiB0aGUgdjIgY292ZXIgbGV0dGVyIHRoYXQgdGhlIGZpcnN0IHBhdGNoIHdhcyBh ZGRlZCB0bwo+Pj4+PiBtYWtlIGl0IGVhc3kgdG8gYmFja3BvcnQgdGhhdCBmaXggd2l0aG91dCBi ZWluZyBoYW1wZXJlZCBieSBtZXJnZQo+Pj4+PiBjb25mbGljdHMgaWYgaXQgd2FzIGFkZGVkIGFm dGVyIHlvdXIgZnJhbWVfdmVjdG9yLmMgcGF0Y2guCj4+Pj4KPj4+PiBZZXMsIHRoYXQncyB0aGUg d2F5IEkgd291bGQgbmF0dXJhbGx5IGRvLCBpdCwgaG93ZXZlciwgQW5kcmV3IHByZWZlcnMKPj4+ PiBkZWx0YSB1cGRhdGVzIGZvciBtaW5vciBjaGFuZ2VzLgo+Pj4+Cj4+Pj4gQEFuZHJldywgd2hh dGV2ZXIgeW91IHByZWZlciEKPj4+Cj4+PiBJJ20gaW5jbGluZWQgdG8gbGV0IHRoaW5ncyBzaXQg YXMgdGhleSBhcmUuwqAgQ3Jvc3MtdHJlZSBjb25mbGljdHMKPj4+IGhhcHBlbiwgYW5kIExpbnVz IGhhbmRsZXMgdGhlbS7CoCBJJ2xsIGZsYWcgdGhpcyAodmVyeSBzaW1wbGUpIGNvbmZsaWN0Cj4+ PiBpbiB0aGUgcHVsbCByZXF1ZXN0LCBpZiBNTSBtZXJnZXMgc2Vjb25kLsKgIElmIHY0bCBtZXJn ZXMgc2Vjb25kIHRoZW4KPj4+IGhvcGVmdWxseSB0aGV5IHdpbGwgZG8gdGhlIHNhbWUuwqAgQnV0 IHRoaXMgb25lIGlzIHNvIHNpbXBsZSB0aGF0IExpbnVzCj4+PiBoYXJkbHkgbmVlZHMgb3VyIGhl bHAuCj4gCj4gSXQncyBub3QgYWJvdXQgY3Jvc3MtdHJlZSBjb25mbGljdHMsIGl0J3MgYWJvdXQg dGhlIGZhY3QgdGhhdCBteSBwYXRjaCBpcwo+IGEgZml4IHRoYXQgbmVlZHMgdG8gYmUgYmFja3Bv cnRlZCB0byBvbGRlciBrZXJuZWxzLiBJdCBzaG91bGQgYXBwbHkgY2xlYW5seQo+IHRvIHRob3Nl IG9sZGVyIGtlcm5lbHMgaWYgbXkgcGF0Y2ggZ29lcyBpbiBmaXJzdCwgYnV0IGlmIGl0IGlzIHRo ZSBvdGhlciB3YXkKPiBhcm91bmQgSSB3b3VsZCBoYXZlIHRvIG1ha2UgYSBuZXcgcGF0Y2ggZm9y IHRoZSBzdGFibGUga2VybmVscy4KCklJVUMsIHRoZSBjb25mbGljdCB3aWxsIGJlIHJlc29sdmVk IGF0IG1lcmdlIHRpbWUgYW5kIHRoZSBtZXJnZSAKcmVzb2x1dGlvbiB3aWxsIGJlIHBhcnQgb2Yg dGhlIG1lcmdlIGNvbW1pdC4gSXQgZG9lc24ndCBtYXR0ZXIgaW4gd2hpY2ggCm9yZGVyIHRoZSBw YXRjaGVzIGdvIHVwc3RyZWFtLCB0aGUgbWVyZ2UgY29tbWl0IHJlc29sdmVzIHRoZSBwcm9ibGVt YXRpYyAKb3ZlcmxhcC4KClNvIHlvdXIgcGF0Y2ggd2lsbCBiZSB1cHN0cmVhbSBhcyBpbnRlbmRl ZCwgd2hlcmUgaXQgY2FuIGJlIGNsZWFubHkgCmJhY2twb3J0ZWQuCgpIb3BlIEkgYW0gbm90IHR3 aXN0aW5nIHJlYWxpdHkgOykKCi0tIApUaGFua3MsCgpEYXZpZCAvIGRoaWxkZW5iCgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6181C4167B for ; Tue, 29 Nov 2022 09:16:27 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NLxXp2wyXz30RH for ; Tue, 29 Nov 2022 20:16:26 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OvXTU6p0; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IU7xG2px; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OvXTU6p0; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IU7xG2px; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NLxWl3X98z2yxQ for ; Tue, 29 Nov 2022 20:15:30 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669713326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=OvXTU6p0Ct0GG3VEsw6AOZSjwusuY/Ng6cuNku1asLSrx9F6Mc66uLvd7qxMRAZbOAL+J5 Q8DdnyjmltiPLfDTqjLE3SaozLtbjrW5pWS5w+X7WF2iZ/48KkE540YFRqNv9Zfo0kmyyh pze47cOZYmn8QXjChvz5wyc79I3BaI4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669713327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=IU7xG2pxelXljMFqi8xHF+bmZxbEWM4ilThBeSE39E8xBm2qa027sL1g3fQwR1CtuWe4MJ 0nUI/WVSnhozQuq8YZerPB6jSchEyQRjdzZZMpq0T8/YQ+na852WJ7Fg6wvNxN72rEDPcH IxWWUobLx2P27yrimf7KCXtNe25xGL8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-458-Y3eegD9eMlCHm4tIs5YqCw-1; Tue, 29 Nov 2022 04:15:24 -0500 X-MC-Unique: Y3eegD9eMlCHm4tIs5YqCw-1 Received: by mail-wm1-f69.google.com with SMTP id b47-20020a05600c4aaf00b003d031aeb1b6so9856934wmp.9 for ; Tue, 29 Nov 2022 01:15:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=3PozzNGLz/Rn9TBdEFhOWGTawkxcSX+lIfAqsgrxgDkW1sRR305eSTmXQAXNxXvwEU eDfSAQf3B1bu0CcmvZ4Lf84JtYfnPZYP8Y3DYotL/7T5xuvk6n2yudu9rQHcHdU5lXsv zwUcwx5KaWqkKPvNO0bSPnIJyWzyqPWsWodEdWpPm+O/zhsWTdlbuHmPC6ymnQEi8mUT trqPZeW+vnjH2zWo1aKI9FelGhm7fy1juHedt3Vn+oIbvJqa7c0FnCwJSvwR8ELCvUiM aQftBXFnI4CYtHq6E0pe6Rw4VrxXlttrT11FirFFpnGNBgk63Z3DCH1CATMtHR8lDXCq zUxA== X-Gm-Message-State: ANoB5pnb1dIekxLvh4hKpPRMIIY4lh3SwyQ7fSdIS0WoUIsDoWCKIGvo n4Q5rR6GpbThmo7XesXnzfaDJMAIScKDIg9rpjRUtcQ11+kpkJQQhk8O/reDY+Jt89489KxwWtG RyehFqpQ2xYPN0K/THGGon2GaKw== X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243406wme.140.1669713323594; Tue, 29 Nov 2022 01:15:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf5aMoFyhfTZRz6WGw0GcgDkcONZAiRyZAh+e0PFHXmVnEtFtgvwKaxuOXbIxhdoVgI1OB8H+Q== X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243382wme.140.1669713323266; Tue, 29 Nov 2022 01:15:23 -0800 (PST) Received: from ?IPV6:2003:cb:c705:ca00:3fb8:c253:3bf7:b60e? (p200300cbc705ca003fb8c2533bf7b60e.dip0.t-ipconnect.de. [2003:cb:c705:ca00:3fb8:c253:3bf7:b60e]) by smtp.gmail.com with ESMTPSA id n26-20020a05600c3b9a00b003c6b70a4d69sm1498998wms.42.2022.11.29.01.15.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 01:15:22 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 10:15:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: Hans Verkuil , Andrew Morton References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> <20221128145927.df895bf1966cfa125cae9668@linux-foundation.org> <22b1107b-0acc-5772-a883-8f3c4682eb1b@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nadav Amit , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Shuah Khan , Marek Szyprowski , Andrea Arcangeli , linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, David Airlie , x86@kernel.org, Hugh Dickins , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , linux-media@vger.kernel.org, Arnd Bergmann , John Hubbard , linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, Alex Williamson , Peter Xu , Muchun Song , Mauro Carvalho Chehab , linux-arm-kernel@lis ts.infradead.org, linuxppc-dev@lists.ozlabs.org, Oded Gabbay , linux-mips@vger.kernel.org, Tomasz Figa , linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Lucas Stach , Linus Torvalds , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 29.11.22 10:08, Hans Verkuil wrote: > On 29/11/2022 09:48, David Hildenbrand wrote: >> On 28.11.22 23:59, Andrew Morton wrote: >>> On Mon, 28 Nov 2022 09:18:47 +0100 David Hildenbrand wrote: >>> >>>>> Less chances of things going wrong that way. >>>>> >>>>> Just mention in the v2 cover letter that the first patch was added to >>>>> make it easy to backport that fix without being hampered by merge >>>>> conflicts if it was added after your frame_vector.c patch. >>>> >>>> Yes, that's the way I would naturally do, it, however, Andrew prefers >>>> delta updates for minor changes. >>>> >>>> @Andrew, whatever you prefer! >>> >>> I'm inclined to let things sit as they are.  Cross-tree conflicts >>> happen, and Linus handles them.  I'll flag this (very simple) conflict >>> in the pull request, if MM merges second.  If v4l merges second then >>> hopefully they will do the same.  But this one is so simple that Linus >>> hardly needs our help. > > It's not about cross-tree conflicts, it's about the fact that my patch is > a fix that needs to be backported to older kernels. It should apply cleanly > to those older kernels if my patch goes in first, but if it is the other way > around I would have to make a new patch for the stable kernels. IIUC, the conflict will be resolved at merge time and the merge resolution will be part of the merge commit. It doesn't matter in which order the patches go upstream, the merge commit resolves the problematic overlap. So your patch will be upstream as intended, where it can be cleanly backported. Hope I am not twisting reality ;) -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52FA5C4332F for ; Tue, 29 Nov 2022 09:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=89vPLgpLS+iTPiewn3wYso3LW/SD9yx/rDBIAvdxYk0=; b=ehNEd7cTzdVs96 kfudd3baL5noe1dq4CT8FaZ/cXjpmrOh+3J8AvSskKbcDntkfe8tJSHhxMfkrzsFJAw3U8TE4g+Ty 3Vt6z+zp6tBNVFcY6fO6QmlhfCuaLIdmbiMTQR4WQ8YliXZAnuZAzprktFQgp1aXXus92poYyBTtu L11Z4pbh3ukM1ZteeLMLIdt0oNzMK2uFJYZUnEHxVLZ2/yIwmMbBr/x1b1LzlDW+qG8v/zXEPZphU DPhdId8YiL2tZaIUBwptQvcc8jb8jkwS86viVSuSNqmN7lCGmAoIPfVb0IzTBKz8L+dq/TcB/pH0x er5RLcom0hGwGO0T2ENA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozwiC-007k3g-Fn; Tue, 29 Nov 2022 09:15:32 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozwi9-007jzd-C4 for linux-um@lists.infradead.org; Tue, 29 Nov 2022 09:15:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669713326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=OvXTU6p0Ct0GG3VEsw6AOZSjwusuY/Ng6cuNku1asLSrx9F6Mc66uLvd7qxMRAZbOAL+J5 Q8DdnyjmltiPLfDTqjLE3SaozLtbjrW5pWS5w+X7WF2iZ/48KkE540YFRqNv9Zfo0kmyyh pze47cOZYmn8QXjChvz5wyc79I3BaI4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-133-pKr36060M6WChhDgxBW4Fg-1; Tue, 29 Nov 2022 04:15:24 -0500 X-MC-Unique: pKr36060M6WChhDgxBW4Fg-1 Received: by mail-wr1-f70.google.com with SMTP id q13-20020adfab0d000000b002420132f543so2514925wrc.19 for ; Tue, 29 Nov 2022 01:15:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=aHZjgtjuYEy4iKBoBeQbJBi2om2QGQwu67jImcWNv03+1tjjQyfh9cv5+OnX0DqDxh iLgw7AZOMMypGQz232g5vAAmEIjd9QM4vDmU76yOo0aElG1aq8xot/SCxATuNYdXXeqn W3PycFJGWL4AbF3fqWDbv7HjbmoxuWYchBRyznAOy8OpyD10rnDHeFnrTf0asAI1KUiT XtEHXQp8v45Aq4RnSXfwM3OQ/3VOZr23G/RL1W1OjotxU0lbmKt7lQ3Jx4UynkgqsYWv +pd5hZXa1wMRZn6Oy1E9FrZln4Z5s93RzwNEK53cFNbUVzsnwZQXp+lZDweclNGSnfm4 puOA== X-Gm-Message-State: ANoB5pmfs26afkNbqXNyfBALe78JnT78nA90V9pQcmZhqWt5WocfRNVG a38CHWqSa6/pYV6y1ZVRqN3obbmPjWVAGUDaCPlQ1DqFxHeaMnvTIUuBWgIb3OoVSLHrxVq4au0 q46EPUTvdY7DhH0BgSMaUSahN X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243412wme.140.1669713323598; Tue, 29 Nov 2022 01:15:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf5aMoFyhfTZRz6WGw0GcgDkcONZAiRyZAh+e0PFHXmVnEtFtgvwKaxuOXbIxhdoVgI1OB8H+Q== X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243382wme.140.1669713323266; Tue, 29 Nov 2022 01:15:23 -0800 (PST) Received: from ?IPV6:2003:cb:c705:ca00:3fb8:c253:3bf7:b60e? (p200300cbc705ca003fb8c2533bf7b60e.dip0.t-ipconnect.de. [2003:cb:c705:ca00:3fb8:c253:3bf7:b60e]) by smtp.gmail.com with ESMTPSA id n26-20020a05600c3b9a00b003c6b70a4d69sm1498998wms.42.2022.11.29.01.15.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 01:15:22 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 10:15:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: Hans Verkuil , Andrew Morton Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Tomasz Figa , Mauro Carvalho Chehab References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> <20221128145927.df895bf1966cfa125cae9668@linux-foundation.org> <22b1107b-0acc-5772-a883-8f3c4682eb1b@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221129_011529_655261_607BE183 X-CRM114-Status: GOOD ( 18.41 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org T24gMjkuMTEuMjIgMTA6MDgsIEhhbnMgVmVya3VpbCB3cm90ZToKPiBPbiAyOS8xMS8yMDIyIDA5 OjQ4LCBEYXZpZCBIaWxkZW5icmFuZCB3cm90ZToKPj4gT24gMjguMTEuMjIgMjM6NTksIEFuZHJl dyBNb3J0b24gd3JvdGU6Cj4+PiBPbiBNb24sIDI4IE5vdiAyMDIyIDA5OjE4OjQ3ICswMTAwIERh dmlkIEhpbGRlbmJyYW5kIDxkYXZpZEByZWRoYXQuY29tPiB3cm90ZToKPj4+Cj4+Pj4+IExlc3Mg Y2hhbmNlcyBvZiB0aGluZ3MgZ29pbmcgd3JvbmcgdGhhdCB3YXkuCj4+Pj4+Cj4+Pj4+IEp1c3Qg bWVudGlvbiBpbiB0aGUgdjIgY292ZXIgbGV0dGVyIHRoYXQgdGhlIGZpcnN0IHBhdGNoIHdhcyBh ZGRlZCB0bwo+Pj4+PiBtYWtlIGl0IGVhc3kgdG8gYmFja3BvcnQgdGhhdCBmaXggd2l0aG91dCBi ZWluZyBoYW1wZXJlZCBieSBtZXJnZQo+Pj4+PiBjb25mbGljdHMgaWYgaXQgd2FzIGFkZGVkIGFm dGVyIHlvdXIgZnJhbWVfdmVjdG9yLmMgcGF0Y2guCj4+Pj4KPj4+PiBZZXMsIHRoYXQncyB0aGUg d2F5IEkgd291bGQgbmF0dXJhbGx5IGRvLCBpdCwgaG93ZXZlciwgQW5kcmV3IHByZWZlcnMKPj4+ PiBkZWx0YSB1cGRhdGVzIGZvciBtaW5vciBjaGFuZ2VzLgo+Pj4+Cj4+Pj4gQEFuZHJldywgd2hh dGV2ZXIgeW91IHByZWZlciEKPj4+Cj4+PiBJJ20gaW5jbGluZWQgdG8gbGV0IHRoaW5ncyBzaXQg YXMgdGhleSBhcmUuwqAgQ3Jvc3MtdHJlZSBjb25mbGljdHMKPj4+IGhhcHBlbiwgYW5kIExpbnVz IGhhbmRsZXMgdGhlbS7CoCBJJ2xsIGZsYWcgdGhpcyAodmVyeSBzaW1wbGUpIGNvbmZsaWN0Cj4+ PiBpbiB0aGUgcHVsbCByZXF1ZXN0LCBpZiBNTSBtZXJnZXMgc2Vjb25kLsKgIElmIHY0bCBtZXJn ZXMgc2Vjb25kIHRoZW4KPj4+IGhvcGVmdWxseSB0aGV5IHdpbGwgZG8gdGhlIHNhbWUuwqAgQnV0 IHRoaXMgb25lIGlzIHNvIHNpbXBsZSB0aGF0IExpbnVzCj4+PiBoYXJkbHkgbmVlZHMgb3VyIGhl bHAuCj4gCj4gSXQncyBub3QgYWJvdXQgY3Jvc3MtdHJlZSBjb25mbGljdHMsIGl0J3MgYWJvdXQg dGhlIGZhY3QgdGhhdCBteSBwYXRjaCBpcwo+IGEgZml4IHRoYXQgbmVlZHMgdG8gYmUgYmFja3Bv cnRlZCB0byBvbGRlciBrZXJuZWxzLiBJdCBzaG91bGQgYXBwbHkgY2xlYW5seQo+IHRvIHRob3Nl IG9sZGVyIGtlcm5lbHMgaWYgbXkgcGF0Y2ggZ29lcyBpbiBmaXJzdCwgYnV0IGlmIGl0IGlzIHRo ZSBvdGhlciB3YXkKPiBhcm91bmQgSSB3b3VsZCBoYXZlIHRvIG1ha2UgYSBuZXcgcGF0Y2ggZm9y IHRoZSBzdGFibGUga2VybmVscy4KCklJVUMsIHRoZSBjb25mbGljdCB3aWxsIGJlIHJlc29sdmVk IGF0IG1lcmdlIHRpbWUgYW5kIHRoZSBtZXJnZSAKcmVzb2x1dGlvbiB3aWxsIGJlIHBhcnQgb2Yg dGhlIG1lcmdlIGNvbW1pdC4gSXQgZG9lc24ndCBtYXR0ZXIgaW4gd2hpY2ggCm9yZGVyIHRoZSBw YXRjaGVzIGdvIHVwc3RyZWFtLCB0aGUgbWVyZ2UgY29tbWl0IHJlc29sdmVzIHRoZSBwcm9ibGVt YXRpYyAKb3ZlcmxhcC4KClNvIHlvdXIgcGF0Y2ggd2lsbCBiZSB1cHN0cmVhbSBhcyBpbnRlbmRl ZCwgd2hlcmUgaXQgY2FuIGJlIGNsZWFubHkgCmJhY2twb3J0ZWQuCgpIb3BlIEkgYW0gbm90IHR3 aXN0aW5nIHJlYWxpdHkgOykKCi0tIApUaGFua3MsCgpEYXZpZCAvIGRoaWxkZW5iCgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtdW0gbWFpbGlu ZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11bQo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Date: Tue, 29 Nov 2022 09:15:20 +0000 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage Message-Id: List-Id: References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> <20221128145927.df895bf1966cfa125cae9668@linux-foundation.org> <22b1107b-0acc-5772-a883-8f3c4682eb1b@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Hans Verkuil , Andrew Morton Cc: linux-ia64@vger.kernel.org, Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nadav Amit , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Shuah Khan , Marek Szyprowski , Andrea Arcangeli , linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, x86@kernel.org, Hugh Dickins , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , linux-media@vger.kernel.org, Arnd Bergmann , John Hubbard , linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, Alex Williamson , Peter Xu , Muchun Song , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Oded Gabbay , linux-mips@vger.kernel.org, Tomasz Figa , linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linus Torvalds , Mike Kravetz On 29.11.22 10:08, Hans Verkuil wrote: > On 29/11/2022 09:48, David Hildenbrand wrote: >> On 28.11.22 23:59, Andrew Morton wrote: >>> On Mon, 28 Nov 2022 09:18:47 +0100 David Hildenbrand wrote: >>> >>>>> Less chances of things going wrong that way. >>>>> >>>>> Just mention in the v2 cover letter that the first patch was added to >>>>> make it easy to backport that fix without being hampered by merge >>>>> conflicts if it was added after your frame_vector.c patch. >>>> >>>> Yes, that's the way I would naturally do, it, however, Andrew prefers >>>> delta updates for minor changes. >>>> >>>> @Andrew, whatever you prefer! >>> >>> I'm inclined to let things sit as they are.  Cross-tree conflicts >>> happen, and Linus handles them.  I'll flag this (very simple) conflict >>> in the pull request, if MM merges second.  If v4l merges second then >>> hopefully they will do the same.  But this one is so simple that Linus >>> hardly needs our help. > > It's not about cross-tree conflicts, it's about the fact that my patch is > a fix that needs to be backported to older kernels. It should apply cleanly > to those older kernels if my patch goes in first, but if it is the other way > around I would have to make a new patch for the stable kernels. IIUC, the conflict will be resolved at merge time and the merge resolution will be part of the merge commit. It doesn't matter in which order the patches go upstream, the merge commit resolves the problematic overlap. So your patch will be upstream as intended, where it can be cleanly backported. Hope I am not twisting reality ;) -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage Date: Tue, 29 Nov 2022 10:15:20 +0100 Message-ID: References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> <20221128145927.df895bf1966cfa125cae9668@linux-foundation.org> <22b1107b-0acc-5772-a883-8f3c4682eb1b@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=89vPLgpLS+iTPiewn3wYso3LW/SD9yx/rDBIAvdxYk0=; b=ehNEd7cTzdVs96 kfudd3baL5noe1dq4CT8FaZ/cXjpmrOh+3J8AvSskKbcDntkfe8tJSHhxMfkrzsFJAw3U8TE4g+Ty 3Vt6z+zp6tBNVFcY6fO6QmlhfCuaLIdmbiMTQR4WQ8YliXZAnuZAzprktFQgp1aXXus92poYyBTtu L11Z4pbh3ukM1ZteeLMLIdt0oNzMK2uFJYZUnEHxVLZ2/yIwmMbBr/x1b1LzlDW+qG8v/zXEPZphU DPhdId8YiL2tZaIUBwptQvcc8jb8jkwS86viVSuSNqmN7lCGmAoIPfVb0IzTBKz8L+dq/TcB/pH0x er5RLcom0hGwGO0T2ENA==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669713326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=OvXTU6p0Ct0GG3VEsw6AOZSjwusuY/Ng6cuNku1asLSrx9F6Mc66uLvd7qxMRAZbOAL+J5 Q8DdnyjmltiPLfDTqjLE3SaozLtbjrW5pWS5w+X7WF2iZ/48KkE540YFRqNv9Zfo0kmyyh pze47cOZYmn8QXjChvz5wyc79I3BaI4= In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+glud-user-mode-linux-devel=m.gmane-mx.org@lists.infradead.org Content-Type: text/plain; charset="utf-8"; format="flowed" To: Hans Verkuil , Andrew Morton Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil T24gMjkuMTEuMjIgMTA6MDgsIEhhbnMgVmVya3VpbCB3cm90ZToKPiBPbiAyOS8xMS8yMDIyIDA5 OjQ4LCBEYXZpZCBIaWxkZW5icmFuZCB3cm90ZToKPj4gT24gMjguMTEuMjIgMjM6NTksIEFuZHJl dyBNb3J0b24gd3JvdGU6Cj4+PiBPbiBNb24sIDI4IE5vdiAyMDIyIDA5OjE4OjQ3ICswMTAwIERh dmlkIEhpbGRlbmJyYW5kIDxkYXZpZEByZWRoYXQuY29tPiB3cm90ZToKPj4+Cj4+Pj4+IExlc3Mg Y2hhbmNlcyBvZiB0aGluZ3MgZ29pbmcgd3JvbmcgdGhhdCB3YXkuCj4+Pj4+Cj4+Pj4+IEp1c3Qg bWVudGlvbiBpbiB0aGUgdjIgY292ZXIgbGV0dGVyIHRoYXQgdGhlIGZpcnN0IHBhdGNoIHdhcyBh ZGRlZCB0bwo+Pj4+PiBtYWtlIGl0IGVhc3kgdG8gYmFja3BvcnQgdGhhdCBmaXggd2l0aG91dCBi ZWluZyBoYW1wZXJlZCBieSBtZXJnZQo+Pj4+PiBjb25mbGljdHMgaWYgaXQgd2FzIGFkZGVkIGFm dGVyIHlvdXIgZnJhbWVfdmVjdG9yLmMgcGF0Y2guCj4+Pj4KPj4+PiBZZXMsIHRoYXQncyB0aGUg d2F5IEkgd291bGQgbmF0dXJhbGx5IGRvLCBpdCwgaG93ZXZlciwgQW5kcmV3IHByZWZlcnMKPj4+ PiBkZWx0YSB1cGRhdGVzIGZvciBtaW5vciBjaGFuZ2VzLgo+Pj4+Cj4+Pj4gQEFuZHJldywgd2hh dGV2ZXIgeW91IHByZWZlciEKPj4+Cj4+PiBJJ20gaW5jbGluZWQgdG8gbGV0IHRoaW5ncyBzaXQg YXMgdGhleSBhcmUuwqAgQ3Jvc3MtdHJlZSBjb25mbGljdHMKPj4+IGhhcHBlbiwgYW5kIExpbnVz IGhhbmRsZXMgdGhlbS7CoCBJJ2xsIGZsYWcgdGhpcyAodmVyeSBzaW1wbGUpIGNvbmZsaWN0Cj4+ PiBpbiB0aGUgcHVsbCByZXF1ZXN0LCBpZiBNTSBtZXJnZXMgc2Vjb25kLsKgIElmIHY0bCBtZXJn ZXMgc2Vjb25kIHRoZW4KPj4+IGhvcGVmdWxseSB0aGV5IHdpbGwgZG8gdGhlIHNhbWUuwqAgQnV0 IHRoaXMgb25lIGlzIHNvIHNpbXBsZSB0aGF0IExpbnVzCj4+PiBoYXJkbHkgbmVlZHMgb3VyIGhl bHAuCj4gCj4gSXQncyBub3QgYWJvdXQgY3Jvc3MtdHJlZSBjb25mbGljdHMsIGl0J3MgYWJvdXQg dGhlIGZhY3QgdGhhdCBteSBwYXRjaCBpcwo+IGEgZml4IHRoYXQgbmVlZHMgdG8gYmUgYmFja3Bv cnRlZCB0byBvbGRlciBrZXJuZWxzLiBJdCBzaG91bGQgYXBwbHkgY2xlYW5seQo+IHRvIHRob3Nl IG9sZGVyIGtlcm5lbHMgaWYgbXkgcGF0Y2ggZ29lcyBpbiBmaXJzdCwgYnV0IGlmIGl0IGlzIHRo ZSBvdGhlciB3YXkKPiBhcm91bmQgSSB3b3VsZCBoYXZlIHRvIG1ha2UgYSBuZXcgcGF0Y2ggZm9y IHRoZSBzdGFibGUga2VybmVscy4KCklJVUMsIHRoZSBjb25mbGljdCB3aWxsIGJlIHJlc29sdmVk IGF0IG1lcmdlIHRpbWUgYW5kIHRoZSBtZXJnZSAKcmVzb2x1dGlvbiB3aWxsIGJlIHBhcnQgb2Yg dGhlIG1lcmdlIGNvbW1pdC4gSXQgZG9lc24ndCBtYXR0ZXIgaW4gd2hpY2ggCm9yZGVyIHRoZSBw YXRjaGVzIGdvIHVwc3RyZWFtLCB0aGUgbWVyZ2UgY29tbWl0IHJlc29sdmVzIHRoZSBwcm9ibGVt YXRpYyAKb3ZlcmxhcC4KClNvIHlvdXIgcGF0Y2ggd2lsbCBiZSB1cHN0cmVhbSBhcyBpbnRlbmRl ZCwgd2hlcmUgaXQgY2FuIGJlIGNsZWFubHkgCmJhY2twb3J0ZWQuCgpIb3BlIEkgYW0gbm90IHR3 aXN0aW5nIHJlYWxpdHkgOykKCi0tIApUaGFua3MsCgpEYXZpZCAvIGRoaWxkZW5iCgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtdW0gbWFpbGlu ZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11bQo=