All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-s390x@nongnu.org
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>,
	Alexander Graf <agraf@suse.de>, Cornelia Huck <cohuck@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC] s390x/kvm: call cpu_synchronize_state() on every kvm_arch_handle_exit()
Date: Mon, 26 Mar 2018 11:36:41 +0200	[thread overview]
Message-ID: <abd0dd45-f42f-7071-986c-24de5f845bc3@redhat.com> (raw)
In-Reply-To: <20180326092036.12780-1-david@redhat.com>

On 26.03.2018 11:20, David Hildenbrand wrote:
> Manually having to use cpu_synchronize_state() is error prone. I don't
> think that the performance impact is that huge if we simply synchronize
> the state on every kvm_arch_handle_exit() call. This makes the code
> easier to maintain.
> 
> We now also call it (although not neded) for
> - KVM_EXIT_S390_RESET -> s390_reipl_request()
> - KVM_EXIT_DEBUG -> kvm_arch_handle_debug_exit()
> - unmanagable/unimplemented intercepts
> - ICPT_WAITPSW -> s390_handle_wait() -> cpu gets halted

Just noticed that this one is actually also already called :)

> - ICPT_CPU_STOP -> do_stop_interrupt() -> cpu gets halted
> - Scenarios where we inject an operation exception
> - handle_sigp() on the source CPU

And this one, too.

> - handle_stsi()

-- 

Thanks,

David / dhildenb

  reply	other threads:[~2018-03-26  9:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26  9:20 [Qemu-devel] [PATCH RFC] s390x/kvm: call cpu_synchronize_state() on every kvm_arch_handle_exit() David Hildenbrand
2018-03-26  9:36 ` David Hildenbrand [this message]
2018-04-05  7:53 ` Christian Borntraeger
2018-04-05  8:03   ` David Hildenbrand
2018-04-05  8:03   ` Cornelia Huck
2018-04-05  8:19   ` Thomas Huth
2018-04-05  8:47     ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abd0dd45-f42f-7071-986c-24de5f845bc3@redhat.com \
    --to=david@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.