All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@scylladb.com>
To: Jens Axboe <axboe@kernel.dk>,
	Pavel Begunkov <asml.silence@gmail.com>,
	io-uring@vger.kernel.org
Subject: Re: IORING_OP_POLL_ADD slower than linux-aio IOCB_CMD_POLL
Date: Wed, 15 Jun 2022 16:43:46 +0300	[thread overview]
Message-ID: <abd9d8d3-9fc6-75d1-33fa-19571293b426@scylladb.com> (raw)
In-Reply-To: <4612ee3b-a63c-2374-9fc1-db099b2f6d78@kernel.dk>


On 15/06/2022 15.21, Jens Axboe wrote:
> On 6/15/22 5:38 AM, Pavel Begunkov wrote:
>>>>> Another way is to also set IORING_SETUP_TASKRUN_FLAG, then when
>>>>> there is work that requires to enter the kernel io_uring will
>>>>> set IORING_SQ_TASKRUN in sq_flags.
>>>>> Actually, I'm not mistaken io_uring has some automagic handling
>>>>> of it internally
>>>>>
>>>>> https://github.com/axboe/liburing/blob/master/src/queue.c#L36
>>>>>
>>> Is there documentation about this flag?
>> Unfortunately, I don't see any.
>> Here is a link to the kernel commit if it helps:
>>
>> https://git.kernel.dk/cgit/linux-block/commit/?h=ef060ea9e4fd3b763e7060a3af0a258d2d5d7c0d
>>
>> I think it's more interesting what support liburing has,
>> but would need to look up in the code. Maybe Jens
>> remembers and can tell.
> It is documented, in the io_uring.2 man page in liburing:
>
> https://git.kernel.dk/cgit/liburing/tree/man/io_uring_setup.2#n200
>

Perfect. Thanks!



  reply	other threads:[~2022-06-15 13:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 11:07 IORING_OP_POLL_ADD slower than linux-aio IOCB_CMD_POLL Avi Kivity
2022-04-19 11:38 ` Jens Axboe
2022-04-19 11:57   ` Avi Kivity
2022-04-19 12:04     ` Jens Axboe
2022-04-19 12:21       ` Avi Kivity
2022-04-19 12:31         ` Jens Axboe
2022-04-19 15:21           ` Jens Axboe
2022-04-19 15:51             ` Avi Kivity
2022-04-19 17:14             ` Jens Axboe
2022-04-19 19:41               ` Avi Kivity
2022-04-19 19:58                 ` Jens Axboe
2022-04-20 11:55                   ` Avi Kivity
2022-04-20 12:09                     ` Jens Axboe
2022-04-21  9:05                       ` Avi Kivity
2022-06-15 10:12               ` Avi Kivity
2022-06-15 10:48                 ` Pavel Begunkov
2022-06-15 11:04                   ` Avi Kivity
2022-06-15 11:07                     ` Avi Kivity
2022-06-15 11:38                       ` Pavel Begunkov
2022-06-15 12:21                         ` Jens Axboe
2022-06-15 13:43                           ` Avi Kivity [this message]
2022-06-15 11:30                     ` Pavel Begunkov
2022-06-15 11:36                       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abd9d8d3-9fc6-75d1-33fa-19571293b426@scylladb.com \
    --to=avi@scylladb.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.