All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Gang He <ghe@suse.com>, mark@fasheh.com, jlbec@evilplan.org
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	akpm@linux-foundation.org
Subject: Re: [PATCH] ocfs2: avoid getting dlm lock of the target directory multiple times during reflink process
Date: Tue, 31 Aug 2021 15:39:59 +0800	[thread overview]
Message-ID: <abe27a3a-efde-660c-4d9c-d659eba3eab1@linux.alibaba.com> (raw)
In-Reply-To: <744d756c-7640-d312-37ef-126755324e8a@suse.com>



On 8/31/21 2:25 PM, Gang He wrote:
> Hello Joseph and Wengang,
> 
> When you have time, please help review this patch.
> About the deadlock problem which was caused by ocfs2_downconvert_lock failure, we have the fix patch, it is very key.
> But I feel this patch is still useful as a optimization patch, the user
> case is to reflink the files to the same directory concurrently, our users usually backup the files(via reflink) from the cluster nodes concurrently(via crontab) every day/hour.
> The current design, during the reflink process, the node will acquire/release dlm lock of the target directory multiple times,
> this is very inefficient in concurrently reflink.
> 

Sure, I'll spend some time this week.

Thanks,
Joseph

WARNING: multiple messages have this Message-ID
From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Gang He <ghe@suse.com>, mark@fasheh.com, jlbec@evilplan.org
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: avoid getting dlm lock of the target directory multiple times during reflink process
Date: Tue, 31 Aug 2021 15:39:59 +0800	[thread overview]
Message-ID: <abe27a3a-efde-660c-4d9c-d659eba3eab1@linux.alibaba.com> (raw)
In-Reply-To: <744d756c-7640-d312-37ef-126755324e8a@suse.com>



On 8/31/21 2:25 PM, Gang He wrote:
> Hello Joseph and Wengang,
> 
> When you have time, please help review this patch.
> About the deadlock problem which was caused by ocfs2_downconvert_lock failure, we have the fix patch, it is very key.
> But I feel this patch is still useful as a optimization patch, the user
> case is to reflink the files to the same directory concurrently, our users usually backup the files(via reflink) from the cluster nodes concurrently(via crontab) every day/hour.
> The current design, during the reflink process, the node will acquire/release dlm lock of the target directory multiple times,
> this is very inefficient in concurrently reflink.
> 

Sure, I'll spend some time this week.

Thanks,
Joseph

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

  reply	other threads:[~2021-08-31  7:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26  7:59 [PATCH] ocfs2: avoid getting dlm lock of the target directory multiple times during reflink process Gang He
2021-08-26  7:59 ` [Ocfs2-devel] " Gang He
2021-08-31  6:25 ` Gang He
2021-08-31  6:25   ` [Ocfs2-devel] " Gang He
2021-08-31  7:39   ` Joseph Qi [this message]
2021-08-31  7:39     ` Joseph Qi
2021-09-07 15:57   ` Wengang Wang
2021-09-07 15:57     ` Wengang Wang
2021-09-08  6:06     ` Gang He
2021-09-08  6:06       ` Gang He
2021-09-08 16:00       ` Wengang Wang
2021-09-08 16:00         ` Wengang Wang
2021-09-14  7:34         ` Gang He
2021-09-14  7:34           ` Gang He
2021-09-14 17:50           ` Wengang Wang
2021-09-17  7:37             ` Gang He
2021-09-17  7:37               ` Gang He
2021-09-06 11:14 ` Joseph Qi
2021-09-06 11:14   ` [Ocfs2-devel] " Joseph Qi
2021-09-07  9:40   ` Gang He
2021-09-07  9:40     ` [Ocfs2-devel] " Gang He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abe27a3a-efde-660c-4d9c-d659eba3eab1@linux.alibaba.com \
    --to=joseph.qi@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=ghe@suse.com \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.