All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
	"Luigi Rizzo" <lrizzo@google.com>,
	"Network Development" <netdev@vger.kernel.org>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"David Miller" <davem@davemloft.net>,
	hawk@kernel.org, "Jubran, Samih" <sameehj@amazon.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	ast@kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v4] netdev attribute to control xdpgeneric skb linearization
Date: Tue, 3 Mar 2020 22:04:55 +0100	[thread overview]
Message-ID: <abe8f703-d239-2444-99a0-c94dd53f478a@iogearbox.net> (raw)
In-Reply-To: <20200303125020.2baef01b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On 3/3/20 9:50 PM, Jakub Kicinski wrote:
> On Tue, 3 Mar 2020 20:46:55 +0100 Daniel Borkmann wrote:
>> Thus, when the data/data_end test fails in generic XDP, the user can
>> call e.g. bpf_xdp_pull_data(xdp, 64) to make sure we pull in as much as
>> is needed w/o full linearization and once done the data/data_end can be
>> repeated to proceed. Native XDP will leave xdp->rxq->skb as NULL, but
>> later we could perhaps reuse the same bpf_xdp_pull_data() helper for
>> native with skb-less backing. Thoughts?
> 
> I'm curious why we consider a xdpgeneric-only addition. Is attaching
> a cls_bpf program noticeably slower than xdpgeneric?

Yeah, agree, I'm curious about that part as well.

Thanks,
Daniel

  reply	other threads:[~2020-03-03 21:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-28 10:54 [PATCH v4] netdev attribute to control xdpgeneric skb linearization Luigi Rizzo
2020-02-28 11:20 ` Toke Høiland-Jørgensen
2020-02-28 12:12 ` Michal Kubecek
2020-02-28 12:29 ` Jesper Dangaard Brouer
2020-02-28 13:19   ` Luigi Rizzo
2020-02-28 12:30 ` Jesper Dangaard Brouer
2020-02-28 19:00 ` Jakub Kicinski
2020-02-28 23:53   ` Willem de Bruijn
2020-03-03 19:46     ` Daniel Borkmann
2020-03-03 20:50       ` Jakub Kicinski
2020-03-03 21:04         ` Daniel Borkmann [this message]
2020-03-03 21:10         ` Willem de Bruijn
2020-03-04  9:18           ` Jesper Dangaard Brouer
2020-03-04 10:06       ` Luigi Rizzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abe8f703-d239-2444-99a0-c94dd53f478a@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrizzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=sameehj@amazon.com \
    --cc=toke@redhat.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.