From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932319Ab1EFK5P (ORCPT ); Fri, 6 May 2011 06:57:15 -0400 Received: from qmta15.emeryville.ca.mail.comcast.net ([76.96.27.228]:43094 "EHLO qmta15.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756278Ab1EFKyd (ORCPT ); Fri, 6 May 2011 06:54:33 -0400 X-Greylist: delayed 341 seconds by postgrey-1.27 at vger.kernel.org; Fri, 06 May 2011 06:54:18 EDT From: matt mooney To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 07/16] staging: usbip: usbip_event.c: coding style cleanup Date: Fri, 6 May 2011 03:47:47 -0700 Message-Id: X-Mailer: git-send-email 1.7.5.1 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix a few alignment issues and remove extraneous lines. Signed-off-by: matt mooney --- drivers/staging/usbip/usbip_event.c | 18 ++++++------------ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/usbip/usbip_event.c b/drivers/staging/usbip/usbip_event.c index f4b287e..8861e3b 100644 --- a/drivers/staging/usbip/usbip_event.c +++ b/drivers/staging/usbip/usbip_event.c @@ -17,8 +17,8 @@ * USA. */ -#include "usbip_common.h" #include +#include "usbip_common.h" static int event_handler(struct usbip_device *ud) { @@ -36,21 +36,18 @@ static int event_handler(struct usbip_device *ud) */ if (ud->event & USBIP_EH_SHUTDOWN) { ud->eh_ops.shutdown(ud); - ud->event &= ~USBIP_EH_SHUTDOWN; } /* Reset the device. */ if (ud->event & USBIP_EH_RESET) { ud->eh_ops.reset(ud); - ud->event &= ~USBIP_EH_RESET; } /* Mark the device as unusable. */ if (ud->event & USBIP_EH_UNUSABLE) { ud->eh_ops.unusable(ud); - ud->event &= ~USBIP_EH_UNUSABLE; } @@ -68,13 +65,14 @@ static int event_handler_loop(void *data) while (!kthread_should_stop()) { wait_event_interruptible(ud->eh_waitq, - usbip_event_happened(ud) || - kthread_should_stop()); + usbip_event_happened(ud) || + kthread_should_stop()); usbip_dbg_eh("wakeup\n"); if (event_handler(ud) < 0) break; } + return 0; } @@ -86,9 +84,10 @@ int usbip_start_eh(struct usbip_device *ud) ud->eh = kthread_run(event_handler_loop, ud, "usbip_eh"); if (IS_ERR(ud->eh)) { printk(KERN_WARNING - "Unable to start control thread\n"); + "Unable to start control thread\n"); return PTR_ERR(ud->eh); } + return 0; } EXPORT_SYMBOL_GPL(usbip_start_eh); @@ -106,11 +105,8 @@ EXPORT_SYMBOL_GPL(usbip_stop_eh); void usbip_event_add(struct usbip_device *ud, unsigned long event) { spin_lock(&ud->lock); - ud->event |= event; - wake_up(&ud->eh_waitq); - spin_unlock(&ud->lock); } EXPORT_SYMBOL_GPL(usbip_event_add); @@ -120,10 +116,8 @@ int usbip_event_happened(struct usbip_device *ud) int happened = 0; spin_lock(&ud->lock); - if (ud->event != 0) happened = 1; - spin_unlock(&ud->lock); return happened; -- 1.7.5.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: matt mooney Date: Fri, 06 May 2011 10:47:47 +0000 Subject: [PATCH 07/16] staging: usbip: usbip_event.c: coding style cleanup Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Fix a few alignment issues and remove extraneous lines. Signed-off-by: matt mooney --- drivers/staging/usbip/usbip_event.c | 18 ++++++------------ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/usbip/usbip_event.c b/drivers/staging/usbip/usbip_event.c index f4b287e..8861e3b 100644 --- a/drivers/staging/usbip/usbip_event.c +++ b/drivers/staging/usbip/usbip_event.c @@ -17,8 +17,8 @@ * USA. */ -#include "usbip_common.h" #include +#include "usbip_common.h" static int event_handler(struct usbip_device *ud) { @@ -36,21 +36,18 @@ static int event_handler(struct usbip_device *ud) */ if (ud->event & USBIP_EH_SHUTDOWN) { ud->eh_ops.shutdown(ud); - ud->event &= ~USBIP_EH_SHUTDOWN; } /* Reset the device. */ if (ud->event & USBIP_EH_RESET) { ud->eh_ops.reset(ud); - ud->event &= ~USBIP_EH_RESET; } /* Mark the device as unusable. */ if (ud->event & USBIP_EH_UNUSABLE) { ud->eh_ops.unusable(ud); - ud->event &= ~USBIP_EH_UNUSABLE; } @@ -68,13 +65,14 @@ static int event_handler_loop(void *data) while (!kthread_should_stop()) { wait_event_interruptible(ud->eh_waitq, - usbip_event_happened(ud) || - kthread_should_stop()); + usbip_event_happened(ud) || + kthread_should_stop()); usbip_dbg_eh("wakeup\n"); if (event_handler(ud) < 0) break; } + return 0; } @@ -86,9 +84,10 @@ int usbip_start_eh(struct usbip_device *ud) ud->eh = kthread_run(event_handler_loop, ud, "usbip_eh"); if (IS_ERR(ud->eh)) { printk(KERN_WARNING - "Unable to start control thread\n"); + "Unable to start control thread\n"); return PTR_ERR(ud->eh); } + return 0; } EXPORT_SYMBOL_GPL(usbip_start_eh); @@ -106,11 +105,8 @@ EXPORT_SYMBOL_GPL(usbip_stop_eh); void usbip_event_add(struct usbip_device *ud, unsigned long event) { spin_lock(&ud->lock); - ud->event |= event; - wake_up(&ud->eh_waitq); - spin_unlock(&ud->lock); } EXPORT_SYMBOL_GPL(usbip_event_add); @@ -120,10 +116,8 @@ int usbip_event_happened(struct usbip_device *ud) int happened = 0; spin_lock(&ud->lock); - if (ud->event != 0) happened = 1; - spin_unlock(&ud->lock); return happened; -- 1.7.5.1