From: Coly Li <colyli@suse.de>
To: Lin Feng <linf@wangsu.com>
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcache: remove unused struct member in cache_stats
Date: Sat, 30 Oct 2021 22:58:47 +0800 [thread overview]
Message-ID: <abf21c4f-5bbb-a0bb-534a-3d2758b4a8d6@suse.de> (raw)
In-Reply-To: <20211029115939.92309-1-linf@wangsu.com>
On 10/29/21 7:59 PM, Lin Feng wrote:
> Commit 1616a4c2ab1a80893b6890ae93da40a2b1d0c691
> ("bcache: remove bcache device self-defined readahead")
> remove stuffs for bcache self-defined readahead, but
> cache_readaheads field in cache_stats is leftout, remove it.
>
> Signed-off-by: Lin Feng <linf@wangsu.com>
Nice catch. I add it into my testing queue. Thanks.
Coly Li
> ---
> drivers/md/bcache/stats.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/bcache/stats.h b/drivers/md/bcache/stats.h
> index ca4f435f7216..b6bfea66c01f 100644
> --- a/drivers/md/bcache/stats.h
> +++ b/drivers/md/bcache/stats.h
> @@ -18,7 +18,6 @@ struct cache_stats {
> unsigned long cache_misses;
> unsigned long cache_bypass_hits;
> unsigned long cache_bypass_misses;
> - unsigned long cache_readaheads;
> unsigned long cache_miss_collisions;
> unsigned long sectors_bypassed;
>
prev parent reply other threads:[~2021-10-30 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 11:59 [PATCH] bcache: remove unused struct member in cache_stats Lin Feng
2021-10-30 14:58 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abf21c4f-5bbb-a0bb-534a-3d2758b4a8d6@suse.de \
--to=colyli@suse.de \
--cc=linf@wangsu.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.