All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, jun.nakajima@intel.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 2/3] x86/vpmu: Disable VPMU if guest's CPUID indicates no PMU support
Date: Wed, 22 Feb 2017 11:34:34 -0500	[thread overview]
Message-ID: <abf610a9-1934-a1e4-5aa5-6b7c7a4cf902@oracle.com> (raw)
In-Reply-To: <19cf5c82-cba5-5842-cb46-be319e5a261c@citrix.com>


> I think the code as-is is ok, although it would be nice to extend the
> basic{} union to have a named uint8_t for pmu_version.


Something like this?

diff --git a/xen/include/asm-x86/cpuid.h b/xen/include/asm-x86/cpuid.h
index bc3fc7c..f73ae19 100644
--- a/xen/include/asm-x86/cpuid.h
+++ b/xen/include/asm-x86/cpuid.h
@@ -117,7 +117,15 @@ struct cpuid_policy
             };
 
             /* Leaf 0x2 - TLB/Cache/Prefetch. */
-            uint8_t l2_nr_queries; /* Documented as fixed to 1. */
+            union {
+                uint8_t l2_nr_queries; /* Documented as fixed to 1. */
+                struct cpuid_leaf leaf2;
+            };
+
+            struct cpuid_leaf unused[0xa - 0x3];
+
+            /* Leaf 0xa - Intel PMU. */
+            uint8_t pmu_version;
         };
     } basic;




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-02-22 16:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17 17:40 [PATCH v2 0/3] VPMU management update Boris Ostrovsky
2017-02-17 17:40 ` [PATCH v2 1/3] x86/vpmu: Add get/put_vpmu() and VPMU_AVAILABLE Boris Ostrovsky
2017-02-21  8:09   ` Tian, Kevin
2017-02-21 14:09     ` Boris Ostrovsky
2017-02-22  3:05       ` Tian, Kevin
2017-02-22 14:06         ` Boris Ostrovsky
2017-02-21 11:00   ` Andrew Cooper
2017-02-21 14:12     ` Boris Ostrovsky
2017-02-17 17:40 ` [PATCH v2 2/3] x86/vpmu: Disable VPMU if guest's CPUID indicates no PMU support Boris Ostrovsky
2017-02-21  8:13   ` Tian, Kevin
2017-02-22  9:55   ` Jan Beulich
2017-02-22 14:15     ` Boris Ostrovsky
2017-02-22 14:38       ` Jan Beulich
2017-02-22 15:02         ` Boris Ostrovsky
2017-02-22 15:10           ` Andrew Cooper
2017-02-22 16:34             ` Boris Ostrovsky [this message]
2017-02-22 16:42               ` Andrew Cooper
2017-02-22 15:16           ` Jan Beulich
2017-02-17 17:40 ` [PATCH v2 3/3] libxc/x86: PV guests should see leaf 0xa on Intel Boris Ostrovsky
2017-02-20 14:15   ` Wei Liu
2017-02-20 14:16     ` Andrew Cooper
2017-02-20 14:17       ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abf610a9-1934-a1e4-5aa5-6b7c7a4cf902@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.