From: Simon Ruderich <simon@ruderich.org>
To: qemu-devel@nongnu.org
Cc: David Alan Gilbert <dgilbert@redhat.com>,
Peter Crosthwaite <crosthwaitepeter@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
Simon Ruderich <simon@ruderich.org>
Subject: [Qemu-devel] [PATCH v8 7/7] hmp: add pmemload command
Date: Thu, 15 Nov 2018 15:07:18 +0100 [thread overview]
Message-ID: <abf685f3fd220c6f17b93ba7865e99e3ec67fecf.1542290622.git.simon@ruderich.org> (raw)
In-Reply-To: <cover.1542290622.git.simon@ruderich.org>
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical memory, we can use cross gdb
to do some target debug which gdb cannot do directly.
This patch contains only the hmp changes of the original patch.
[1]: https://lists.gnu.org/archive/html/qemu-trivial/2014-04/msg00074.html
Based-on-patch-by: Baojun Wang <wangbj@gmail.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Simon Ruderich <simon@ruderich.org>
---
hmp-commands.hx | 14 ++++++++++++++
hmp.c | 12 ++++++++++++
hmp.h | 1 +
3 files changed, 27 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 2404a5210d..baadbb3a69 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -857,6 +857,20 @@ STEXI
@item pmemsave @var{addr} @var{size} @var{file}
@findex pmemsave
save to disk physical memory dump starting at @var{addr} of size @var{size}.
+ETEXI
+
+ {
+ .name = "pmemload",
+ .args_type = "val:l,size:l,offset:l,filename:F",
+ .params = "addr size offset file",
+ .help = "load from disk physical memory dump starting at 'addr' of size 'size' at file offset 'offset'",
+ .cmd = hmp_pmemload,
+ },
+
+STEXI
+@item pmemload @var{addr} @var{size} @var{offset} @var{file}
+@findex pmemload
+load from disk physical memory dump starting at @var{addr} of size @var{size} at file offset @var{offset}.
ETEXI
{
diff --git a/hmp.c b/hmp.c
index 42a5d163cd..c2a77fc390 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1169,6 +1169,18 @@ void hmp_pmemsave(Monitor *mon, const QDict *qdict)
hmp_handle_error(mon, &err);
}
+void hmp_pmemload(Monitor *mon, const QDict *qdict)
+{
+ uint64_t size = qdict_get_int(qdict, "size");
+ uint64_t offset = qdict_get_int(qdict, "offset");
+ const char *filename = qdict_get_str(qdict, "filename");
+ uint64_t addr = qdict_get_int(qdict, "val");
+ Error *err = NULL;
+
+ qmp_pmemload(addr, filename, true, size, true, offset, &err);
+ hmp_handle_error(mon, &err);
+}
+
void hmp_ringbuf_write(Monitor *mon, const QDict *qdict)
{
const char *chardev = qdict_get_str(qdict, "device");
diff --git a/hmp.h b/hmp.h
index 5f1addcca2..6503146a8c 100644
--- a/hmp.h
+++ b/hmp.h
@@ -49,6 +49,7 @@ void hmp_exit_preconfig(Monitor *mon, const QDict *qdict);
void hmp_cpu(Monitor *mon, const QDict *qdict);
void hmp_memsave(Monitor *mon, const QDict *qdict);
void hmp_pmemsave(Monitor *mon, const QDict *qdict);
+void hmp_pmemload(Monitor *mon, const QDict *qdict);
void hmp_ringbuf_write(Monitor *mon, const QDict *qdict);
void hmp_ringbuf_read(Monitor *mon, const QDict *qdict);
void hmp_cont(Monitor *mon, const QDict *qdict);
--
2.19.1
prev parent reply other threads:[~2018-11-15 14:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 14:07 [Qemu-devel] [PATCH v8 0/7] qmp: add pmemload command Simon Ruderich
2018-11-15 14:07 ` [Qemu-devel] [PATCH v8 1/7] cpus: correct coding style in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-11-15 14:07 ` [Qemu-devel] [PATCH v8 2/7] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open Simon Ruderich
2018-11-15 14:07 ` [Qemu-devel] [PATCH v8 3/7] cpus: use size_t in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-11-15 14:07 ` [Qemu-devel] [PATCH v8 4/7] hmp: use l for size argument in memsave/pmemsave Simon Ruderich
2018-11-15 14:07 ` [Qemu-devel] [PATCH v8 5/7] hmp: use F for filename arguments " Simon Ruderich
2018-11-15 14:07 ` [Qemu-devel] [PATCH v8 6/7] qmp: add pmemload command Simon Ruderich
2018-11-28 12:37 ` Markus Armbruster
2018-11-28 16:43 ` Eric Blake
2018-11-28 18:07 ` Markus Armbruster
2018-11-15 14:07 ` Simon Ruderich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abf685f3fd220c6f17b93ba7865e99e3ec67fecf.1542290622.git.simon@ruderich.org \
--to=simon@ruderich.org \
--cc=armbru@redhat.com \
--cc=crosthwaitepeter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.