All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>,
	linux-parisc@vger.kernel.org,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	John David Anglin <dave.anglin@bell.net>
Subject: Re: [PATCH] parisc: Drop HP-UX specifix fcntl and signal flags
Date: Sat, 29 Aug 2020 14:22:31 +0200	[thread overview]
Message-ID: <ac0aaa25-2314-e580-c70c-93cf4700c764@gmx.de> (raw)
In-Reply-To: <8645899.CDJkKcVGEf@daneel.sf-tec.de>


[-- Attachment #1.1: Type: text/plain, Size: 1420 bytes --]

On 29.08.20 13:26, Rolf Eike Beer wrote:
> Am Samstag, 29. August 2020, 12:51:12 CEST schrieb Helge Deller:
>> Those flags are nowhere used in the Linux kernel and were added when we
>> still wanted to support HP-UX in a compat mode. Since we never will
>> support HP-UX, drop those flags.
>>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>>
>> diff --git a/arch/parisc/include/uapi/asm/fcntl.h
>> b/arch/parisc/include/uapi/asm/fcntl.h index 03ce20e5ad7d..4289ee732c4c
>> 100644
>> --- a/arch/parisc/include/uapi/asm/fcntl.h
>> +++ b/arch/parisc/include/uapi/asm/fcntl.h
>> @@ -3,7 +3,6 @@
>>  #define _PARISC_FCNTL_H
>>
>>  #define O_APPEND	000000010
>> -#define O_BLKSEEK	000000100 /* HPUX only */
>>  #define O_CREAT		000000400 /* not fcntl */
>>  #define O_EXCL		000002000 /* not fcntl */
>>  #define O_LARGEFILE	000004000
>> @@ -12,13 +11,11 @@
>>  #define O_NONBLOCK	000200004 /* HPUX has separate NDELAY & NONBLOCK */
>>  #define O_NOCTTY	000400000 /* not fcntl */
>>  #define O_DSYNC		001000000 /* HPUX only */
>> -#define O_RSYNC		002000000 /* HPUX only */
> 
> So, what about O_DSYNC? Either it should go away the same if it is HPUX only, 
> or the comment needs to be fixed.

That's true.
I had it fixed already in my git tree:
https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?h=for-next&id=297f57686b3f634306b6a67a90d5a146392693c2

Helge


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2020-08-29 12:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29 10:51 [PATCH] parisc: Drop HP-UX specifix fcntl and signal flags Helge Deller
2020-08-29 11:26 ` Rolf Eike Beer
2020-08-29 12:22   ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac0aaa25-2314-e580-c70c-93cf4700c764@gmx.de \
    --to=deller@gmx.de \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=dave.anglin@bell.net \
    --cc=eike-kernel@sf-tec.de \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.