Re: [Qemu-devel] [PATCH v4 1/2] qapi: Open files with encoding='utf-8'

From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: tamiko@43-1.org, arfrever.fta@gmail.com
Subject: Re: [Qemu-devel] [PATCH v4 1/2] qapi: Open files with encoding='utf-8'
Date: Tue, 19 Jun 2018 06:02:10 -0500	[thread overview]
Message-ID: <ac17cafd-6133-c6c9-c25e-08145c5a3be4@redhat.com> (raw)
In-Reply-To: <20180618175958.29073-2-armbru@redhat.com>

On 06/18/2018 12:59 PM, Markus Armbruster wrote:
> Python 2 happily reads UTF-8 files in text mode, but Python 3 requires
> either UTF-8 locale or an explicit encoding passed to open().  Commit
> d4e5ec877ca fixed this by setting the en_US.UTF-8 locale.  Falls apart
> when the locale isn't be available.
> 
> Matthias Maier and Arfrever Frehtes Taifersar Arahesis proposed to use
> binary mode instead, with manual conversion from bytes to str.  Works,
> but opening with an explicit encoding is simpler, so do that.
> 
> Since Python 2's open() doesn't support the encoding parameter, we
> need to suppress it with a version check.
> 
> Reported-by: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
> Reported-by: Matthias Maier <tamiko@43-1.org>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   scripts/qapi/common.py | 17 ++++++++++++++---
>   1 file changed, 14 insertions(+), 3 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org