All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Eugene Shalygin <eugene.shalygin@gmail.com>
Cc: Christopher Klooz <py0xc3@my.mail.de>,
	linux-hwmon@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: Issue in asus_ec_sensors in Fedora installations and other distributions
Date: Sat, 3 Sep 2022 15:00:04 -0700	[thread overview]
Message-ID: <ac202c2e-3add-2470-3fa6-85783c1494a0@roeck-us.net> (raw)
In-Reply-To: <CAB95QAQ9EXX3uZhiZyxr=aAwiSR6j6i1GstFg9iX4eF06b5GUQ@mail.gmail.com>

On 9/3/22 12:40, Eugene Shalygin wrote:
>> I don't understand why that works either. Maybe it interferes with other
>> PNP0C09 devices and/or the code in drivers/acpi/ec.c.
> 
> Turns out the patch breaks sensors on a system where it should provide
> output. The module gets loaded but provides no output (which should
> mean the probe code is not executed). I will try to investigate
> tomorrow.
> 
>> Couple of comments:
>>
>> - You'll need to drop __init.
>> - No need or reason to rename asus_ec_sensors_platform_driver
>>     to asus_ec_sensors_platform_driver_probe.
> That's in order to not drop __init.
> 

What does the name of the struct platform_driver data structure
have to do with __init ?

Thanks,
Guenter

  reply	other threads:[~2022-09-03 22:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6026b5e2-a8f5-1058-6112-f191bde333a6@my.mail.de>
2022-09-03 11:00 ` Issue in asus_ec_sensors in Fedora installations and other distributions Christopher Klooz
2022-09-03 15:09   ` Guenter Roeck
2022-09-03 15:13     ` Eugene Shalygin
2022-09-03 15:42       ` Guenter Roeck
2022-09-03 19:40         ` Eugene Shalygin
2022-09-03 22:00           ` Guenter Roeck [this message]
2022-09-03 22:37             ` Eugene Shalygin
2022-09-03 23:47               ` Guenter Roeck
2022-09-04 13:19                 ` Eugene Shalygin
2022-09-04 14:10                   ` Guenter Roeck
2022-09-03 15:48       ` Christopher Klooz
2022-09-04  9:33   ` Issue in asus_ec_sensors in Fedora installations and other distributions #forregzbot Thorsten Leemhuis
2022-09-06 20:10   ` Issue in asus_ec_sensors in Fedora installations and other distributions Guenter Roeck
2022-09-06 20:23     ` Eugene Shalygin
2022-09-15  8:25       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac202c2e-3add-2470-3fa6-85783c1494a0@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=eugene.shalygin@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=py0xc3@my.mail.de \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.