Re: [PATCH v4 0/6] drm: zpos normalization cleanup and omapdrm to use it

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

Hi,

On 06/02/18 14:05, Peter Ujfalusi wrote:
> Hi,
> 
> Changes since v3:
> - Moved the new normalize_zpos bool to be around another bools
> - Extended the commit message for sti that the drm_atomic_helper_check() is
>   going to ask for async_update due to the legacy cursor usage.
> 
> Changes since v2:
> - Fixed commit messages (s/drm_device/drm_mode_config)
> - Added ack from Benjamin Gaignard to drm/sti patch
> 
> Changes since v1:
> - normalize_zpos flag moved to drm_mode_config
> - Added comment to note the side effect of normalization and updated the comment
>   for normalized_zpos in the header file as well.
> - Added Acked-by from Daniel to patch 2-6 but not for patch 1 as I'm not sure if
>   the comments I have added matches with what is expected to be.
> 
> The first patch is adding a flag to drm_device that drivers can set if they want
> the zpos to be normalized.
> 
> Then convert exynos, tegra, sti and rcar-du to use this flag instead of
> re-implementing the drm_atomic_helper_check() locally just to add the call to
> drm_atomic_normalize_zpos().
> 
> The last patch is moving omapdrm to use the zpos normalization as well to comply
> with the UAPI documentation regarding to zpos.
> 
> Laurent's note in an earlier thread:
> https://marc.info/?l=dri-devel&m=151567355225029&w=2
> 
> "The problem is that zpos normalization requires accessing the state of all 
> enabled planes for a CRTC in order to compute (and store) the normalized zpos 
> values. This thus forces all planes to be added to the commit state, even when 
> the commit doesn't touch the zpos property. I assume this caused issues 
> (possibly performance issues) in drivers that then performed hardware setup of 
> all planes as a result."
> 
> can be addressed later in the core for all users of drm_atomic_normalize_zpos()

Thanks. I think this looks fine, I'll push via drm-misc.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel