All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Gong <richard.gong@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, dinguyen@kernel.org,
	atull@kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, sen.li@intel.com,
	Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv4 2/4] firmware: add Intel Stratix10 remote system update driver
Date: Wed, 29 May 2019 10:12:22 -0500	[thread overview]
Message-ID: <ac379a9a-9613-3f66-78ff-a38c0045764d@linux.intel.com> (raw)
In-Reply-To: <20190528232400.GB29225@kroah.com>


Hi Greg,

On 5/28/19 6:24 PM, Greg KH wrote:
> On Tue, May 28, 2019 at 03:20:31PM -0500, richard.gong@linux.intel.com wrote:
>> +static int rsu_send_msg(struct stratix10_rsu_priv *priv,
>> +			enum stratix10_svc_command_code command,
>> +	unsigned long arg,
>> +	void (*callback)(struct stratix10_svc_client *client,
>> +			 struct stratix10_svc_cb_data *data))
> 
> Odd indentation for arg, and then callback.
> 
> Why isn't callback a typedef to make this simpler to use?
> 

I will make correction in the next submission.

> thanks,
> 
> greg k-h
> 

Regards,
Richard

  reply	other threads:[~2019-05-29 15:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 20:20 [PATCHv4 0/4] add Intel Stratix10 remote system update driver richard.gong
2019-05-28 20:20 ` [PATCHv4 1/4] firmware: stratix10-svc: extend svc to support RSU notify and WD features richard.gong
2019-05-28 20:20 ` [PATCHv4 2/4] firmware: add Intel Stratix10 remote system update driver richard.gong
2019-05-28 23:15   ` Greg KH
2019-05-29 14:15     ` Richard Gong
2019-05-28 23:22   ` Greg KH
2019-05-29 14:55     ` Richard Gong
2019-06-03 15:57       ` A potential broken at platform driver? Richard Gong
2019-06-03 15:57         ` Richard Gong
2019-06-03 18:02         ` Greg KH
2019-06-03 23:08           ` Richard Gong
2019-06-04 14:28             ` Greg KH
2019-06-04 10:33           ` Romain Izard
2019-06-04 14:28             ` Greg KH
2019-06-04 16:13               ` Richard Gong
2019-06-04 17:03                 ` Greg KH
2019-06-11 14:10                   ` Richard Gong
2019-06-11 15:47                     ` Greg KH
2019-05-28 23:24   ` [PATCHv4 2/4] firmware: add Intel Stratix10 remote system update driver Greg KH
2019-05-29 15:12     ` Richard Gong [this message]
2019-05-28 20:20 ` [PATCHv4 3/4] firmware: rsu: document sysfs interface richard.gong
2019-05-28 23:19   ` Greg KH
2019-05-29 15:33     ` Richard Gong
2019-05-28 20:20 ` [PATCHv4 4/4] MAINTAINERS: add maintainer for Intel Stratix10 FW drivers richard.gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac379a9a-9613-3f66-78ff-a38c0045764d@linux.intel.com \
    --to=richard.gong@linux.intel.com \
    --cc=atull@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=richard.gong@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=sen.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.