From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757197AbZEWLgY (ORCPT ); Sat, 23 May 2009 07:36:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753276AbZEWLgJ (ORCPT ); Sat, 23 May 2009 07:36:09 -0400 Received: from mail-bw0-f174.google.com ([209.85.218.174]:46289 "EHLO mail-bw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752656AbZEWLgI convert rfc822-to-8bit (ORCPT ); Sat, 23 May 2009 07:36:08 -0400 MIME-Version: 1.0 In-Reply-To: References: <1242865694-2100-4-git-send-email-ebiederm@xmission.com> <4A14F356.3030501@kernel.org> <4A15046A.10106@kernel.org> <4A1512E2.2040505@kernel.org> <4A151ECE.50800@kernel.org> From: Kay Sievers Date: Sat, 23 May 2009 13:35:48 +0200 Message-ID: Subject: Re: [PATCH 04/20] sysfs: Handle the general case of removing of directories with subdirectories To: "Eric W. Biederman" Cc: Tejun Heo , Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 23, 2009 at 08:33, Eric W. Biederman wrote: > My plan going forward is to fix the ordering problems with deleting > /sys/dev/char and /sys/dev/block.  Add a WARN_ON if we delete a > non-empty directory.  Ensure we don't add something to an already > deleted directory. What's the problem in /sys/dev/? There are just a bunch of symlinks, one for every device with a dev_t, and all in flat directories, and no directory to remove. Thanks, Kay From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Subject: Re: [PATCH 04/20] sysfs: Handle the general case of removing of directories with subdirectories Date: Sat, 23 May 2009 13:35:48 +0200 Message-ID: References: <1242865694-2100-4-git-send-email-ebiederm@xmission.com> <4A14F356.3030501@kernel.org> <4A15046A.10106@kernel.org> <4A1512E2.2040505@kernel.org> <4A151ECE.50800@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Tejun Heo , Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" To: "Eric W. Biederman" Return-path: Received: from mail-bw0-f174.google.com ([209.85.218.174]:46289 "EHLO mail-bw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752656AbZEWLgI convert rfc822-to-8bit (ORCPT ); Sat, 23 May 2009 07:36:08 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, May 23, 2009 at 08:33, Eric W. Biederman wrote: > My plan going forward is to fix the ordering problems with deleting > /sys/dev/char and /sys/dev/block. =C2=A0Add a WARN_ON if we delete a > non-empty directory. =C2=A0Ensure we don't add something to an alread= y > deleted directory. What's the problem in /sys/dev/? There are just a bunch of symlinks, one for every device with a dev_t, and all in flat directories, and no directory to remove. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html