From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755164AbZEWV2C (ORCPT ); Sat, 23 May 2009 17:28:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754335AbZEWV1w (ORCPT ); Sat, 23 May 2009 17:27:52 -0400 Received: from mail-bw0-f174.google.com ([209.85.218.174]:44871 "EHLO mail-bw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753856AbZEWV1w convert rfc822-to-8bit (ORCPT ); Sat, 23 May 2009 17:27:52 -0400 MIME-Version: 1.0 In-Reply-To: <1243109591-21611-5-git-send-email-ebiederm@xmission.com> References: <1243109591-21611-5-git-send-email-ebiederm@xmission.com> From: Kay Sievers Date: Sat, 23 May 2009 23:27:32 +0200 Message-ID: Subject: Re: [PATCH 25/20] sysfs: Only support removing emtpy sysfs directories. To: "Eric W. Biederman" Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 23, 2009 at 22:13, Eric W. Biederman wrote: > From: Eric W. Biederman > > I have looked and I have not found a single legitimate case today where > we remove sysfs directories with anything in them.  The only case I have > found to date was a bug.  It was a problem of ownership.  The files in > the directory where not owned by the directory itself.   Leaving open > the potential for double deletion of the directory contents. > > Signed-off-by: Eric W. Biederman Sounds good to me. We should try that, and see if there was any valid use case we didn't think of, and if not, it's good to do what this patch does. Acked-by: Kay Sievers Thanks, Kay From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Subject: Re: [PATCH 25/20] sysfs: Only support removing emtpy sysfs directories. Date: Sat, 23 May 2009 23:27:32 +0200 Message-ID: References: <1243109591-21611-5-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" To: "Eric W. Biederman" Return-path: In-Reply-To: <1243109591-21611-5-git-send-email-ebiederm@xmission.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, May 23, 2009 at 22:13, Eric W. Biederman wrote: > From: Eric W. Biederman > > I have looked and I have not found a single legitimate case today whe= re > we remove sysfs directories with anything in them. =C2=A0The only cas= e I have > found to date was a bug. =C2=A0It was a problem of ownership. =C2=A0T= he files in > the directory where not owned by the directory itself. =C2=A0 Leaving= open > the potential for double deletion of the directory contents. > > Signed-off-by: Eric W. Biederman Sounds good to me. We should try that, and see if there was any valid use case we didn't think of, and if not, it's good to do what this patch does. Acked-by: Kay Sievers Thanks, Kay