From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757252AbZEWVaM (ORCPT ); Sat, 23 May 2009 17:30:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754436AbZEWV37 (ORCPT ); Sat, 23 May 2009 17:29:59 -0400 Received: from mail-bw0-f174.google.com ([209.85.218.174]:43915 "EHLO mail-bw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753531AbZEWV36 (ORCPT ); Sat, 23 May 2009 17:29:58 -0400 MIME-Version: 1.0 In-Reply-To: <1243109591-21611-4-git-send-email-ebiederm@xmission.com> References: <1243109591-21611-4-git-send-email-ebiederm@xmission.com> From: Kay Sievers Date: Sat, 23 May 2009 23:29:39 +0200 Message-ID: Subject: Re: [PATCH 24/20] sysfs: In sysfs_add_one fail if the targe directory has been removed. To: "Eric W. Biederman" Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 23, 2009 at 22:13, Eric W. Biederman wrote: > From: Eric W. Biederman > > If a bug in the upper layers results in someone attempting to add > to a sysfs directory that has already been removed, warn about it > and fail. > > I don't believe this has ever happened, and it certainly never should > happen, but be strict to avoid errors creeping in. > > Signed-off-by: Eric W. Biederman Sounds like a good idea. Acked-by: Kay Sievers Thanks, Kay From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Subject: Re: [PATCH 24/20] sysfs: In sysfs_add_one fail if the targe directory has been removed. Date: Sat, 23 May 2009 23:29:39 +0200 Message-ID: References: <1243109591-21611-4-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" To: "Eric W. Biederman" Return-path: Received: from mail-bw0-f174.google.com ([209.85.218.174]:43915 "EHLO mail-bw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753531AbZEWV36 (ORCPT ); Sat, 23 May 2009 17:29:58 -0400 In-Reply-To: <1243109591-21611-4-git-send-email-ebiederm@xmission.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, May 23, 2009 at 22:13, Eric W. Biederman wrote: > From: Eric W. Biederman > > If a bug in the upper layers results in someone attempting to add > to a sysfs directory that has already been removed, warn about it > and fail. > > I don't believe this has ever happened, and it certainly never should > happen, but be strict to avoid errors creeping in. > > Signed-off-by: Eric W. Biederman Sounds like a good idea. Acked-by: Kay Sievers Thanks, Kay