From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755804AbZEWXVm (ORCPT ); Sat, 23 May 2009 19:21:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754391AbZEWXVe (ORCPT ); Sat, 23 May 2009 19:21:34 -0400 Received: from mail-fx0-f168.google.com ([209.85.220.168]:55450 "EHLO mail-fx0-f168.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753876AbZEWXVe convert rfc822-to-8bit (ORCPT ); Sat, 23 May 2009 19:21:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <1243109591-21611-2-git-send-email-ebiederm@xmission.com> From: Kay Sievers Date: Sun, 24 May 2009 01:21:14 +0200 Message-ID: Subject: Re: [PATCH 22/20] sysfs: Make sysfs_rename_link atomic To: "Eric W. Biederman" Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 23, 2009 at 23:32, Kay Sievers wrote: > On Sat, May 23, 2009 at 22:13, Eric W. Biederman wrote: >> From: Eric W. Biederman >> >> Use the existing sysfs_rename to make sysfs_rename_link an atomic >> operation that does less work.  While I am at add additional sanity >> checking to ensure it is a symlink I am renaming. >> >> Signed-off-by: Eric W. Biederman > > Looks great, and so much better than the remove and re-create thing. Do you have your git tree public somewhere, or do you mind sending me an all-in-one patch? I like to give it a try here. Thanks, Kay From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Subject: Re: [PATCH 22/20] sysfs: Make sysfs_rename_link atomic Date: Sun, 24 May 2009 01:21:14 +0200 Message-ID: References: <1243109591-21611-2-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" To: "Eric W. Biederman" Return-path: Received: from mail-fx0-f168.google.com ([209.85.220.168]:55450 "EHLO mail-fx0-f168.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753876AbZEWXVe convert rfc822-to-8bit (ORCPT ); Sat, 23 May 2009 19:21:34 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, May 23, 2009 at 23:32, Kay Sievers wrote= : > On Sat, May 23, 2009 at 22:13, Eric W. Biederman wrote: >> From: Eric W. Biederman >> >> Use the existing sysfs_rename to make sysfs_rename_link an atomic >> operation that does less work. =C2=A0While I am at add additional sa= nity >> checking to ensure it is a symlink I am renaming. >> >> Signed-off-by: Eric W. Biederman > > Looks great, and so much better than the remove and re-create thing. Do you have your git tree public somewhere, or do you mind sending me an all-in-one patch? I like to give it a try here. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html