From: Robert Yang <liezhi.yang@windriver.com>
To: <bitbake-devel@lists.openembedded.org>
Subject: [PATCH 1/1] bitbake: cookerdata: Avoid double exceptions for bb.fatal()
Date: Thu, 9 May 2019 16:03:03 +0800 [thread overview]
Message-ID: <ac4edd962cb6b4831cb85cd731d2d2a810c62503.1557388944.git.liezhi.yang@windriver.com> (raw)
In-Reply-To: <cover.1557388944.git.liezhi.yang@windriver.com>
The bb.fatal() raises BBHandledException() which causes double exceptions,
e.g.:
Add 'HOSTTOOLS += "hello"' to conf/local.conf:
$ bitbake -p
[snip]
During handling of the above exception, another exception occurred:
[snip]
ERROR: The following required tools (as specified by HOSTTOOLS) appear to be unavailable in PATH, please install them in order to proceed:
hello
Use "raise" rather than "raise bb.BBHandledException" to fix the double
exceptions.
[YOCTO #13267]
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
bitbake/lib/bb/cookerdata.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bitbake/lib/bb/cookerdata.py b/bitbake/lib/bb/cookerdata.py
index f8ae410..585edc5 100644
--- a/bitbake/lib/bb/cookerdata.py
+++ b/bitbake/lib/bb/cookerdata.py
@@ -301,7 +301,9 @@ class CookerDataBuilder(object):
if multiconfig:
bb.event.fire(bb.event.MultiConfigParsed(self.mcdata), self.data)
- except (SyntaxError, bb.BBHandledException):
+ except bb.BBHandledException:
+ raise
+ except SyntaxError:
raise bb.BBHandledException
except bb.data_smart.ExpansionError as e:
logger.error(str(e))
--
2.7.4
next prev parent reply other threads:[~2019-05-09 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 8:03 [PATCH 0/1] bitbake: cookerdata: Avoid double exceptions for bb.fatal() Robert Yang
2019-05-09 8:03 ` Robert Yang [this message]
2019-05-12 8:28 ` [PATCH 1/1] " Richard Purdie
2019-05-14 11:02 ` Robert Yang
2019-05-20 8:55 ` Robert Yang
2019-08-15 11:29 ` Robert Yang
2019-08-15 23:03 ` richard.purdie
2019-08-19 8:34 ` Robert Yang
2019-08-19 9:04 ` Robert Yang
2019-08-22 9:06 ` Robert Yang
2019-08-15 10:55 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac4edd962cb6b4831cb85cd731d2d2a810c62503.1557388944.git.liezhi.yang@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.