From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00291C432C0 for ; Tue, 3 Dec 2019 22:32:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBADA20684 for ; Tue, 3 Dec 2019 22:32:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QtWbeuOz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBADA20684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icGio-0000JW-TJ for qemu-devel@archiver.kernel.org; Tue, 03 Dec 2019 17:32:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56455) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icGD7-0001YK-Sr for qemu-devel@nongnu.org; Tue, 03 Dec 2019 16:59:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icGCz-0002x7-EW for qemu-devel@nongnu.org; Tue, 03 Dec 2019 16:59:51 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:34030 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icGCy-0002cw-Cw for qemu-devel@nongnu.org; Tue, 03 Dec 2019 16:59:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575410382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ockXEWL0ht1UhdaAknyv2Hjkp6iESzOpm5o+3FY4ryc=; b=QtWbeuOzX6lgqGgu1deEMp9RT1LWI9xBwNCsfI2otwEKJFvAPQgskjf9LT655SIsXXAKRZ bpXD1FEGE7DgZm1QFcC7wOHDLQjIYZcwGWeWbLc1lQKW7BUDFT+EWf8rWV9yr9PVYk6cNh TCM6fLVc/VwA1tvqSEPP1pGi90HGFRI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-aNoFGWNcM_aicxoVvxqGog-1; Tue, 03 Dec 2019 16:59:39 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C663891219; Tue, 3 Dec 2019 21:59:37 +0000 (UTC) Received: from [10.3.116.171] (ovpn-116-171.phx2.redhat.com [10.3.116.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF0DF19C69; Tue, 3 Dec 2019 21:59:36 +0000 (UTC) Subject: Re: for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open() From: Eric Blake To: Vladimir Sementsov-Ogievskiy , "pannengyuan@huawei.com" , "kwolf@redhat.com" , "mreitz@redhat.com" , "sgarzare@redhat.com" References: <1575012326-51324-1-git-send-email-pannengyuan@huawei.com> <1575012326-51324-2-git-send-email-pannengyuan@huawei.com> <1cff97de-303b-3b27-f737-3f69759746b0@virtuozzo.com> <08f0d51d-f352-5d64-26a4-9a741a4cf2e0@redhat.com> Organization: Red Hat, Inc. Message-ID: Date: Tue, 3 Dec 2019 15:59:36 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <08f0d51d-f352-5d64-26a4-9a741a4cf2e0@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: aNoFGWNcM_aicxoVvxqGog-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "liyiting@huawei.com" , "zhang.zhanghailiang@huawei.com" , "qemu-block@nongnu.org" , "qemu-devel@nongnu.org" , qemu-stable , "kuhn.chenqun@huawei.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/3/19 12:54 PM, Eric Blake wrote: > On 12/3/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote: >> It's just a memory leak, but it's a regression in 4.2. >> >> Should we take it into 4.2? >=20 > Sorry, I was on holiday and then jury service, so I missed any chance at= =20 > getting this into -rc3.=C2=A0 The memory leak only happens on failure, an= d=20 > you'd have to be pretty desperate to purposefully attempt to open a lot= =20 > of NBD devices where you know you'll get a failure just to trigger=20 > enough of a leak to cause the OOM-killer to target qemu.=C2=A0 So I'm fin= e if=20 > this is deferred to 5.0, and just cc's qemu-stable (now done). >=20 > I'll queue this through my NBD tree for 5.0. Actually, given the review comments on 1/2, we'll probably be better off=20 with a v4 for the series. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org