From: Marek Vasut <marex@denx.de>
To: Neil Armstrong <narmstrong@baylibre.com>, Da Xue <da@libre.computer>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
u-boot-amlogic@groups.io, Tom Rini <trini@konsulko.com>,
Patrick DELAUNAY <patrick.delaunay@foss.st.com>
Subject: Re: [PATCH] configs: libretech: set SPI mode to 0
Date: Sat, 3 Jul 2021 00:26:51 +0200 [thread overview]
Message-ID: <ac66f043-ee28-12a7-e6aa-fec037cea5ff@denx.de> (raw)
In-Reply-To: <d19279ae-9cd6-9b74-2f57-bc0513e0317d@baylibre.com>
On 7/3/21 12:01 AM, Neil Armstrong wrote:
[...]
>> diff --git a/configs/libretech-s912-pc_defconfig b/configs/libretech-s912-pc_defconfig
>> index e2faea6242..669f000f7f 100644
>> --- a/configs/libretech-s912-pc_defconfig
>> +++ b/configs/libretech-s912-pc_defconfig
>> @@ -35,6 +35,7 @@ CONFIG_SARADC_MESON=y
>> CONFIG_MMC_MESON_GX=y
>> CONFIG_MTD=y
>> CONFIG_DM_SPI_FLASH=y
>> +CONFIG_SF_DEFAULT_MODE=0x0
>> CONFIG_SPI_FLASH_GIGADEVICE=y
>> CONFIG_PHY_REALTEK=y
>> CONFIG_DM_ETH=y
>> --
>> 2.30.2
>>
>>
>
> Thanks,
> Applying to u-boot-amlogic & sending PR to have it in this release
I have a feeling the real fix would be to revisit
14453fbfad ("Convert CONFIG_SF_DEFAULT_* to Kconfig")
change the default mode to 0 in Kconfig and fix up the few boards which
use SPI mode 3 .
But that can wait after the release, since I think most of the board
configs did get updated with SF_DEFAULT_MODE=0 config. CCing Patrick.
next prev parent reply other threads:[~2021-07-02 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 21:11 [PATCH] configs: libretech: set SPI mode to 0 Da Xue
2021-07-02 22:01 ` Neil Armstrong
2021-07-02 22:26 ` Marek Vasut [this message]
2021-07-02 23:10 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac66f043-ee28-12a7-e6aa-fec037cea5ff@denx.de \
--to=marex@denx.de \
--cc=da@libre.computer \
--cc=narmstrong@baylibre.com \
--cc=patrick.delaunay@foss.st.com \
--cc=trini@konsulko.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.