From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 810CAC3A59E for ; Wed, 21 Aug 2019 05:02:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44C782339D for ; Wed, 21 Aug 2019 05:02:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="diz8aflH"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="khAQESoR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727336AbfHUFCE (ORCPT ); Wed, 21 Aug 2019 01:02:04 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54244 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727076AbfHUFCE (ORCPT ); Wed, 21 Aug 2019 01:02:04 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 619C6608CE; Wed, 21 Aug 2019 05:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1566363723; bh=OAXHvSPcASypt4knp+um/R3qsvrj0A8AZ+xVOBmayO4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=diz8aflHFUW35YLB3+JlPG8vBzsU+wtkBV/QOXz10ckS1qFvNqsplp5U6i1J0Wn0m 0CHQlOIoFJlZFYybPKKYRB1pMejwIoElVladHPFGglq6/bt/9cmUGoACPV5k9ZFKt3 EWedm0beHRnPNK437+Io7AdNIkgXvLt1jRCpqGn4= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id B83E8608CE; Wed, 21 Aug 2019 05:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1566363722; bh=OAXHvSPcASypt4knp+um/R3qsvrj0A8AZ+xVOBmayO4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=khAQESoRJxq3DRAgV9aOv3HjhPETvHXCJA9Qou7aN9WdS/GR4PwlQRtbIBB6kOBmH QjKlQkRgQwFjuI4bNX49J7EeK0zr8/anSOSoFJtEQkSdmJ6KTmAZiQod3GmZMZ1+mu qHjmfiWfz4rJ9cYhV7ZjYyPRWqlGJp7Ov/vy+xBs= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 21 Aug 2019 10:32:02 +0530 From: Vasanthakumar Thiagarajan To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Kalle Valo , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, devicetree@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 31/49] ath11k: add mac.c In-Reply-To: <8736hvu6e6.fsf@toke.dk> References: <1566316095-27507-1-git-send-email-kvalo@codeaurora.org> <1566316095-27507-32-git-send-email-kvalo@codeaurora.org> <8736hvu6e6.fsf@toke.dk> Message-ID: X-Sender: vthiagar@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-08-20 22:21, Toke Høiland-Jørgensen wrote: > [... snip ... ] > >> +static const struct ieee80211_ops ath11k_ops = { >> + .tx = ath11k_mac_op_tx, > > No wake_tx_queue? :( Yes, packet queueing is handled in firmware. This makes sense especially when we enable 802.11 encap offload support where most of the data path processing in mac80211 will be skipped and packet is given to driver/firmware in 802.3 format itself. Then firmware would take care of all the classification, queueing and encapsulation operations. Vasanth From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasanthakumar Thiagarajan Subject: Re: [PATCH 31/49] ath11k: add mac.c Date: Wed, 21 Aug 2019 10:32:02 +0530 Message-ID: References: <1566316095-27507-1-git-send-email-kvalo@codeaurora.org> <1566316095-27507-32-git-send-email-kvalo@codeaurora.org> <8736hvu6e6.fsf@toke.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <8736hvu6e6.fsf-LJ9M9ZcSy1A@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Kalle Valo , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ath11k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 2019-08-20 22:21, Toke Høiland-Jørgensen wrote: > [... snip ... ] > >> +static const struct ieee80211_ops ath11k_ops = { >> + .tx = ath11k_mac_op_tx, > > No wake_tx_queue? :( Yes, packet queueing is handled in firmware. This makes sense especially when we enable 802.11 encap offload support where most of the data path processing in mac80211 will be skipped and packet is given to driver/firmware in 802.3 format itself. Then firmware would take care of all the classification, queueing and encapsulation operations. Vasanth From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0Il4-0007ic-ME for ath11k@lists.infradead.org; Wed, 21 Aug 2019 05:02:07 +0000 MIME-Version: 1.0 Date: Wed, 21 Aug 2019 10:32:02 +0530 From: Vasanthakumar Thiagarajan Subject: Re: [PATCH 31/49] ath11k: add mac.c In-Reply-To: <8736hvu6e6.fsf@toke.dk> References: <1566316095-27507-1-git-send-email-kvalo@codeaurora.org> <1566316095-27507-32-git-send-email-kvalo@codeaurora.org> <8736hvu6e6.fsf@toke.dk> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless-owner@vger.kernel.org, devicetree@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, Kalle Valo T24gMjAxOS0wOC0yMCAyMjoyMSwgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+IFsu Li4gc25pcCAuLi4gXQo+IAo+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBpZWVlODAyMTFfb3BzIGF0 aDExa19vcHMgPSB7Cj4+ICsJLnR4CQkJCT0gYXRoMTFrX21hY19vcF90eCwKPiAKPiBObyB3YWtl X3R4X3F1ZXVlPyA6KAoKWWVzLCBwYWNrZXQgcXVldWVpbmcgaXMgaGFuZGxlZCBpbiBmaXJtd2Fy ZS4gVGhpcyBtYWtlcyBzZW5zZSBlc3BlY2lhbGx5IAp3aGVuIHdlIGVuYWJsZSA4MDIuMTEgZW5j YXAKb2ZmbG9hZCBzdXBwb3J0IHdoZXJlIG1vc3Qgb2YgdGhlIGRhdGEgcGF0aCBwcm9jZXNzaW5n IGluIG1hYzgwMjExIHdpbGwgCmJlIHNraXBwZWQgYW5kIHBhY2tldCBpcyBnaXZlbgp0byBkcml2 ZXIvZmlybXdhcmUgaW4gODAyLjMgZm9ybWF0IGl0c2VsZi4gVGhlbiBmaXJtd2FyZSB3b3VsZCB0 YWtlIGNhcmUgCm9mIGFsbCB0aGUgY2xhc3NpZmljYXRpb24sCnF1ZXVlaW5nIGFuZCBlbmNhcHN1 bGF0aW9uIG9wZXJhdGlvbnMuCgpWYXNhbnRoCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwphdGgxMWsgbWFpbGluZyBsaXN0CmF0aDExa0BsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRo MTFrCg==