From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWNpH-0001Px-Fn for qemu-devel@nongnu.org; Mon, 21 May 2012 04:18:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWNpF-00052s-PU for qemu-devel@nongnu.org; Mon, 21 May 2012 04:18:47 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:38393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWNpF-00052g-HX for qemu-devel@nongnu.org; Mon, 21 May 2012 04:18:45 -0400 Date: Mon, 21 May 2012 04:18:43 -0400 (EDT) From: Paolo Bonzini Message-ID: In-Reply-To: <4FB9F973.7030800@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Blue Swirl , qemu-devel > >> What do you mean by fixing? Turning them into DPRINTFs? > > > > Or trace events? > > Yeah, you could turn all FLOPPY_DPRINTFs into trace events. But the > point here is that today it's a FLOPPY_ERROR, and except for register > fuzzing they report real problems with the emulation and not just > some debugging information. So I'm not sure if hiding them is really a > fix. It depends, "controller not ready for reading" is most likely just caused by fuzzing. Most unimplemented commands are also invalid on real hardware too. Paolo