Re: [PATCH v2 0/3] Fix the "-nic help" option

From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	pbonzini@redhat.com,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 0/3] Fix the "-nic help" option
Date: Thu, 15 Dec 2022 16:23:00 +0100	[thread overview]
Message-ID: <ac836d36-16ab-7fca-da0b-dc9ec93ee38f@redhat.com> (raw)
In-Reply-To: <20221110125224.99596-1-thuth@redhat.com>

On 10/11/2022 13.52, Thomas Huth wrote:
> Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier
> versions, but since QEMU 6.0 it just complains that "help" is not
> a valid value here. This patch series fixes this problem and also
> extends the help output here to list the available NIC models, too.
> 
> v2:
>   - Add function comment in the first patch
>   - Add Reviewed-by in the third patch
> 
> Thomas Huth (3):
>    net: Move the code to collect available NIC models to a separate
>      function
>    net: Restore printing of the help text with "-nic help"
>    net: Replace "Supported NIC models" with "Available NIC models"
> 
>   include/net/net.h | 14 +++++++++++++
>   hw/pci/pci.c      | 29 +--------------------------
>   net/net.c         | 50 ++++++++++++++++++++++++++++++++++++++++++++---
>   3 files changed, 62 insertions(+), 31 deletions(-)
> 

Friendly ping!

  Thomas